From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.4216.1605188521370526983 for ; Thu, 12 Nov 2020 05:42:02 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([116.232.42.12]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 12 Nov 2020 21:41:49 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: , References: <20201104190346.8096-1-pete@akeo.ie> <001a01d6b896$755a0f90$600e2eb0$@byosoft.com.cn> <6ad8a441-ddce-d379-954c-fb2e3e0dabb2@akeo.ie> In-Reply-To: <6ad8a441-ddce-d379-954c-fb2e3e0dabb2@akeo.ie> Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSBbUEFUQ0ggMS8xXSBNZGVQa2cvQmFzZVJuZ0xpYkR4ZTogQWRkIERYRV9SVU5USU1FX0RSSVZFUiBjbGFzcyB0byBSbmdMaWI=?= Date: Thu, 12 Nov 2020 21:41:50 +0800 Message-ID: <003901d6b8f9$93000d70$b9002850$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQG/vW7gzgTNckdsApgNo1Hk9bbOCgHBpsrtAgzcIa0B5Ogx6qnE3Kog Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Pete: This detail is enough. Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+67385+4905953+8761045@groups.io > =B4=FA=B1=ED Pete Batard > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C212=C8=D5 20:10 > =CA=D5=BC=FE=C8=CB: gaoliming ; devel@edk2.gro= ups.io; > samer.el-haj-mahmoud@arm.com > =B3=AD=CB=CD: michael.d.kinney@intel.com; zhiguang.liu@intel.com > =D6=F7=CC=E2: Re: =BB=D8=B8=B4: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngL= ibDxe: Add > DXE_RUNTIME_DRIVER class to RngLib >=20 > Hi Liming, >=20 > On 2020.11.12 01:52, gaoliming wrote: > > I agree this library instance can be used for RUNTIME driver before bo= ot to > > OS. > > > > Can you let me know which runtime driver consumes it? >=20 > It's OpenSslLib. >=20 > As per > https://github.com/tianocore/edk2-platforms/commit/1e09147a01aeb45aa4 > 3e36923d96a1d6b0ec9106 > we had to introduce a dependency to RngLib to keep OpenSslLib happy, and > the build breaks in VariableRuntimeDxe since it depends on OpenSslLib > which itself now depends on RngLib. >=20 > Here's the verbose build output that shows it: >=20 > Library instances of module > [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun > timeDxe.inf] > [AARCH64]: > MemoryAllocationLib : > /usr/src/edk2/MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocati > onLib.inf > BaseLib : /usr/src/edk2/MdePkg/Library/BaseLib/BaseLib.inf > SynchronizationLib : > /usr/src/edk2/MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationL > ib.inf > UefiLib : /usr/src/edk2/MdePkg/Library/UefiLib/UefiLib.inf > UefiBootServicesTableLib : > /usr/src/edk2/MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTa > bleLib.inf > BaseMemoryLib : > /usr/src/edk2/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOpt > Dxe.inf > DebugLib : > /usr/src/edk2/MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > UefiRuntimeLib : > /usr/src/edk2/MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf > DxeServicesTableLib : > /usr/src/edk2/MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > UefiDriverEntryPoint : > /usr/src/edk2/MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.i= nf > PcdLib : /usr/src/edk2/MdePkg/Library/DxePcdLib/DxePcdLib.inf > HobLib : /usr/src/edk2/MdePkg/Library/DxeHobLib/DxeHobLib.inf > TpmMeasurementLib : > /usr/src/edk2/SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasur > ementLib.inf > AuthVariableLib : > /usr/src/edk2/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > VarCheckLib : > /usr/src/edk2/MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > NULL2 : > /usr/src/edk2/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > NULL1 : > /usr/src/edk2/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.i= nf > NULL4 : > /usr/src/edk2/MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > DevicePathLib : > /usr/src/edk2/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PrintLib : > /usr/src/edk2/MdePkg/Library/BasePrintLib/BasePrintLib.inf > BaseCryptLib : > /usr/src/edk2/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > PlatformSecureLib : > /usr/src/edk2/OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > UefiRuntimeServicesTableLib : > /usr/src/edk2/MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeSer > vicesTableLib.inf > OpensslLib : > /usr/src/edk2/CryptoPkg/Library/OpensslLib/OpensslLib.inf > IntrinsicLib : > /usr/src/edk2/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf >=20 >=20 > build.py... > /usr/src/edk2-platforms/Platform/RaspberryPi/RPi4/RPi4.dsc(...): error > 1001: Module type [DXE_RUNTIME_DRIVER] is not supported by library > instance [/usr/src/edk2/MdePkg/Library/DxeRngLib/DxeRngLib.inf] > consumed by > [/usr/src/edk2/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRun > timeDxe.inf] >=20 > > And, please make sure > > the consumer code runs in boot phase only. >=20 > That's for Secure Boot, so I think we should be okay. >=20 > Regards, >=20 > /Pete >=20 > > > > Thanks > > Liming > >> -----=D3=CA=BC=FE=D4=AD=BC=FE----- > >> =B7=A2=BC=FE=C8=CB: bounce+27952+67295+4905953+8761045@groups.io > >> =B4=FA=B1=ED Samer > >> El-Haj-Mahmoud > >> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C212=C8=D5 1:38 > >> =CA=D5=BC=FE=C8=CB: Pete Batard ; devel@edk2.groups.io > >> =B3=AD=CB=CD: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > >> zhiguang.liu@intel.com > >> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH 1/1] MdePkg/BaseRngLibDxe: Add > >> DXE_RUNTIME_DRIVER class to RngLib > >> > >> Reviewed-by: Samer El-Haj-Mahmoud > > >> > >>> -----Original Message----- > >>> From: Pete Batard > >>> Sent: Wednesday, November 4, 2020 2:04 PM > >>> To: devel@edk2.groups.io > >>> Cc: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > >>> zhiguang.liu@intel.com; Samer El-Haj-Mahmoud >>> Mahmoud@arm.com> > >>> Subject: [PATCH 1/1] MdePkg/BaseRngLibDxe: Add > DXE_RUNTIME_DRIVER > >>> class to RngLib > >>> > >>> The Raspberry Pi platform with Secure Boot enabled currently fails t= o > > build > >>> with error: > >>> > >>> Module type [DXE_RUNTIME_DRIVER] is not supported by library > >> instance > >>> > >>> > [/home/appveyor/projects/rpi4/edk2/MdePkg/Library/DxeRngLib/DxeRngLi > >>> b.inf] > >>> > >>> Add the missing class to fix this issue. > >>> > >>> Signed-off-by: Pete Batard > >>> --- > >>> MdePkg/Library/DxeRngLib/DxeRngLib.inf | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/MdePkg/Library/DxeRngLib/DxeRngLib.inf > >>> b/MdePkg/Library/DxeRngLib/DxeRngLib.inf > >>> index 68554ad21146..9c11959f8aeb 100644 > >>> --- a/MdePkg/Library/DxeRngLib/DxeRngLib.inf > >>> +++ b/MdePkg/Library/DxeRngLib/DxeRngLib.inf > >>> @@ -14,7 +14,7 @@ [Defines] > >>> FILE_GUID =3D FF9F84C5-A33E-44E3-9BB5-0D654B2D4149 > >>> MODULE_TYPE =3D DXE_DRIVER > >>> VERSION_STRING =3D 1.0 > >>> - LIBRARY_CLASS =3D RngLib|DXE_DRIVER UEFI_APPLICATION > >> UEFI_DRIVER > >>> + LIBRARY_CLASS =3D RngLib|DXE_DRIVER DXE_RUNTIME_DRIVER > >>> UEFI_APPLICATION UEFI_DRIVER > >>> > >>> [Packages] > >>> MdePkg/MdePkg.dec > >>> -- > >>> 2.21.0.windows.1 > >> > >> IMPORTANT NOTICE: The contents of this email and any attachments are > >> confidential and may also be privileged. If you are not the intended > > recipient, > >> please notify the sender immediately and do not disclose the contents to > > any > >> other person, use it for any purpose, or store or copy the informatio= n in > > any > >> medium. Thank you. > >> > >> > >> > >> > > > > > > >=20 >=20 >=20 >=20 >=20