Matthew:

 I can get your patch from matthewfcarlson/edk2: EDK II (github.com). There are still some file format issues in this patch.

1. BaseTools/BinPipWrappers/PosixLike/Brotli can be removed. It is not required any more.

2. BaseTools/BinPipWrappers/PosixLike/build file mode should be 100755 instead of 100644, because this file needs executable attribute. You can use git update-index --chmod=+x file to set the file mode. All files in BaseTools/BinPipWrappers/PosixLike have the same problem.

3. BaseTools/BinPipWrappers/WindowsLike/build.bat is the windows batch script. It should be DOS style instead of UNIX. All files in BaseTools/BinPipWrappers/WindowsLike have the same problem.

4. BaseTools/BuildEnv is Linux script. It should be UNIX style. Please keep it.

Thanks

Liming

发件人: tosubbounce+27952+0+0+0@groups.io <tosubbounce+27952+0+0+0@groups.io> 代表 macarl via []
发送时间: 2021年1月16日 11:15
收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v3 1/1] BaseTools: Use pip module if available, CI uses it by default

Sure. Is this the forked repo you mean? tianocore/edk2-basetools: EDK II BaseTools Python tools as a PIP module (github.com)
Or this one: matthewfcarlson/edk2: EDK II (github.com)
--
- Matthew Carlson