From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <abner.chang@hpe.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>,
"'Wang, Nickle \(HPS SW\)'" <nickle.wang@hpe.com>
Subject: 回复: [edk2-devel] [VFR support REST_STYLE PATCH v2 2/3] BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option
Date: Mon, 9 Nov 2020 09:01:15 +0800 [thread overview]
Message-ID: <003f01d6b633$d348a8b0$79d9fa10$@byosoft.com.cn> (raw)
In-Reply-To: <CS1PR8401MB1144327F4CC1E381C621B96EFFED0@CS1PR8401MB1144.NAMPRD84.PROD.OUTLOOK.COM>
Abner:
Also send the patch to edk2 mail list for the change in VFR spec.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67081+4905953+8761045@groups.io
> <bounce+27952+67081+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2020年11月6日 15:09
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> 主题: Re: [edk2-devel] [VFR support REST_STYLE PATCH v2 2/3]
> BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option
>
>
>
> > -----Original Message-----
> > From: gaoliming [mailto:gaoliming@byosoft.com.cn]
> > Sent: Wednesday, November 4, 2020 1:18 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Cc: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> > <yuwei.chen@intel.com>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: 回复: [edk2-devel] [VFR support REST_STYLE PATCH v2 2/3]
> > BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option
> >
> > Anber:
> > This patch set is related to BZ
> > INVALID URI REMOVED
> > 3A__bugzilla.tianocore.org_show-5Fbug.cgi-3Fid-
> >
> 3D2916&d=DwIFbw&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulk
> s
> >
> kz6qU3NYRO03nHp9P7Z5q59A3E&m=RhXI_8zZpu44C2PjRLMwse05Y7MB8xy
> >
> QQKdX1wW9akk&s=5QKMzaPNf9J7qWrRj5Of2TA8g2ZwdxmQtj8QPn0xaXc&
> > e= . Please include BZ in the commit message.
> > With this change, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > Besides, please also submit the patch to update VFR spec
> > https://github.com/tianocore-docs/edk2-VfrSpecification
>
> Hi Liming,
> The patch for VFR spec change should be sent to mailing list or just
create a
> PR on Github?
> Thanks
>
> Abner
>
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66901+4905953+8761045@groups.io
> > > <bounce+27952+66901+4905953+8761045@groups.io> 代表 Abner
> Chang
> > > 发送时间: 2020年11月3日 10:41
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> > Nickle
> > > Wang <nickle.wang@hpe.com>
> > > 主题: [edk2-devel] [VFR support REST_STYLE PATCH v2 2/3]
> > > BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option
> > >
> > > Add REST_STYLE support on VFR language
> > >
> > > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > > Signed-off-by: Ye Ting <ting.ye@intel.com>
> > > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > >
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > Cc: Nickle Wang <nickle.wang@hpe.com>
> > > ---
> > > BaseTools/Source/C/VfrCompile/VfrSyntax.g | 25
> > > ++++++++++++++++++++---
> > > 1 file changed, 22 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/BaseTools/Source/C/VfrCompile/VfrSyntax.g
> > > b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
> > > index 127cb8b2b2..3f896c6f1a 100644
> > > --- a/BaseTools/Source/C/VfrCompile/VfrSyntax.g
> > > +++ b/BaseTools/Source/C/VfrCompile/VfrSyntax.g
> > > @@ -192,6 +192,7 @@ VfrParserStart (
> > > #token LateCheckFlag("LATE_CHECK") "LATE_CHECK"
> > > #token ReadOnlyFlag("READ_ONLY") "READ_ONLY"
> > > #token OptionOnlyFlag("OPTIONS_ONLY")
> "OPTIONS_ONLY"
> > > +#token RestStyleFlag("REST_STYLE") "REST_STYLE"
> > > #token Class("class") "class"
> > > #token Subclass("subclass") "subclass"
> > > #token ClassGuid("classguid") "classguid"
> > > @@ -584,7 +585,7 @@ vfrFormSetDefinition :
> > > <<
> > > EFI_GUID Guid;
> > > EFI_GUID DefaultClassGuid =
> > > EFI_HII_PLATFORM_SETUP_FORMSET_GUID;
> > > - EFI_GUID ClassGuid1, ClassGuid2, ClassGuid3;
> > > + EFI_GUID ClassGuid1, ClassGuid2, ClassGuid3, ClassGuid4;
> > > UINT8 ClassGuidNum = 0;
> > > CIfrFormSet *FSObj = NULL;
> > > UINT16 C, SC;
> > > @@ -600,13 +601,16 @@ vfrFormSetDefinition :
> > > "\|" guidDefinition[ClassGuid2] <<
> > > ++ClassGuidNum; >>
> > > {
> > > "\|" guidDefinition[ClassGuid3] <<
> > > ++ClassGuidNum; >>
> > > + {
> > > + "\|" guidDefinition[ClassGuid4] <<
> > > ++ClassGuidNum; >>
> > > + }
> > > }
> > > }
> > > ","
> > > }
> > > <<
> > > - if
> > > (mOverrideClassGuid != NULL && ClassGuidNum >= 3) {
> > > -
> > > _PCATCH (VFR_RETURN_INVALID_PARAMETER, L->getLine(), "Already has
> > 3
> > > class guids, can't add extra class guid!");
> > > + if
> > > (mOverrideClassGuid != NULL && ClassGuidNum >= 4) {
> > > +
> > > _PCATCH (VFR_RETURN_INVALID_PARAMETER, L->getLine(), "Already has
> > 4
> > > class guids, can't add extra class guid!");
> > > }
> > >
> switch
> > > (ClassGuidNum) {
> > > case
> 0:
> > > @@ -643,10 +647,23 @@ vfrFormSetDefinition :
> > > }
> > >
> break;
> > > case
> 3:
> > > + if
> > > (mOverrideClassGuid != NULL) {
> > > +
> > > ClassGuidNum ++;
> > > + }
> > > +
> FSObj
> > > = new CIfrFormSet(sizeof(EFI_IFR_FORM_SET) + ClassGuidNum *
> > > sizeof(EFI_GUID));
> > > +
> > > FSObj->SetClassGuid(&ClassGuid1);
> > > +
> > > FSObj->SetClassGuid(&ClassGuid2);
> > > +
> > > FSObj->SetClassGuid(&ClassGuid3);
> > > + if
> > > (mOverrideClassGuid != NULL) {
> > > +
> > > FSObj->SetClassGuid(mOverrideClassGuid);
> > > + }
> > > +
> break;
> > > + case
> 4:
> > >
> FSObj = new
> > > CIfrFormSet(sizeof(EFI_IFR_FORM_SET) + ClassGuidNum *
> > > sizeof(EFI_GUID));
> > >
> > > FSObj->SetClassGuid(&ClassGuid1);
> > >
> > > FSObj->SetClassGuid(&ClassGuid2);
> > >
> > > FSObj->SetClassGuid(&ClassGuid3);
> > > +
> > > FSObj->SetClassGuid(&ClassGuid4);
> > >
> break;
> > >
> default:
> > >
> break; @@
> > > -1321,6 +1338,7 @@ questionheaderFlagsField[UINT8 & Flags] :
> > > ReadOnlyFlag <<
> $Flags |=
> > > 0x01; >>
> > > | InteractiveFlag << $Flags
> |=
> > > 0x04; >>
> > > | ResetRequiredFlag << $Flags
> |=
> > > 0x10; >>
> > > + | RestStyleFlag << $Flags
> |=
> > > 0x20; >>
> > > | ReconnectRequiredFlag << $Flags
> |=
> > > 0x40; >>
> > > | O:OptionOnlyFlag <<
> > >
> > > gCVfrErrorHandle.HandleWarning (
> > > @@ -3766,6 +3784,7 @@ oneofoptionFlagsField [UINT8 & HFlags, UINT8
> &
> > > LFlags] :
> > > | "OPTION_DEFAULT_MFG" <<
> > > $LFlags |= 0x20; >>
> > > | InteractiveFlag <<
> $HFlags
> > > |= 0x04; >>
> > > | ResetRequiredFlag <<
> $HFlags
> > > |= 0x10; >>
> > > + | RestStyleFlag <<
> $HFlags
> > > |= 0x20; >>
> > > | ReconnectRequiredFlag <<
> $HFlags
> > > |= 0x40; >>
> > > | ManufacturingFlag <<
> $LFlags
> > > |= 0x20; >>
> > > | DefaultFlag <<
> $LFlags
> > > |= 0x10; >>
> > > --
> > > 2.17.1
> > >
> > >
> > >
> > >
> > >
> >
> >
>
>
>
>
>
next prev parent reply other threads:[~2020-11-09 1:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 2:40 [VFR support REST_STYLE PATCH v2 0/3] VFR support REST_STYLE Abner Chang
2020-11-03 2:40 ` [VFR support REST_STYLE PATCH v2 1/3] MdePkg: Add GUID for REST Style Formset Abner Chang
2020-11-04 5:15 ` 回复: " gaoliming
2020-11-03 2:40 ` [VFR support REST_STYLE PATCH v2 2/3] BaseTools/VfrCompile: VFR compiler supports REST_STYLE in HII option Abner Chang
2020-11-04 5:17 ` 回复: [edk2-devel] " gaoliming
2020-11-06 7:09 ` Abner Chang
2020-11-09 1:01 ` gaoliming [this message]
2020-11-03 2:41 ` [VFR support REST_STYLE PATCH v2 3/3] MdeModulePkg/DriverSampleDxe: Add HII sample options Abner Chang
2020-11-04 5:19 ` 回复: [edk2-devel] " gaoliming
2020-11-04 6:40 ` Abner Chang
[not found] ` <16443AD1740FEC1A.12282@groups.io>
2020-11-04 7:26 ` Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003f01d6b633$d348a8b0$79d9fa10$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox