From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ard Biesheuvel'" <ard.biesheuvel@arm.com>,
"'Laszlo Ersek'" <lersek@redhat.com>, <devel@edk2.groups.io>
Cc: "'Dandan Bi'" <dandan.bi@intel.com>,
"'Jian J Wang'" <jian.j.wang@intel.com>,
"'Hao A Wu'" <hao.a.wu@intel.com>,
"'Sami Mujawar'" <sami.mujawar@arm.com>,
"'Leif Lindholm'" <leif@nuviainc.com>
Subject: 回复: 回复: 回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/AcpiTableDxe: use pool allocations when possible
Date: Tue, 27 Oct 2020 16:45:19 +0800 [thread overview]
Message-ID: <004001d6ac3d$80117aa0$80346fe0$@byosoft.com.cn> (raw)
In-Reply-To: <756ec3e7-a1df-8251-f284-07b7aa45ef7f@arm.com>
Ard:
After removes BIT1 from gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions for OVMFX64, the memory ACPI_Recl will be reduced with this patch set.
I also review the code logic. I don't find other issue. I see Laszlo gives one comment on CurrentTableList. It is from AllocatePool(). If so, CurrentTableList->PoolAllocation value should be set to FALSE.
Thanks
Liming
> -----邮件原件-----
> 发件人: Ard Biesheuvel <ard.biesheuvel@arm.com>
> 发送时间: 2020年10月26日 15:43
> 收件人: Laszlo Ersek <lersek@redhat.com>; gaoliming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Dandan Bi' <dandan.bi@intel.com>; 'Jian J Wang'
> <jian.j.wang@intel.com>; 'Hao A Wu' <hao.a.wu@intel.com>; 'Sami Mujawar'
> <sami.mujawar@arm.com>; 'Leif Lindholm' <leif@nuviainc.com>
> 主题: Re: 回复: 回复: [edk2-devel] [PATCH 1/3]
> MdeModulePkg/AcpiTableDxe: use pool allocations when possible
>
> On 10/26/20 7:25 AM, Laszlo Ersek wrote:
> > On 10/26/20 02:35, gaoliming wrote:
> >> Ard:
> >> I verify this patch on OvmfX64 and collect the memmap info. I don't
> see the difference in memmap.
> >> So, this enhancement is for AARCH64 only. Is it right?
> >
> > That's my understanding, yes. OVMF enables ACPI 1.0b support in the
> > bitmask PCD, and so the compat code for 32-bit allocations (= page
> > allocations for expressing the 4GB limit) remains active.
> >
>
> Indeed. Any platform that removes BIT1 from
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions
>
> will switch over to pool allocations, but OVMF retains support for ACPI
> 1.0b for some reason.
next prev parent reply other threads:[~2020-10-27 8:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:49 [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables Ard Biesheuvel
2020-10-16 15:49 ` [PATCH 1/3] MdeModulePkg/AcpiTableDxe: use pool allocations when possible Ard Biesheuvel
2020-10-19 19:47 ` [edk2-devel] " Laszlo Ersek
2020-10-22 2:01 ` 回复: " gaoliming
2020-10-22 12:55 ` Ard Biesheuvel
2020-10-26 1:35 ` 回复: " gaoliming
2020-10-26 6:25 ` Laszlo Ersek
2020-10-26 7:42 ` Ard Biesheuvel
2020-10-27 8:45 ` gaoliming [this message]
2020-10-27 9:05 ` 回复: " Ard Biesheuvel
2020-10-27 11:07 ` Laszlo Ersek
2020-10-16 15:49 ` [PATCH 2/3] MdeModulePkg/AcpiTableDxe: use pool allocation for RSDT/XSDT if possible Ard Biesheuvel
2020-10-19 20:06 ` [edk2-devel] " Laszlo Ersek
2020-10-19 20:11 ` Laszlo Ersek
2020-10-16 15:49 ` [PATCH 3/3] MdeModulePkg/AcpiTableDxe: use pool allocation for RSDP " Ard Biesheuvel
2020-10-19 20:13 ` [edk2-devel] " Laszlo Ersek
2020-10-19 1:28 ` FW: [PATCH 0/3] MdeModulePkg: use pool allocations for ACPI tables Wu, Hao A
2020-10-19 1:59 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004001d6ac3d$80117aa0$80346fe0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox