public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <anbazhagan@hp.com>
Cc: <jian.j.wang@intel.com>, <hao.a.wu@intel.com>
Subject: 回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort
Date: Thu, 10 Dec 2020 09:28:26 +0800	[thread overview]
Message-ID: <004101d6ce93$c22f9160$468eb420$@byosoft.com.cn> (raw)
In-Reply-To: <AT5PR8401MB08822F0171FDAC847243F731BACB0@AT5PR8401MB0882.NAMPRD84.PROD.OUTLOOK.COM>

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

发件人: bounce+27952+68609+4905953+8761045@groups.io
<bounce+27952+68609+4905953+8761045@groups.io> 代表 Anbazhagan,
Baraneedharan via groups.io
发送时间: 2020年12月10日 8:21
收件人: devel@edk2.groups.io
抄送: gaoliming@byosoft.com.cn; jian.j.wang@intel.com; hao.a.wu@intel.com
主题: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

 

Coding error in converting memset call to SetMem - Length and Value

is not swapped on calling SetMem

 

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com
<mailto:anbazhagan@hp.com> >

---

MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

index 2b2b0d420d..9aa7b0a68e 100644

--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int
count)

 

 void* memset (void *dest, char ch, unsigned int count)

{

-  return SetMem (dest, ch, count);

+  return SetMem (dest, count, ch);

}

 

-- 

2.29.2.windows.3

 




[-- Attachment #2: Type: text/html, Size: 5787 bytes --]

  reply	other threads:[~2020-12-10  1:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  0:21 MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort Anbazhagan, Baraneedharan
2020-12-10  1:28 ` gaoliming [this message]
     [not found] ` <164F36ADB5F781C1.18718@groups.io>
2020-12-14  2:00   ` 回复: [edk2-devel] " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004101d6ce93$c22f9160$468eb420$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox