From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
<ashishsingha@nvidia.com>,
"'Samer El-Haj-Mahmoud'" <Samer.El-Haj-Mahmoud@arm.com>,
<michael.d.kinney@intel.com>, <zhiguang.liu@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
Date: Wed, 2 Jun 2021 13:56:55 +0800 [thread overview]
Message-ID: <004301d75774$17c183e0$47448ba0$@byosoft.com.cn> (raw)
In-Reply-To: <1680FDC38B67BCC1.12041@groups.io>
[-- Attachment #1: Type: text/plain, Size: 6496 bytes --]
Merge at fdf3666f01a2dd02d83a808f609b9c744a74c652
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
发送时间: 2021年5月21日 13:28
收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; ashishsingha@nvidia.
com; 'Samer El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud@arm.com>;
michael.d.kinney@intel.com; zhiguang.liu@intel.com
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
Ashish:
Sorry. I miss the patch cover letter. I see this subtype is defined in
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug
-port-table.
So, I agree this fix. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn
<mailto:gaoliming@byosoft.com.cn> >
Now, we are in Soft Feature Freeze for edk2-stable202105. I will merge
this patch once edk2-stable202105 is created.
Thanks
Liming
发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 gaoliming
发送时间: 2021年5月21日 13:20
收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> ; 'Samer
El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >; michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> ; zhiguang.liu@intel.com
<mailto:zhiguang.liu@intel.com>
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
Ashish:
Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share
the link?
Thanks
Liming
发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> ; michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn
<mailto:gaoliming@byosoft.com.cn> ; zhiguang.liu@intel.com <mailto:zhiguang.
liu@intel.com>
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
NVIDIA 16550 Subtype
Hello Michael/Gao/Zhiguang,
Any update on this?
Thanks
Ashish
_____
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Ashish Singhal
<ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> >;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >;
gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>
<gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> <zhiguang.liu@intel.
com <mailto:zhiguang.liu@intel.com> >
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype
External email: Use caution opening links or attachments
Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
> -----Original Message-----
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ;
> gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com>
> Cc: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
>
> ---
> MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 +
> .../IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
> #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC 0x0001
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
> #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
> #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
> ///
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART 0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART 0x05
> +
> ///
> /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
[deprecated]
> ///
> --
> 2.17.1
>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.
[-- Attachment #2: Type: text/html, Size: 14630 bytes --]
prev parent reply other threads:[~2021-06-02 5:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 18:37 [PATCH 0/1] Add NVIDIA 16550 UART ACPI Subtype Ashish Singhal
2021-05-18 18:37 ` [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype Ashish Singhal
2021-05-18 21:14 ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-05-20 20:32 ` Ashish Singhal
2021-05-21 5:20 ` 回复: " gaoliming
2021-05-21 6:08 ` Sunny Wang
[not found] ` <1680FD5B20378614.12041@groups.io>
2021-05-21 5:27 ` 回复: " gaoliming
[not found] ` <1680FDC38B67BCC1.12041@groups.io>
2021-06-02 5:56 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004301d75774$17c183e0$47448ba0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox