public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 0/1] Add NVIDIA 16550 UART ACPI Subtype
@ 2021-05-18 18:37 Ashish Singhal
  2021-05-18 18:37 ` [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype Ashish Singhal
  0 siblings, 1 reply; 8+ messages in thread
From: Ashish Singhal @ 2021-05-18 18:37 UTC (permalink / raw)
  To: devel, michael.d.kinney, gaoliming, zhiguang.liu; +Cc: Ashish Singhal

This patch adds macro for NVIDIA 16550 UART subtype for ACPI
tables as documented by Microsoft.

https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table

Ashish Singhal (1):
  MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

 MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
 .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
 2 files changed, 6 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
  2021-05-18 18:37 [PATCH 0/1] Add NVIDIA 16550 UART ACPI Subtype Ashish Singhal
@ 2021-05-18 18:37 ` Ashish Singhal
  2021-05-18 21:14   ` [edk2-devel] " Samer El-Haj-Mahmoud
  0 siblings, 1 reply; 8+ messages in thread
From: Ashish Singhal @ 2021-05-18 18:37 UTC (permalink / raw)
  To: devel, michael.d.kinney, gaoliming, zhiguang.liu; +Cc: Ashish Singhal

Add macros for NVIDIA 16550 UART specific debug port subtype in both
DBG2 as well as SPCR header file.

Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>

---
 MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
 .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
 2 files changed, 6 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
index 3faa30b76a..6a6fd2590e 100644
--- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
+++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
@@ -43,6 +43,7 @@ typedef struct {
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550                                 0x0000
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_MS_DBGP_SPEC  0x0001
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART                             0x0003
+#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART                          0x0005
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X                   0x000d
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART                      0x000e
 #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC                                        0x000f
diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index 2066c7895e..ba19567f52 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -80,6 +80,11 @@ typedef struct {
 ///
 #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_ARM_PL011_UART            0x03
 
+///
+/// NVIDIA 16550 UART
+///
+#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NVIDIA_16550_UART         0x05
+
 ///
 /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses [deprecated]
 ///
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
  2021-05-18 18:37 ` [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype Ashish Singhal
@ 2021-05-18 21:14   ` Samer El-Haj-Mahmoud
  2021-05-20 20:32     ` Ashish Singhal
  0 siblings, 1 reply; 8+ messages in thread
From: Samer El-Haj-Mahmoud @ 2021-05-18 21:14 UTC (permalink / raw)
  To: devel@edk2.groups.io, ashishsingha@nvidia.com,
	michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
	zhiguang.liu@intel.com
  Cc: Samer El-Haj-Mahmoud

Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses [deprecated]
> ///
> --
> 2.17.1
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
  2021-05-18 21:14   ` [edk2-devel] " Samer El-Haj-Mahmoud
@ 2021-05-20 20:32     ` Ashish Singhal
  2021-05-21  5:20       ` 回复: " gaoliming
       [not found]       ` <1680FD5B20378614.12041@groups.io>
  0 siblings, 2 replies; 8+ messages in thread
From: Ashish Singhal @ 2021-05-20 20:32 UTC (permalink / raw)
  To: Samer El-Haj-Mahmoud, devel@edk2.groups.io,
	michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
	zhiguang.liu@intel.com

[-- Attachment #1: Type: text/plain, Size: 3535 bytes --]

Hello Michael/Gao/Zhiguang,

Any update on this?

Thanks
Ashish
________________________________
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singhal <ashishsingha@nvidia.com>; michael.d.kinney@intel.com <michael.d.kinney@intel.com>; gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; zhiguang.liu@intel.com <zhiguang.liu@intel.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

External email: Use caution opening links or attachments


Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses [deprecated]
> ///
> --
> 2.17.1
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 5697 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
  2021-05-20 20:32     ` Ashish Singhal
@ 2021-05-21  5:20       ` gaoliming
  2021-05-21  6:08         ` Sunny Wang
       [not found]       ` <1680FD5B20378614.12041@groups.io>
  1 sibling, 1 reply; 8+ messages in thread
From: gaoliming @ 2021-05-21  5:20 UTC (permalink / raw)
  To: devel, ashishsingha, 'Samer El-Haj-Mahmoud',
	michael.d.kinney, zhiguang.liu

[-- Attachment #1: Type: text/plain, Size: 4743 bytes --]

Ashish:

 Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share
the link?

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>;
devel@edk2.groups.io; michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
zhiguang.liu@intel.com
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
NVIDIA 16550 Subtype

 

Hello Michael/Gao/Zhiguang,

 

Any update on this?

 

Thanks

Ashish

  _____

From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Ashish Singhal
<ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> >;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >;
gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>
<gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com>  <zhiguang.liu@intel.
com <mailto:zhiguang.liu@intel.com> >
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype 

 

External email: Use caution opening links or attachments


Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >

> -----Original Message-----
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ;
> gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> 
> Cc: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
[deprecated]
> ///
> --
> 2.17.1
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.




[-- Attachment #2: Type: text/html, Size: 9990 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
       [not found]       ` <1680FD5B20378614.12041@groups.io>
@ 2021-05-21  5:27         ` gaoliming
       [not found]         ` <1680FDC38B67BCC1.12041@groups.io>
  1 sibling, 0 replies; 8+ messages in thread
From: gaoliming @ 2021-05-21  5:27 UTC (permalink / raw)
  To: devel, gaoliming, ashishsingha, 'Samer El-Haj-Mahmoud',
	michael.d.kinney, zhiguang.liu

[-- Attachment #1: Type: text/plain, Size: 5765 bytes --]

Ashish:

 Sorry. I miss the patch cover letter. I see this subtype is defined in
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug
-port-table. 

  So, I agree this fix. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>



  Now, we are in Soft Feature Freeze for edk2-stable202105. I will merge
this patch once edk2-stable202105 is created. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
发送时间: 2021年5月21日 13:20
收件人: devel@edk2.groups.io; ashishsingha@nvidia.com; 'Samer
El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud@arm.com>; michael.d.kinney@intel.com;
zhiguang.liu@intel.com
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype

 

Ashish:

 Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share
the link?

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> ; michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn
<mailto:gaoliming@byosoft.com.cn> ; zhiguang.liu@intel.com <mailto:zhiguang.
liu@intel.com> 
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
NVIDIA 16550 Subtype

 

Hello Michael/Gao/Zhiguang,

 

Any update on this?

 

Thanks

Ashish

  _____

From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Ashish Singhal
<ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> >;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >;
gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>
<gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com>  <zhiguang.liu@intel.
com <mailto:zhiguang.liu@intel.com> >
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype 

 

External email: Use caution opening links or attachments


Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >

> -----Original Message-----
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ;
> gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> 
> Cc: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
[deprecated]
> ///
> --
> 2.17.1
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.




[-- Attachment #2: Type: text/html, Size: 12843 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
  2021-05-21  5:20       ` 回复: " gaoliming
@ 2021-05-21  6:08         ` Sunny Wang
  0 siblings, 0 replies; 8+ messages in thread
From: Sunny Wang @ 2021-05-21  6:08 UTC (permalink / raw)
  To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
	ashishsingha@nvidia.com, Samer El-Haj-Mahmoud,
	michael.d.kinney@intel.com, zhiguang.liu@intel.com
  Cc: Sunny Wang

[-- Attachment #1: Type: text/plain, Size: 6305 bytes --]

The change looks good to me. Added some more info for Liming and others reference.

For DBG2, https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
Table 3. Debug port types and subtypes
0x0005 Nvidia 16550

For SPCR, https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table
Interface Type - See the Serial Port Subtypes in Table 3 of the DBG2 Specification<https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table>

Both links are in LINKS TO ACPI-RELATED DOCUMENTS in https://uefi.org/acpi

Reviewed-by: Sunny Wang <sunny.wang@arm.com<mailto:sunny.wang@arm.com>>

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Friday, May 21, 2021 1:20 PM
To: devel@edk2.groups.io; ashishsingha@nvidia.com; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

Ashish:
 Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share the link?

Thanks
Liming
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>; michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>; gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>; zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

Hello Michael/Gao/Zhiguang,

Any update on this?

Thanks
Ashish
________________________________
From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Ashish Singhal <ashishsingha@nvidia.com<mailto:ashishsingha@nvidia.com>>; michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn> <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>; zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com> <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype

External email: Use caution opening links or attachments


Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com<mailto:Samer.El-Haj-Mahmoud@arm.com>>

> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>;
> gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>; zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>
> Cc: Ashish Singhal <ashishsingha@nvidia.com<mailto:ashishsingha@nvidia.com>>
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com<mailto:ashishsingha@nvidia.com>>
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses [deprecated]
> ///
> --
> 2.17.1
>
>
>
>
>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

[-- Attachment #2: Type: text/html, Size: 14725 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype
       [not found]         ` <1680FDC38B67BCC1.12041@groups.io>
@ 2021-06-02  5:56           ` gaoliming
  0 siblings, 0 replies; 8+ messages in thread
From: gaoliming @ 2021-06-02  5:56 UTC (permalink / raw)
  To: devel, gaoliming, ashishsingha, 'Samer El-Haj-Mahmoud',
	michael.d.kinney, zhiguang.liu

[-- Attachment #1: Type: text/plain, Size: 6496 bytes --]

Merge at fdf3666f01a2dd02d83a808f609b9c744a74c652

 

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
发送时间: 2021年5月21日 13:28
收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; ashishsingha@nvidia.
com; 'Samer El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud@arm.com>;
michael.d.kinney@intel.com; zhiguang.liu@intel.com
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype

 

Ashish:

 Sorry. I miss the patch cover letter. I see this subtype is defined in
https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug
-port-table. 

  So, I agree this fix. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn
<mailto:gaoliming@byosoft.com.cn> >



  Now, we are in Soft Feature Freeze for edk2-stable202105. I will merge
this patch once edk2-stable202105 is created. 

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 gaoliming
发送时间: 2021年5月21日 13:20
收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> ; 'Samer
El-Haj-Mahmoud' <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >; michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> ; zhiguang.liu@intel.com
<mailto:zhiguang.liu@intel.com> 
主题: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype

 

Ashish:

 Is NVIDIA 16550 Subtype defined in the public spec? If yes, can you share
the link?

 

Thanks

Liming

发件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > 代表 Ashish Singhal
发送时间: 2021年5月21日 4:33
收件人: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >; devel@edk2.groups.io
<mailto:devel@edk2.groups.io> ; michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn
<mailto:gaoliming@byosoft.com.cn> ; zhiguang.liu@intel.com <mailto:zhiguang.
liu@intel.com> 
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
NVIDIA 16550 Subtype

 

Hello Michael/Gao/Zhiguang,

 

Any update on this?

 

Thanks

Ashish

  _____

From: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Sent: Tuesday, May 18, 2021 3:14 PM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Ashish Singhal
<ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com> >;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>
<michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> >;
gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>
<gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com>  <zhiguang.liu@intel.
com <mailto:zhiguang.liu@intel.com> >
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >
Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header
with NVIDIA 16550 Subtype 

 

External email: Use caution opening links or attachments


Reviewed-by: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com
<mailto:Samer.El-Haj-Mahmoud@arm.com> >

> -----Original Message-----
> From: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
<devel@edk2.groups.io <mailto:devel@edk2.groups.io> > On Behalf Of Ashish
> Singhal via groups.io
> Sent: Tuesday, May 18, 2021 2:38 PM
> To: devel@edk2.groups.io <mailto:devel@edk2.groups.io> ;
michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ;
> gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ;
zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> 
> Cc: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
> Subject: [edk2-devel] [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with
> NVIDIA 16550 Subtype
>
> Add macros for NVIDIA 16550 UART specific debug port subtype in both
> DBG2 as well as SPCR header file.
>
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com
<mailto:ashishsingha@nvidia.com> >
>
> ---
>  MdePkg/Include/IndustryStandard/DebugPort2Table.h            | 1 +
>  .../IndustryStandard/SerialPortConsoleRedirectionTable.h     | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> index 3faa30b76a..6a6fd2590e 100644
> --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h
> @@ -43,6 +43,7 @@ typedef struct {
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550
> 0x0000
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_
> MS_DBGP_SPEC  0x0001
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART
> 0x0003
> +#define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_NVIDIA_16550_UART
> 0x0005
>  #define
> EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X
> 0x000d
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART
> 0x000e
>  #define   EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC
> 0x000f
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index 2066c7895e..ba19567f52 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> +++ h
> @@ -80,6 +80,11 @@ typedef struct {
>  ///
>  #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_AR
> M_PL011_UART            0x03
>
> +///
> +/// NVIDIA 16550 UART
> +///
> +#define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYPE_NV
> IDIA_16550_UART         0x05
> +
>  ///
>  /// ARM SBSA Generic UART (2.x) supporting 32-bit only accesses
[deprecated]
> ///
> --
> 2.17.1
>
>
>
> 
>

IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.




[-- Attachment #2: Type: text/html, Size: 14630 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-06-02  5:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-18 18:37 [PATCH 0/1] Add NVIDIA 16550 UART ACPI Subtype Ashish Singhal
2021-05-18 18:37 ` [PATCH 1/1] MdePkg: Update DBG2 and SPCR header with NVIDIA 16550 Subtype Ashish Singhal
2021-05-18 21:14   ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-05-20 20:32     ` Ashish Singhal
2021-05-21  5:20       ` 回复: " gaoliming
2021-05-21  6:08         ` Sunny Wang
     [not found]       ` <1680FD5B20378614.12041@groups.io>
2021-05-21  5:27         ` 回复: " gaoliming
     [not found]         ` <1680FDC38B67BCC1.12041@groups.io>
2021-06-02  5:56           ` gaoliming

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox