From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C8249740038 for ; Tue, 5 Mar 2024 00:34:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wpG6umhxvB55XzjW6nG1UBO0Qk3LX4jZCpRzzqz2cAM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1709598861; v=1; b=T9WZt29W9F+SKiNVtmDNTepAFlvu6y0YohjPJyGKI65IkIAVCp9tAeWsAfQrxGrKHZ98jL++ 589JrP40z+IZvSEtQ9TwcBJ6sNClgD1v6dWluDkwnFbcHIJ3KvZJsCDGeB9fIWxT9XO4wcpeAYp JlQmTyeqR9j3j3c8ZeNNUg2M= X-Received: by 127.0.0.2 with SMTP id LNTAYY7687511xjQzMvexKzd; Mon, 04 Mar 2024 16:34:21 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.10225.1709598860298576290 for ; Mon, 04 Mar 2024 16:34:20 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 2D8EFA32E107 for ; Tue, 5 Mar 2024 08:34:18 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 0ADBFA32E02E for ; Tue, 5 Mar 2024 08:34:18 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 47613A32E112 for ; Tue, 5 Mar 2024 08:34:15 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 05 Mar 2024 08:34:13 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Dat Mach'" , Cc: , , References: <3293642dead287a039922cdabda5dc706ad5ccc4.1708638360.git.dmach@nvidia.com> In-Reply-To: <3293642dead287a039922cdabda5dc706ad5ccc4.1708638360.git.dmach@nvidia.com> Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIXSBNZGVNb2R1bGVQa2cvWGhjaTogU2tpcCBhbm90aGVyIHNpemUgcm91bmQgdXAgZm9yIFRSQiBhZGRyZXNzIHRyYW5zbGF0aW9u?= Date: Tue, 5 Mar 2024 08:34:15 +0800 Message-ID: <004301da6e94$da4b8b10$8ee2a130$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKoO3aEvokyMh0o69gHHd7OIwr8Lq+Msn3g Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d9TbfJr73SdsRWp2DoxFvOmmx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=T9WZt29W; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This change looks good. Reviewed-by: Liming Gao Cheng and Hao: Have you any comments for this patch? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Dat Mach > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA2=D4=C226=C8=D5 10:00 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: gao.cheng@intel.com; hao.a.wu@intel.com; ray.ni@intel.com; > gaoliming@byosoft.com.cn; Dat Mach > =D6=F7=CC=E2: [PATCH] MdeModulePkg/Xhci: Skip another size round up for T= RB > address translation >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4560 >=20 > Commit f36e1ec1f0a5fd3be84913e09181d7813444b620 had fixed the > DXE_ASSERT > caused by the TRB size round up from 16 to 64 for most cases. >=20 > However, there is a remaining case that the TRB size is also rounded up > during setting TR dequeue pointer that would trigger DXE_ASSERT. >=20 > This patch sets the alignment flag to FALSE in XhcSetTrDequeuePointer > to fix this issue as well. >=20 > Signed-off-by: Dat Mach > --- > MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 2 +- > MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > index 05528a478b..5d735008ba 100644 > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c > @@ -3539,7 +3539,7 @@ XhcSetTrDequeuePointer ( > // Send stop endpoint command to transit Endpoint from running to stop > state > // > ZeroMem (&CmdSetTRDeq, sizeof (CmdSetTRDeq)); > - PhyAddr =3D UsbHcGetPciAddrForHostAddr (Xhc->MemPool, > Urb->Ring->RingEnqueue, sizeof (CMD_SET_TR_DEQ_POINTER), TRUE); > + PhyAddr =3D UsbHcGetPciAddrForHostAddr > (Xhc->MemPool, Urb->Ring->RingEnqueue, sizeof > (CMD_SET_TR_DEQ_POINTER), FALSE); > CmdSetTRDeq.PtrLo =3D XHC_LOW_32BIT (PhyAddr) | > Urb->Ring->RingPCS; > CmdSetTRDeq.PtrHi =3D XHC_HIGH_32BIT (PhyAddr); > CmdSetTRDeq.CycleBit =3D 1; > diff --git a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > index 53272f62dd..c956e45907 100644 > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c > @@ -2526,7 +2526,7 @@ XhcPeiSetTrDequeuePointer ( > // Send stop endpoint command to transit Endpoint from running to stop > state > // > ZeroMem (&CmdSetTRDeq, sizeof (CmdSetTRDeq)); > - PhyAddr =3D UsbHcGetPciAddrForHostAddr (Xhc->MemPool, > Urb->Ring->RingEnqueue, sizeof (CMD_SET_TR_DEQ_POINTER), TRUE); > + PhyAddr =3D UsbHcGetPciAddrForHostAddr > (Xhc->MemPool, Urb->Ring->RingEnqueue, sizeof > (CMD_SET_TR_DEQ_POINTER), FALSE); > CmdSetTRDeq.PtrLo =3D XHC_LOW_32BIT (PhyAddr) | > Urb->Ring->RingPCS; > CmdSetTRDeq.PtrHi =3D XHC_HIGH_32BIT (PhyAddr); > CmdSetTRDeq.CycleBit =3D 1; > -- > 2.44.0.rc2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116347): https://edk2.groups.io/g/devel/message/116347 Mute This Topic: https://groups.io/mt/104735560/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-