From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.4861.1605191365838199779
 for <devel@edk2.groups.io>;
 Thu, 12 Nov 2020 06:29:27 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([116.232.42.12])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <dandan.bi@intel.com>; Thu, 12 Nov 2020 22:29:18 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<gaoliming@byosoft.com.cn>,
	<gechao@greatwall.com.cn>
Cc: <dandan.bi@intel.com>,
	<eric.dong@intel.com>
References: <811d2cd2539810b03d21fba07736e1e9a902c916.1605144299.git.GevinGe@hotmail.com> <16469F0A5D9CED83.27022@groups.io>
In-Reply-To: <16469F0A5D9CED83.27022@groups.io>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0hdIE1kZU1vZHVsZVBrZyBEaXNwbGF5RW5naW5lRHhlOiBDb3JyZWN0IHRoZSBsb2NhbCB2YXJpYWJsZSBuYW1lLg==?=
Date: Thu, 12 Nov 2020 22:29:19 +0800
Message-ID: <004401d6b900$35242c70$9f6c8550$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQIelSGQWCK2PzrkxZ5a8kkREz6K7wFLIcMIqSp9CJA=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Create PR https://github.com/tianocore/edk2/pull/1120

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+67336+4905953+8761045@groups.io
> <bounce+27952+67336+4905953+8761045@groups.io> =B4=FA=B1=ED gaoliming
> =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C212=C8=D5 9:40
> =CA=D5=BC=FE=C8=CB: gechao@greatwall.com.cn; devel@edk2.groups.io
> =B3=AD=CB=CD: dandan.bi@intel.com; eric.dong@intel.com
> =D6=F7=CC=E2: [edk2-devel] =BB=D8=B8=B4: [PATCH] MdeModulePkg DisplayEng=
ineDxe: Correct
> the local variable name.
>=20
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>=20
> > -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> > =B7=A2=BC=FE=C8=CB: gechao@greatwall.com.cn <gechao@greatwall.com.cn>
> > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C212=C8=D5 9:34
> > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> > =B3=AD=CB=CD: dandan.bi@intel.com; eric.dong@intel.com;
> > gaoliming@byosoft.com.cn; gechao <gechao@greatwall.com.cn>
> > =D6=F7=CC=E2: [PATCH] MdeModulePkg DisplayEngineDxe: Correct the local=
 variable
> > name.
> >
> > From: gechao <gechao@greatwall.com.cn>
> >
> > Signed-off-by: gechao <gechao@greatwall.com.cn>
> > ---
> >  .../Universal/DisplayEngineDxe/FormDisplay.c     | 16 ++++++++-------=
-
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > index 3b034a1c82..a3898dc2ec 100644
> > --- a/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > +++ b/MdeModulePkg/Universal/DisplayEngineDxe/FormDisplay.c
> > @@ -372,7 +372,7 @@ GetWidth (
> >  {
> >
> >    CHAR16                        *String;
> >
> >    UINTN                         Size;
> >
> > -  EFI_IFR_TEXT                  *TestOp;
> >
> > +  EFI_IFR_TEXT                  *TextOp;
> >
> >    UINT16                        ReturnWidth;
> >
> >    FORM_DISPLAY_ENGINE_STATEMENT *Statement;
> >
> >
> >
> > @@ -394,9 +394,9 @@ GetWidth (
> >    // See if the second text parameter is really NULL
> >
> >    //
> >
> >    if (Statement->OpCode->OpCode =3D=3D EFI_IFR_TEXT_OP) {
> >
> > -    TestOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > -    if (TestOp->TextTwo !=3D 0) {
> >
> > -      String =3D GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> >
> > +    TextOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > +    if (TextOp->TextTwo !=3D 0) {
> >
> > +      String =3D GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> >
> >        Size   =3D StrLen (String);
> >
> >        FreePool (String);
> >
> >      }
> >
> > @@ -2166,7 +2166,7 @@ HasOptionString (
> >    FORM_DISPLAY_ENGINE_STATEMENT   *Statement;
> >
> >    CHAR16                          *String;
> >
> >    UINTN                           Size;
> >
> > -  EFI_IFR_TEXT                    *TestOp;
> >
> > +  EFI_IFR_TEXT                    *TextOp;
> >
> >
> >
> >    Size =3D 0;
> >
> >    Statement =3D MenuOption->ThisTag;
> >
> > @@ -2175,9 +2175,9 @@ HasOptionString (
> >    // See if the second text parameter is really NULL
> >
> >    //
> >
> >    if (Statement->OpCode->OpCode =3D=3D EFI_IFR_TEXT_OP) {
> >
> > -    TestOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > -    if (TestOp->TextTwo !=3D 0) {
> >
> > -      String =3D GetToken (TestOp->TextTwo, gFormData->HiiHandle);
> >
> > +    TextOp =3D (EFI_IFR_TEXT *) Statement->OpCode;
> >
> > +    if (TextOp->TextTwo !=3D 0) {
> >
> > +      String =3D GetToken (TextOp->TextTwo, gFormData->HiiHandle);
> >
> >        Size   =3D StrLen (String);
> >
> >        FreePool (String);
> >
> >      }
> >
> > --
> > 2.28.0.windows.1
>=20
>=20
>=20
>=20
>=20
>=20
>=20