回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

["gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>]

Oliver:
  If there is no enough space, Variable driver will reclaim flash and
reserve the enough space at boot time. 

  At the runtime, reclaim will not be trigged. The space may be out of
resource. The warning message may be reported. Is this your case?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Oliver Steffen
> 发送时间: 2024年3月4日 23:18
> 收件人: devel@edk2.groups.io
> 抄送: Oliver Steffen <osteffen@redhat.com>; Bob Feng
> <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Rebecca
> Cran <rebecca@bsdio.com>; Yuwei Chen <yuwei.chen@intel.com>; Gerd
> Hoffmann <kraxel@redhat.com>; Laszlo Ersek <lersek@redhat.com>
> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space
> when writing variables
> 
> Emit a DEBUG_WARN message if there is not enough flash space left to
> write/update a variable. This condition is currently not logged
> appropriately in all cases, given that full variable store can easily
> render the system unbootable.
> This new message helps identifying this condition.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>  MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> index d394d237a53f..1c7659031dc5 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> @@ -2364,6 +2364,8 @@ UpdateVariable (
>                    );
> 
>        ASSERT_EFI_ERROR (Status);
> 
>      }
> 
> +  } else if (Status == EFI_OUT_OF_RESOURCES) {
> 
> +    DEBUG ((DEBUG_WARN, "UpdateVariable failed: Out of flash
> space\n"));
> 
>    }
> 
> 
> 
>    return Status;
> 
> --
> 2.44.0
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116348): https://edk2.groups.io/g/devel/message/116348
Mute This Topic: https://groups.io/mt/104735640/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-