From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 997ED78003C for ; Tue, 5 Mar 2024 00:40:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rHLPkYWfQ+I2WyA3HNL3K0RuNbPIGGtvAIQaIKq60nI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1709599219; v=1; b=audfOhH1N0BuTJeHCNWPGZc08V9Hq3iW48lvBXIGFAYdipJGOnAiPTNWiYCA3lSjUEhRMEQz qkBV53TkfxdQZgygQ6ldCCXMHkLZvu+WYXDMh+/T2Ei9ze6v1sjah96/g46W8szJWt8csbEO891 H/sQgawZGUJ/95o/N/sfkOik= X-Received: by 127.0.0.2 with SMTP id gGa2YY7687511xd6MJiecGWV; Mon, 04 Mar 2024 16:40:19 -0800 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.10353.1709599218119940714 for ; Mon, 04 Mar 2024 16:40:18 -0800 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 384D2DDA7DB for ; Tue, 5 Mar 2024 08:40:16 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 33F93DDA7D6 for ; Tue, 5 Mar 2024 08:40:16 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 8FA19DDA7D7 for ; Tue, 5 Mar 2024 08:40:12 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 05 Mar 2024 08:40:05 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Bob Feng'" , "'Rebecca Cran'" , "'Yuwei Chen'" , "'Gerd Hoffmann'" , "'Laszlo Ersek'" References: <20240304151805.129004-1-osteffen@redhat.com> <20240304151805.129004-2-osteffen@redhat.com> In-Reply-To: <20240304151805.129004-2-osteffen@redhat.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gTWRlTW9kdWxlUGtnOiBXYXJuIGlmIG91dCBvZiBmbGFzaCBzcGFjZSB3aGVuIHdyaXRpbmcgdmFyaWFibGVz?= Date: Tue, 5 Mar 2024 08:40:07 +0800 Message-ID: <004401da6e95$ac5d9e90$0518dbb0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIjQtbNwG/JyF3pkMVFwQe51+0FGQKeeAtqsIGxHHA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: elESvO0YzFvvcDxZvFHD1ebex7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=audfOhH1; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Oliver: If there is no enough space, Variable driver will reclaim flash and reserve the enough space at boot time.=20 At the runtime, reclaim will not be trigged. The space may be out of resource. The warning message may be reported. Is this your case? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Oliver Steffen > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA3=D4=C24=C8=D5 23:18 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Oliver Steffen ; Bob Feng > ; Liming Gao ; Rebecca > Cran ; Yuwei Chen ; Gerd > Hoffmann ; Laszlo Ersek > =D6=F7=CC=E2: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of fl= ash space > when writing variables >=20 > Emit a DEBUG_WARN message if there is not enough flash space left to > write/update a variable. This condition is currently not logged > appropriately in all cases, given that full variable store can easily > render the system unbootable. > This new message helps identifying this condition. >=20 > Cc: Bob Feng > Cc: Gerd Hoffmann > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Rebecca Cran > Cc: Yuwei Chen >=20 > Signed-off-by: Oliver Steffen > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > index d394d237a53f..1c7659031dc5 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -2364,6 +2364,8 @@ UpdateVariable ( > ); >=20 > ASSERT_EFI_ERROR (Status); >=20 > } >=20 > + } else if (Status =3D=3D EFI_OUT_OF_RESOURCES) { >=20 > + DEBUG ((DEBUG_WARN, "UpdateVariable failed: Out of flash > space\n")); >=20 > } >=20 >=20 >=20 > return Status; >=20 > -- > 2.44.0 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116348): https://edk2.groups.io/g/devel/message/116348 Mute This Topic: https://groups.io/mt/104735640/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-