* Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
[not found] <163932D00054AC83.17908@groups.io>
@ 2020-09-29 8:12 ` Zhiguang Liu
2020-09-30 0:44 ` 回复: " gaoliming
0 siblings, 1 reply; 7+ messages in thread
From: Zhiguang Liu @ 2020-09-29 8:12 UTC (permalink / raw)
To: devel@edk2.groups.io, Liu, Zhiguang
Cc: Wang, Sanyo, Kinney, Michael D, Liming Gao
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhiguang
> Liu
> Sent: Tuesday, September 29, 2020 4:09 PM
> To: devel@edk2.groups.io
> Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> definitions".
>
> From: "Wang, Sanyo" <sanyo.wang@intel.com>
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
>
> SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> ---
> MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> b/MdePkg/Include/IndustryStandard/SmBios.h
> index ea23685851..f2db11f947 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1718,7 +1718,9 @@ typedef enum {
> MemoryTypeLpddr4 = 0x1E,
>
> MemoryTypeLogicalNonVolatileDevice = 0x1F,
>
> MemoryTypeHBM = 0x20,
>
> - MemoryTypeHBM2 = 0x21
>
> + MemoryTypeHBM2 = 0x21,
>
> + MemoryTypeDdr5 = 0x22,
>
> + MemoryTypeLpddr5 = 0x23
>
> } MEMORY_DEVICE_TYPE;
>
>
>
> ///
>
> --
> 2.25.1.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#65711): https://edk2.groups.io/g/devel/message/65711
> Mute This Topic: https://groups.io/mt/77191807/1779286
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [zhiguang.liu@intel.com]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
2020-09-29 8:12 ` [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions" Zhiguang Liu
@ 2020-09-30 0:44 ` gaoliming
2020-10-09 7:24 ` Zhiguang Liu
0 siblings, 1 reply; 7+ messages in thread
From: gaoliming @ 2020-09-30 0:44 UTC (permalink / raw)
To: devel, zhiguang.liu; +Cc: 'Wang, Sanyo', 'Kinney, Michael D'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: bounce+27952+65712+4905953+8761045@groups.io
> <bounce+27952+65712+4905953+8761045@groups.io> 代表 Zhiguang Liu
> 发送时间: 2020年9月29日 16:12
> 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> definitions".
>
>
> Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Zhiguang
> > Liu
> > Sent: Tuesday, September 29, 2020 4:09 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> > definitions".
> >
> > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> >
> > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > ---
> > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > b/MdePkg/Include/IndustryStandard/SmBios.h
> > index ea23685851..f2db11f947 100644
> > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > @@ -1718,7 +1718,9 @@ typedef enum {
> > MemoryTypeLpddr4 = 0x1E,
> >
> > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> >
> > MemoryTypeHBM = 0x20,
> >
> > - MemoryTypeHBM2 = 0x21
> >
> > + MemoryTypeHBM2 = 0x21,
> >
> > + MemoryTypeDdr5 = 0x22,
> >
> > + MemoryTypeLpddr5 = 0x23
> >
> > } MEMORY_DEVICE_TYPE;
> >
> >
> >
> > ///
> >
> > --
> > 2.25.1.windows.1
> >
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#65711):
> https://edk2.groups.io/g/devel/message/65711
> > Mute This Topic: https://groups.io/mt/77191807/1779286
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [zhiguang.liu@intel.com]
> > -=-=-=-=-=-=
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
2020-09-30 0:44 ` 回复: " gaoliming
@ 2020-10-09 7:24 ` Zhiguang Liu
2020-10-09 9:21 ` 回复: " gaoliming
0 siblings, 1 reply; 7+ messages in thread
From: Zhiguang Liu @ 2020-10-09 7:24 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn
Cc: Wang, Sanyo, Kinney, Michael D, Gao, Zhichao, Sean Brogan
Hi Liming,
This patch also gets R-B from Sean Brogan.
Please help merge this patch.
Thanks
Zhiguang
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Wednesday, September 30, 2020 8:45 AM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5 definitions".
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: bounce+27952+65712+4905953+8761045@groups.io
> > <bounce+27952+65712+4905953+8761045@groups.io> 代表 Zhiguang Liu
> > 发送时间: 2020年9月29日 16:12
> > 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> > definitions".
> >
> >
> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Zhiguang
> > > Liu
> > > Sent: Tuesday, September 29, 2020 4:09 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> > > DDR5 definitions".
> > >
> > > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> > >
> > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> > >
> > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > > ---
> > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > index ea23685851..f2db11f947 100644
> > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > @@ -1718,7 +1718,9 @@ typedef enum {
> > > MemoryTypeLpddr4 = 0x1E,
> > >
> > > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> > >
> > > MemoryTypeHBM = 0x20,
> > >
> > > - MemoryTypeHBM2 = 0x21
> > >
> > > + MemoryTypeHBM2 = 0x21,
> > >
> > > + MemoryTypeDdr5 = 0x22,
> > >
> > > + MemoryTypeLpddr5 = 0x23
> > >
> > > } MEMORY_DEVICE_TYPE;
> > >
> > >
> > >
> > > ///
> > >
> > > --
> > > 2.25.1.windows.1
> > >
> > >
> > >
> > > -=-=-=-=-=-=
> > > Groups.io Links: You receive all messages sent to this group.
> > > View/Reply Online (#65711):
> > https://edk2.groups.io/g/devel/message/65711
> > > Mute This Topic: https://groups.io/mt/77191807/1779286
> > > Group Owner: devel+owner@edk2.groups.io
> > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > [zhiguang.liu@intel.com]
> > > -=-=-=-=-=-=
> > >
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
2020-10-09 7:24 ` Zhiguang Liu
@ 2020-10-09 9:21 ` gaoliming
2020-10-10 0:49 ` Zhiguang Liu
0 siblings, 1 reply; 7+ messages in thread
From: gaoliming @ 2020-10-09 9:21 UTC (permalink / raw)
To: devel, zhiguang.liu
Cc: 'Wang, Sanyo', 'Kinney, Michael D',
'Gao, Zhichao', 'Sean Brogan'
https://github.com/tianocore/edk2/pull/996 is created.
> -----邮件原件-----
> 发件人: bounce+27952+66054+4905953+8761045@groups.io
> <bounce+27952+66054+4905953+8761045@groups.io> 代表 Zhiguang Liu
> 发送时间: 2020年10月9日 15:24
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Sean
> Brogan <spbrogan@outlook.com>
> 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> definitions".
>
> Hi Liming,
> This patch also gets R-B from Sean Brogan.
> Please help merge this patch.
>
> Thanks
> Zhiguang
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> gaoliming
> > Sent: Wednesday, September 30, 2020 8:45 AM
> > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> "adding
> > DDR5 definitions".
> >
> > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+65712+4905953+8761045@groups.io
> > > <bounce+27952+65712+4905953+8761045@groups.io> 代表 Zhiguang
> Liu
> > > 发送时间: 2020年9月29日 16:12
> > > 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5
> > > definitions".
> > >
> > >
> > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Zhiguang
> > > > Liu
> > > > Sent: Tuesday, September 29, 2020 4:09 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>
> > > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> > > > DDR5 definitions".
> > > >
> > > > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> > > >
> > > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> > > >
> > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > > > ---
> > > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > index ea23685851..f2db11f947 100644
> > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > @@ -1718,7 +1718,9 @@ typedef enum {
> > > > MemoryTypeLpddr4 = 0x1E,
> > > >
> > > > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> > > >
> > > > MemoryTypeHBM = 0x20,
> > > >
> > > > - MemoryTypeHBM2 = 0x21
> > > >
> > > > + MemoryTypeHBM2 = 0x21,
> > > >
> > > > + MemoryTypeDdr5 = 0x22,
> > > >
> > > > + MemoryTypeLpddr5 = 0x23
> > > >
> > > > } MEMORY_DEVICE_TYPE;
> > > >
> > > >
> > > >
> > > > ///
> > > >
> > > > --
> > > > 2.25.1.windows.1
> > > >
> > > >
> > > >
> > > > -=-=-=-=-=-=
> > > > Groups.io Links: You receive all messages sent to this group.
> > > > View/Reply Online (#65711):
> > > https://edk2.groups.io/g/devel/message/65711
> > > > Mute This Topic: https://groups.io/mt/77191807/1779286
> > > > Group Owner: devel+owner@edk2.groups.io
> > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > [zhiguang.liu@intel.com]
> > > > -=-=-=-=-=-=
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> >
> >
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
2020-10-09 9:21 ` 回复: " gaoliming
@ 2020-10-10 0:49 ` Zhiguang Liu
2020-10-10 2:33 ` 回复: " gaoliming
[not found] ` <163C80D0DA0D37E4.10193@groups.io>
0 siblings, 2 replies; 7+ messages in thread
From: Zhiguang Liu @ 2020-10-10 0:49 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: Wang, Sanyo, Kinney, Michael D, Gao, Zhichao,
'Sean Brogan'
Hi Liming
In pull request https://github.com/tianocore/edk2/pull/996
Merge failed because
tanocore.PatchCheck Failing after 34s — Build #20201009.4 failed
Detail:
The commit message format is not valid:
* Missing Signed-off-by! (Note: this must be added by the code contributor!)
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
However, I abstract the patch from Outlook and run PatchCheck to check it in my local machine, the result is ok.
Detail:
E:\edk2\BaseTools\Scripts>py PatchCheck.py 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
Checking patch file: 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
[PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
The commit message format passed all checks.
The code passed all checks.
Do you know why?
Thanks
Zhiguang
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Friday, October 9, 2020 5:21 PM
> To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; 'Sean
> Brogan' <spbrogan@outlook.com>
> Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5 definitions".
>
> https://github.com/tianocore/edk2/pull/996 is created.
>
> > -----邮件原件-----
> > 发件人: bounce+27952+66054+4905953+8761045@groups.io
> > <bounce+27952+66054+4905953+8761045@groups.io> 代表 Zhiguang Liu
> > 发送时间: 2020年10月9日 15:24
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > Sean Brogan <spbrogan@outlook.com>
> > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> > definitions".
> >
> > Hi Liming,
> > This patch also gets R-B from Sean Brogan.
> > Please help merge this patch.
> >
> > Thanks
> > Zhiguang
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > gaoliming
> > > Sent: Wednesday, September 30, 2020 8:45 AM
> > > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > "adding
> > > DDR5 definitions".
> > >
> > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > >
> > > > -----邮件原件-----
> > > > 发件人: bounce+27952+65712+4905953+8761045@groups.io
> > > > <bounce+27952+65712+4905953+8761045@groups.io> 代表 Zhiguang
> > Liu
> > > > 发送时间: 2020年9月29日 16:12
> > > > 收件人: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>
> > > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> > DDR5
> > > > definitions".
> > > >
> > > >
> > > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Zhiguang
> > > > > Liu
> > > > > Sent: Tuesday, September 29, 2020 4:09 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>
> > > > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > > > > "adding
> > > > > DDR5 definitions".
> > > > >
> > > > > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> > > > >
> > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> > > > >
> > > > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> > > > >
> > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > > > > ---
> > > > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > index ea23685851..f2db11f947 100644
> > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > @@ -1718,7 +1718,9 @@ typedef enum {
> > > > > MemoryTypeLpddr4 = 0x1E,
> > > > >
> > > > > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> > > > >
> > > > > MemoryTypeHBM = 0x20,
> > > > >
> > > > > - MemoryTypeHBM2 = 0x21
> > > > >
> > > > > + MemoryTypeHBM2 = 0x21,
> > > > >
> > > > > + MemoryTypeDdr5 = 0x22,
> > > > >
> > > > > + MemoryTypeLpddr5 = 0x23
> > > > >
> > > > > } MEMORY_DEVICE_TYPE;
> > > > >
> > > > >
> > > > >
> > > > > ///
> > > > >
> > > > > --
> > > > > 2.25.1.windows.1
> > > > >
> > > > >
> > > > >
> > > > > -=-=-=-=-=-=
> > > > > Groups.io Links: You receive all messages sent to this group.
> > > > > View/Reply Online (#65711):
> > > > https://edk2.groups.io/g/devel/message/65711
> > > > > Mute This Topic: https://groups.io/mt/77191807/1779286
> > > > > Group Owner: devel+owner@edk2.groups.io
> > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > > [zhiguang.liu@intel.com]
> > > > > -=-=-=-=-=-=
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
2020-10-10 0:49 ` Zhiguang Liu
@ 2020-10-10 2:33 ` gaoliming
[not found] ` <163C80D0DA0D37E4.10193@groups.io>
1 sibling, 0 replies; 7+ messages in thread
From: gaoliming @ 2020-10-10 2:33 UTC (permalink / raw)
To: 'Liu, Zhiguang', devel
Cc: 'Wang, Sanyo', 'Kinney, Michael D',
'Gao, Zhichao', 'Sean Brogan'
The pull request needs rebase. I will submit new pull request today.
Thanks
Liming
> -----邮件原件-----
> 发件人: Liu, Zhiguang <zhiguang.liu@intel.com>
> 发送时间: 2020年10月10日 8:49
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> 'Sean Brogan' <spbrogan@outlook.com>
> 主题: RE: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5
> definitions".
>
> Hi Liming
>
> In pull request https://github.com/tianocore/edk2/pull/996
> Merge failed because
> tanocore.PatchCheck Failing after 34s — Build #20201009.4 failed
>
> Detail:
> The commit message format is not valid:
> * Missing Signed-off-by! (Note: this must be added by the code contributor!)
> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For
> mat
>
> However, I abstract the patch from Outlook and run PatchCheck to check it in
> my local machine, the result is ok.
>
> Detail:
> E:\edk2\BaseTools\Scripts>py PatchCheck.py
> 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
> Checking patch file:
> 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
> [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
> The commit message format passed all checks.
> The code passed all checks.
>
> Do you know why?
>
> Thanks
> Zhiguang
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Friday, October 9, 2020 5:21 PM
> > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> 'Sean
> > Brogan' <spbrogan@outlook.com>
> > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> "adding
> > DDR5 definitions".
> >
> > https://github.com/tianocore/edk2/pull/996 is created.
> >
> > > -----邮件原件-----
> > > 发件人: bounce+27952+66054+4905953+8761045@groups.io
> > > <bounce+27952+66054+4905953+8761045@groups.io> 代表 Zhiguang
> Liu
> > > 发送时间: 2020年10月9日 15:24
> > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > > Sean Brogan <spbrogan@outlook.com>
> > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5
> > > definitions".
> > >
> > > Hi Liming,
> > > This patch also gets R-B from Sean Brogan.
> > > Please help merge this patch.
> > >
> > > Thanks
> > > Zhiguang
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > gaoliming
> > > > Sent: Wednesday, September 30, 2020 8:45 AM
> > > > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>
> > > > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > > "adding
> > > > DDR5 definitions".
> > > >
> > > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > > >
> > > > > -----邮件原件-----
> > > > > 发件人: bounce+27952+65712+4905953+8761045@groups.io
> > > > > <bounce+27952+65712+4905953+8761045@groups.io> 代表
> Zhiguang
> > > Liu
> > > > > 发送时间: 2020年9月29日 16:12
> > > > > 收件人: devel@edk2.groups.io; Liu, Zhiguang
> <zhiguang.liu@intel.com>
> > > > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > > <gaoliming@byosoft.com.cn>
> > > > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> "adding
> > > DDR5
> > > > > definitions".
> > > > >
> > > > >
> > > > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Zhiguang
> > > > > > Liu
> > > > > > Sent: Tuesday, September 29, 2020 4:09 PM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > > <michael.d.kinney@intel.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>
> > > > > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > > > > > "adding
> > > > > > DDR5 definitions".
> > > > > >
> > > > > > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> > > > > >
> > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> > > > > >
> > > > > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> > > > > >
> > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > > > > > ---
> > > > > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > index ea23685851..f2db11f947 100644
> > > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > @@ -1718,7 +1718,9 @@ typedef enum {
> > > > > > MemoryTypeLpddr4 = 0x1E,
> > > > > >
> > > > > > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> > > > > >
> > > > > > MemoryTypeHBM = 0x20,
> > > > > >
> > > > > > - MemoryTypeHBM2 = 0x21
> > > > > >
> > > > > > + MemoryTypeHBM2 = 0x21,
> > > > > >
> > > > > > + MemoryTypeDdr5 = 0x22,
> > > > > >
> > > > > > + MemoryTypeLpddr5 = 0x23
> > > > > >
> > > > > > } MEMORY_DEVICE_TYPE;
> > > > > >
> > > > > >
> > > > > >
> > > > > > ///
> > > > > >
> > > > > > --
> > > > > > 2.25.1.windows.1
> > > > > >
> > > > > >
> > > > > >
> > > > > > -=-=-=-=-=-=
> > > > > > Groups.io Links: You receive all messages sent to this group.
> > > > > > View/Reply Online (#65711):
> > > > > https://edk2.groups.io/g/devel/message/65711
> > > > > > Mute This Topic: https://groups.io/mt/77191807/1779286
> > > > > > Group Owner: devel+owner@edk2.groups.io
> > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > > > [zhiguang.liu@intel.com]
> > > > > > -=-=-=-=-=-=
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
[not found] ` <163C80D0DA0D37E4.10193@groups.io>
@ 2020-10-10 3:30 ` gaoliming
0 siblings, 0 replies; 7+ messages in thread
From: gaoliming @ 2020-10-10 3:30 UTC (permalink / raw)
To: devel, gaoliming, 'Liu, Zhiguang'
Cc: 'Wang, Sanyo', 'Kinney, Michael D',
'Gao, Zhichao', 'Sean Brogan'
New PR https://github.com/tianocore/edk2/pull/998 has been merged.
> -----邮件原件-----
> 发件人: bounce+27952+66090+4905953+8761045@groups.io
> <bounce+27952+66090+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年10月10日 10:33
> 收件人: 'Liu, Zhiguang' <zhiguang.liu@intel.com>; devel@edk2.groups.io
> 抄送: 'Wang, Sanyo' <sanyo.wang@intel.com>; 'Kinney, Michael D'
> <michael.d.kinney@intel.com>; 'Gao, Zhichao' <zhichao.gao@intel.com>;
> 'Sean Brogan' <spbrogan@outlook.com>
> 主题: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5 definitions".
>
> The pull request needs rebase. I will submit new pull request today.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Liu, Zhiguang <zhiguang.liu@intel.com>
> > 发送时间: 2020年10月10日 8:49
> > 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > 'Sean Brogan' <spbrogan@outlook.com>
> > 主题: RE: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> DDR5
> > definitions".
> >
> > Hi Liming
> >
> > In pull request https://github.com/tianocore/edk2/pull/996
> > Merge failed because
> > tanocore.PatchCheck Failing after 34s — Build #20201009.4 failed
> >
> > Detail:
> > The commit message format is not valid:
> > * Missing Signed-off-by! (Note: this must be added by the code
> contributor!)
> >
> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-For
> > mat
> >
> > However, I abstract the patch from Outlook and run PatchCheck to check it
> in
> > my local machine, the result is ok.
> >
> > Detail:
> > E:\edk2\BaseTools\Scripts>py PatchCheck.py
> > 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
> > Checking patch file:
> > 0001-MdePkg-SMBIOS-3.4.0-Update-adding-DDR5-definitions-.patch
> > [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions".
> > The commit message format passed all checks.
> > The code passed all checks.
> >
> > Do you know why?
> >
> > Thanks
> > Zhiguang
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Friday, October 9, 2020 5:21 PM
> > > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > 'Sean
> > > Brogan' <spbrogan@outlook.com>
> > > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > "adding
> > > DDR5 definitions".
> > >
> > > https://github.com/tianocore/edk2/pull/996 is created.
> > >
> > > > -----邮件原件-----
> > > > 发件人: bounce+27952+66054+4905953+8761045@groups.io
> > > > <bounce+27952+66054+4905953+8761045@groups.io> 代表
> Zhiguang
> > Liu
> > > > 发送时间: 2020年10月9日 15:24
> > > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> > > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > <michael.d.kinney@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> > > > Sean Brogan <spbrogan@outlook.com>
> > > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding
> > DDR5
> > > > definitions".
> > > >
> > > > Hi Liming,
> > > > This patch also gets R-B from Sean Brogan.
> > > > Please help merge this patch.
> > > >
> > > > Thanks
> > > > Zhiguang
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > gaoliming
> > > > > Sent: Wednesday, September 30, 2020 8:45 AM
> > > > > To: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>
> > > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > <michael.d.kinney@intel.com>
> > > > > Subject: 回复: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > > > "adding
> > > > > DDR5 definitions".
> > > > >
> > > > > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> > > > >
> > > > > > -----邮件原件-----
> > > > > > 发件人: bounce+27952+65712+4905953+8761045@groups.io
> > > > > > <bounce+27952+65712+4905953+8761045@groups.io> 代表
> > Zhiguang
> > > > Liu
> > > > > > 发送时间: 2020年9月29日 16:12
> > > > > > 收件人: devel@edk2.groups.io; Liu, Zhiguang
> > <zhiguang.liu@intel.com>
> > > > > > 抄送: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > > > <gaoliming@byosoft.com.cn>
> > > > > > 主题: Re: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > "adding
> > > > DDR5
> > > > > > definitions".
> > > > > >
> > > > > >
> > > > > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf
> Of
> > > > > > Zhiguang
> > > > > > > Liu
> > > > > > > Sent: Tuesday, September 29, 2020 4:09 PM
> > > > > > > To: devel@edk2.groups.io
> > > > > > > Cc: Wang, Sanyo <sanyo.wang@intel.com>; Kinney, Michael D
> > > > > > > <michael.d.kinney@intel.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>
> > > > > > > Subject: [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update
> > > > > > > "adding
> > > > > > > DDR5 definitions".
> > > > > > >
> > > > > > > From: "Wang, Sanyo" <sanyo.wang@intel.com>
> > > > > > >
> > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2352
> > > > > > >
> > > > > > > SMBIOS 3.4 spec adds new memory device types (DDR5, LPDDR5)
> > > > > > >
> > > > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > > > > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > > > > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > > > > > > Signed-off-by: Sanyo Wang <sanyo.wang@intel.com>
> > > > > > > ---
> > > > > > > MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
> > > > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > > > >
> > > > > > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > > b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > > index ea23685851..f2db11f947 100644
> > > > > > > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > > > > > > @@ -1718,7 +1718,9 @@ typedef enum {
> > > > > > > MemoryTypeLpddr4 = 0x1E,
> > > > > > >
> > > > > > > MemoryTypeLogicalNonVolatileDevice = 0x1F,
> > > > > > >
> > > > > > > MemoryTypeHBM = 0x20,
> > > > > > >
> > > > > > > - MemoryTypeHBM2 = 0x21
> > > > > > >
> > > > > > > + MemoryTypeHBM2 = 0x21,
> > > > > > >
> > > > > > > + MemoryTypeDdr5 = 0x22,
> > > > > > >
> > > > > > > + MemoryTypeLpddr5 = 0x23
> > > > > > >
> > > > > > > } MEMORY_DEVICE_TYPE;
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ///
> > > > > > >
> > > > > > > --
> > > > > > > 2.25.1.windows.1
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > -=-=-=-=-=-=
> > > > > > > Groups.io Links: You receive all messages sent to this group.
> > > > > > > View/Reply Online (#65711):
> > > > > > https://edk2.groups.io/g/devel/message/65711
> > > > > > > Mute This Topic: https://groups.io/mt/77191807/1779286
> > > > > > > Group Owner: devel+owner@edk2.groups.io
> > > > > > > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> > > > > > [zhiguang.liu@intel.com]
> > > > > > > -=-=-=-=-=-=
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-10-10 3:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <163932D00054AC83.17908@groups.io>
2020-09-29 8:12 ` [edk2-devel] [PATCH] MdePkg: SMBIOS 3.4.0 Update "adding DDR5 definitions" Zhiguang Liu
2020-09-30 0:44 ` 回复: " gaoliming
2020-10-09 7:24 ` Zhiguang Liu
2020-10-09 9:21 ` 回复: " gaoliming
2020-10-10 0:49 ` Zhiguang Liu
2020-10-10 2:33 ` 回复: " gaoliming
[not found] ` <163C80D0DA0D37E4.10193@groups.io>
2020-10-10 3:30 ` gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox