Yes. Maintainer has the both role of reviewer and patch merge. 

 

Thanks

Liming

 

发件人: bounce+27952+65723+4905953+8761045@groups.io
<bounce+27952+65723+4905953+8761045@groups.io> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.
com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
<michael.d.kinney@intel.com>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to
RedfishPkg

 

Without R, I still can give reviewed-by to others contribute to RedfishPkg
right?

 

Get Outlook for Android <https://aka.ms/ghei36> 

 

  _____

From: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg





On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >
> Cc: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> Cc: Andrew Fish <afish@apple.com <mailto:afish@apple.com> >
> Cc: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
> Cc: Leif Lindholm <leif@nuviainc.com <mailto:leif@nuviainc.com> >
> Cc: Michael D Kinney <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> >
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >
> +R: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>