From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.9113.1604467174666584361 for ; Tue, 03 Nov 2020 21:19:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 04 Nov 2020 13:19:31 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Jiaxin Wu'" , "'Siyuan Fu'" , "'Fan Wang'" , "'Jiewen Yao'" , "'Dandan Bi'" , "'Eric Dong'" , "'Nickle Wang'" References: <20201103024100.7733-1-abner.chang@hpe.com> <20201103024100.7733-4-abner.chang@hpe.com> In-Reply-To: <20201103024100.7733-4-abner.chang@hpe.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1ZGUiBzdXBwb3J0IFJFU1RfU1RZTEUgUEFUQ0ggdjIgMy8zXSBNZGVNb2R1bGVQa2cvRHJpdmVyU2FtcGxlRHhlOiBBZGQgSElJIHNhbXBsZSBvcHRpb25z?= Date: Wed, 4 Nov 2020 13:19:31 +0800 Message-ID: <004701d6b26a$13b11c20$3b135460$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLMezy9co9qx/jLeyRE1n7i5wJI/AJU+PzEp7k1dGA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Abner: I can't apply this patch in edk2. Have you try it? Besides, this patch set supports rest option generation. Is SetupBrowser= required to handle it? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+66902+4905953+8761045@groups.i= o > =E4=BB=A3=E8=A1=A8 Abner = Chang > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=883=E6=97=A5= 10:41 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Jiaxin Wu ; Siyuan Fu ; Fan > Wang ; Jiewen Yao ; Dandan > Bi ; Eric Dong ; Nickle Wang > > =E4=B8=BB=E9=A2=98: [edk2-devel] [VFR support REST_STYLE PATCH v2 3/3] > MdeModulePkg/DriverSampleDxe: Add HII sample options >=20 > Add x-uefi-ns keyword REST_STYLE HII option and non > x-uefi keyword REST_STYLE HII option. >=20 > Signed-off-by: Abner Chang > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Fan Wang > Cc: Jiewen Yao > Cc: Dandan Bi > Cc: Eric Dong > Cc: Nickle Wang > --- > .../Universal/DriverSampleDxe/NVDataStruc.h | 4 ++- > .../Universal/DriverSampleDxe/Vfr.vfr | 32 +++++++++++++++++-- > .../Universal/DriverSampleDxe/VfrStrings.uni | 11 +++++-- > 3 files changed, 40 insertions(+), 7 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > index 8617617684..761f5e169c 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > +++ b/MdeModulePkg/Universal/DriverSampleDxe/NVDataStruc.h > @@ -1,6 +1,7 @@ > /** @file >=20 > -Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
* > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > Module Name: > @@ -92,6 +93,7 @@ typedef struct { > UINT16 BitNumeric : 12; > MY_BITS_DATA MyBitData; > MY_EFI_UNION_DATA MyUnionData; > + UINT8 QuestionNonXUefiKeywordRestStyle; > } DRIVER_SAMPLE_CONFIGURATION; >=20 > // > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > index 65a65d4d1d..eecb062320 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > +++ b/MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr > @@ -3,6 +3,7 @@ > // Sample Setup formset. > // > // Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<= BR> > +// (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent > // > //**/ > @@ -280,15 +281,40 @@ formset >=20 > endoneof; >=20 > + // > + // This is an HII option which has REST_STYLE flag and x-UEFI > namespace > + // UNI string associated. This HII option could be configured by ei= ther > in-band > + // edk2 setup browser or the remote management in out-of-band such > as Redfish > + // service. This HII option is configured through > EFI_KEYWORD_HANDLER_PROTOCOL. > + // > oneof varid =3D MyIfrNVData.QuestionAboutTreeHugging, > - prompt =3D > STRING_TOKEN(STR_ONE_OF_PROMPT_KEYWORD), > - help =3D STRING_TOKEN(STR_ONE_OF_HELP), > - flags =3D RESET_REQUIRED, > + prompt =3D STRING_TOKEN(STR_ONE_OF_PROMPT_X_UEFI), > + help =3D > STRING_TOKEN(STR_ONE_OF_PROMPT_X_UEFI_HELP), > + flags =3D RESET_REQUIRED | REST_STYLE, > option text =3D STRING_TOKEN(STR_ONE_OF_TEXT1), value =3D 0, flag= s > =3D 0; > option text =3D STRING_TOKEN(STR_ONE_OF_TEXT2), value =3D 1, flag= s > =3D DEFAULT; > option text =3D STRING_TOKEN(STR_ONE_OF_TEXT3), value =3D 3, flag= s > =3D 0; > endoneof; >=20 > + // > + // This is a HII option which has REST_STYLE flag but without the x= -UEFI > namespace > + // UNI string associated. This HII option could be configured by ei= ther > + // setup browser or the remote management in out-of-band such as > Redfish > + // service. This HII option is configured through EFI HII Configura= tion > Routing > + // Protocol becasue it doesn't have x-UEFI namespace UNI string. > + // > + numeric varid =3D MyIfrNVData.QuestionNonXUefiKeywordRestStyle, > + prompt =3D > STRING_TOKEN(STR_ONE_OF_PROMPT_NON_X_UEFI), > + help =3D > STRING_TOKEN(STR_ONE_OF_PROMPT_NON_X_UEFI_HELP), > + flags =3D RESET_REQUIRED | REST_STYLE, > + minimum =3D 0, > + maximum =3D 0xf0, > + step =3D 0, // Stepping of 0 equates to a manual > entering > + // of a value, otherwise it will be > adjusted by "+"/"-" > + default =3D 0, // defaultstore could be used to > specify the default type > + // If no defaultstore is specified, it > implies Standard Default > + endnumeric; > + > // > // Define a string (EFI_IFR_STRING) > // > diff --git a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > index bafa194c63..e67b888783 100644 > --- a/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > +++ b/MdeModulePkg/Universal/DriverSampleDxe/VfrStrings.uni > @@ -1,6 +1,7 @@ > // *++ > // > // Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP
> // SPDX-License-Identifier: BSD-2-Clause-Patent > // > // Module Name: > @@ -51,9 +52,13 @@ > #language fr-FR "Check the > input number, test the efi buffer varstore" > #string STR_ONE_OF_PROMPT #language en-US "My > one-of prompt #1" > #language fr-FR "Mi uno- > de gu=C3=ADa # 1" > -#string STR_ONE_OF_PROMPT_KEYWORD #language en-US "My > Keyword Namespace Test" > - #language fr-FR "My > Keyword Namespace Test" > - #language x-UEFI-ns > "iSCSIBootEnable" > +#string STR_ONE_OF_PROMPT_X_UEFI #language en-US "x-UEFI > HII Option" > + #language fr-FR "x-UEFI HII > Option" > + #language x-UEFI-ns > "xUefiHiiOption" > +#string STR_ONE_OF_PROMPT_X_UEFI_HELP #language en-US "This is an > HII option which has REST_STYLE flag and x-UEFI namespace UNI string > associated. This HII option could be configured by either in-band edk2 s= etup > browser or the remote management in out-of-band such as Redfish service. > This HII option is configured through EFI_KEYWORD_HANDLER_PROTOCOL." > +#string STR_ONE_OF_PROMPT_NON_X_UEFI #language en-US > "Non x-UEFI HII Option" > + #language fr-FR "Non > x-UEFI HII Option" > +#string STR_ONE_OF_PROMPT_NON_X_UEFI_HELP #language en-US > "This is a HII option which has REST_STYLE flag but without the x-UEFI > namespace UNI string associated. This HII option could be configured by > either setup browser or the remote management in out-of-band such as > Redfish service. This HII option is configured through EFI HII Configura= tion > Routing Protocol becasue it doesn't have x-UEFI namespace UNI string." > #string STR_CHECK_KEYWORD_SUPPORT #language en-US "Check > iSCSI Boot Enable" > #language fr-FR "Check > iSCSI Boot Enable" > #string STR_ONE_OF_HELP #language en-US "My one-of > help is going to be a long string to test out the efficiency of the abil= ity of the I > am tired of typing capabilities" > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20