From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <zhichao.gao@intel.com>
Cc: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Zhiguang Liu'" <zhiguang.liu@intel.com>
Subject: 回复: [edk2-devel] [PATCH V2 4/7] MdePkg/dec: Remove the MD5 GUID
Date: Fri, 30 Oct 2020 09:20:25 +0800 [thread overview]
Message-ID: <004801d6ae5a$d8421f30$88c65d90$@byosoft.com.cn> (raw)
In-Reply-To: <20201027024300.21100-5-zhichao.gao@intel.com>
Zhichao:
MD5 GUID is still defined in UEFI spec. Its definition should be kept.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+66623+4905953+8761045@groups.io
> <bounce+27952+66623+4905953+8761045@groups.io> 代表 Gao, Zhichao
> 发送时间: 2020年10月27日 10:43
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> 主题: [edk2-devel] [PATCH V2 4/7] MdePkg/dec: Remove the MD5 GUID
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3027
>
> The gEfiHashAlgorithmMD5Guid is added for the
> Hash2DxeCrypto driver. Remove it as it is not
> supported.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> MdePkg/Include/Protocol/Hash.h | 8 +-------
> MdePkg/MdePkg.dec | 3 ---
> 2 files changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/MdePkg/Include/Protocol/Hash.h
> b/MdePkg/Include/Protocol/Hash.h
> index 931d7916ef..c1c77c698c 100644
> --- a/MdePkg/Include/Protocol/Hash.h
> +++ b/MdePkg/Include/Protocol/Hash.h
> @@ -5,7 +5,7 @@
> provided by a driver and to create and destroy instances of the EFI
Hash
> Protocol
> so that a multiple drivers can use the underlying hashing services.
>
> -Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> **/
> @@ -48,11 +48,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> 0xcaa4381e, 0x750c, 0x4770, {0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4,
0x21,
> 0x30 } \
> }
>
> -#define EFI_HASH_ALGORTIHM_MD5_GUID \
> - { \
> - 0xaf7c79c, 0x65b5, 0x4319, {0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a,
> 0xd7 } \
> - }
> -
> #define EFI_HASH_ALGORITHM_SHA1_NOPAD_GUID \
> { \
> 0x24c5dc2f, 0x53e2, 0x40ca, {0x9e, 0xd6, 0xa5, 0xd9, 0xa4, 0x9f,
0x46,
> 0x3b } \
> @@ -162,7 +157,6 @@ extern EFI_GUID gEfiHashAlgorithmSha224Guid;
> extern EFI_GUID gEfiHashAlgorithmSha256Guid;
> extern EFI_GUID gEfiHashAlgorithmSha384Guid;
> extern EFI_GUID gEfiHashAlgorithmSha512Guid;
> -extern EFI_GUID gEfiHashAlgorithmMD5Guid;
> extern EFI_GUID gEfiHashAlgorithmSha1NoPadGuid;
> extern EFI_GUID gEfiHashAlgorithmSha256NoPadGuid;
>
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index 812be75fb3..f42eab54cd 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -361,9 +361,6 @@
> ## Include/Guid/HiiKeyBoardLayout.h
> gEfiHiiKeyBoardLayoutGuid = { 0x14982a4f, 0xb0ed, 0x45b8, { 0xa8,
> 0x11, 0x5a, 0x7a, 0x9b, 0xc2, 0x32, 0xdf }}
>
> - ## Include/Protocol/Hash.h
> - gEfiHashAlgorithmMD5Guid = { 0x0AF7C79C, 0x65B5, 0x4319,
> { 0xB0, 0xAE, 0x44, 0xEC, 0x48, 0x4E, 0x4A, 0xD7 }}
> -
> ## Include/Protocol/Hash.h
> gEfiHashAlgorithmSha512Guid = { 0xCAA4381E, 0x750C, 0x4770,
> { 0xB8, 0x70, 0x7A, 0x23, 0xB4, 0xE4, 0x21, 0x30 }}
>
> --
> 2.21.0.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2020-10-30 1:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 2:42 [PATCH V2 0/7] Disable the deprecated MD5 and SHA1 support Gao, Zhichao
2020-10-27 2:42 ` [PATCH V2 1/7] NetworkPkg/Defines: Make iSCSI disable as default Gao, Zhichao
2020-10-27 10:47 ` Laszlo Ersek
2020-10-29 2:34 ` Gao, Zhichao
2020-11-02 15:14 ` Laszlo Ersek
2020-10-27 2:42 ` [PATCH V2 2/7] NetworkPkg: Enable MD5 while enable iSCSI Gao, Zhichao
2020-10-27 2:42 ` [PATCH V2 3/7] SecurityPkg/Hash2DxeCrypto: Remove MD5 support Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
2020-10-27 2:42 ` [PATCH V2 4/7] MdePkg/dec: Remove the MD5 GUID Gao, Zhichao
2020-10-30 1:20 ` gaoliming [this message]
2020-10-27 2:42 ` [PATCH V2 5/7] SecurityPkg/Hash2DxeCrypto: Remove SHA1 support Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
2020-10-27 2:42 ` [PATCH V2 6/7] CryptoPkg/dsc: Enable MD5 when CRYPTO_SERVICES enable MD5 Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
2020-10-27 2:43 ` [PATCH V2 7/7] CryptoPkg: Make the MD5 disable as default for security Gao, Zhichao
2020-10-27 2:53 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='004801d6ae5a$d8421f30$88c65d90$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox