From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.6591.1616721407995912347 for ; Thu, 25 Mar 2021 18:16:49 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 26 Mar 2021 09:16:45 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Chang, Abner \(HPS SW/FW Technologist\)'" Cc: "'Ni, Ray'" , "'Wang, Nickle \(HPS SW\)'" , "'O'Hanley, Peter \(EXL\)'" References: <20210325045236.344-1-abner.chang@hpe.com> <20210325045236.344-3-abner.chang@hpe.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY0IDIvMl0gU2hlbGxQa2cvVWVmaUhhbmRsZVBhcnNpbmdMaWI6IFN1cHBvcnQgRUZJIFJlZGZpc2ggcHJvdG9jb2xz?= Date: Fri, 26 Mar 2021 09:16:45 +0800 Message-ID: <004801d721dd$b087fc70$1197f550$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQImrGFoZqPo18hcVT1J7qDo7MEpggL5+g+fAVtPNGICvNyROAKP5Fm2qalR2/A= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Gao, Zhichao > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C226=C8=D5 8:50 > =CA=D5=BC=FE=C8=CB: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > =B3=AD=CB=CD: Ni, Ray ; Wang, Nickle (HPS SW) > ; O'Hanley, Peter (EXL) ; > Liming Gao > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v4 2/2] ShellPkg/UefiHandleParsing= Lib: > Support EFI Redfish protocols >=20 > You can push with the correction and add my R-B. No need to send V5 if there > is no more comment for your patch set. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Chang, Abner (HPS SW/FW Technologist) > > Sent: Thursday, March 25, 2021 7:36 PM > > To: Gao, Zhichao ; devel@edk2.groups.io > > Cc: Ni, Ray ; Wang, Nickle (HPS SW) > > ; O'Hanley, Peter (EXL) ; > > Liming Gao > > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > Redfish protocols > > > > Hi Zhichao, > > I resend v4 patch, in which your R-B to the previous patch is removed and > > Liming is added to CC list. No others changes were made in this patche= s. > > I will send v5 with the correction on copyright. Or can I just push to master > > with the correction and your R-B? > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Gao, Zhichao [mailto:zhichao.gao@intel.com] > > > Sent: Thursday, March 25, 2021 5:09 PM > > > To: Chang, Abner (HPS SW/FW Technologist) ; > > > devel@edk2.groups.io > > > Cc: Ni, Ray ; Wang, Nickle (HPS SW) > > > ; O'Hanley, Peter (EXL) > > ; > > > Liming Gao > > > Subject: RE: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support E= FI > > > Redfish protocols > > > > > > First, thanks Liming's catch. > > > > > > Abner, > > > > > > The patch has been updated, you should remove my R-B for the V4 > version. > > > Otherwise the reviewers/maintainers may treated it as reviewed one. > > > And please add the one who already gave the comment for your patch t= o > > > the Cc list. They care about the about the change and this would hel= p > > > them to know the update and have a chance to view your patch in an > early > > time. > > > > > > For this patch, the copyright should be updated to 2021. With this > > > updated, > > > Reviewed-by: Zhichao Gao > > > > > > Thanks, > > > Zhichao > > > > > > > -----Original Message----- > > > > From: Abner Chang > > > > Sent: Thursday, March 25, 2021 12:53 PM > > > > To: devel@edk2.groups.io > > > > Cc: Ni, Ray ; Gao, Zhichao > > > > ; Nickle Wang ; Peter > > > > O'Hanley > > > > Subject: [PATCH v4 2/2] ShellPkg/UefiHandleParsingLib: Support EFI > > > Redfish > > > > protocols > > > > > > > > Add handle parsing for EFI Redfish Discover protocol. > > > > Add handle parsing for EFI RestEx protocol. > > > > > > > > Signed-off-by: Abner Chang > > > > Cc: Ray Ni > > > > Cc: Zhichao Gao > > > > Cc: Nickle Wang > > > > Cc: Peter O'Hanley > > > > Reviewed-by: Zhichao Gao > > > > --- > > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.inf | 4 +++= - > > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 8 > +++++++- > > > > .../Library/UefiHandleParsingLib/UefiHandleParsingLib.uni | 4 +++= - > > > > 3 files changed, 13 insertions(+), 3 deletions(-) > > > > > > > > diff --git > > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > > > > index 93b69cd8e9..446cd8d609 100644 > > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i= nf > > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i= nf > > > > @@ -2,7 +2,7 @@ > > > > # Provides interface to advanced shell functionality for parsing > > > > both > > > handle > > > > and protocol database. > > > > # Copyright (c) 2010 - 2018, Intel Corporation. All rights > > > > reserved.
# > > > (C) > > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - > > # > > > > (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> > > > +# (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > > +LP
> > > > # > > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -269,6 > +269,8 > > @@ > > > > gEfiHttpProtocolGuid > ## UNDEFINED > > > > gEfiHttpUtilitiesProtocolGuid ## > UNDEFINED > > > > gEfiRestProtocolGuid ## > UNDEFINED > > > > + gEfiRestExProtocolGuid ## > UNDEFINED > > > > + gEfiRedfishDiscoverProtocolGuid ## > UNDEFINED > > > > gEfiMmEndOfDxeProtocolGuid > ## UNDEFINED > > > > gEfiMmIoTrapDispatchProtocolGuid ## > UNDEFINED > > > > gEfiMmPowerButtonDispatchProtocolGuid > ## UNDEFINED > > > > diff --git > > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > > index 500a95a89a..e34cefd7b4 100644 > > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > > > > @@ -3,7 +3,7 @@ > > > > > > > > Copyright (c) 2010 - 2017, Intel Corporation. All rights > reserved.
> > > > (C) Copyright 2013-2015 Hewlett-Packard Development Company, > > > L.P.
> > > > - (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > > LP
> > > > + (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > LP
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > **/ > > > > @@ -2250,6 +2250,12 @@ STATIC CONST GUID_INFO_BLOCK > > > > mGuidStringList[] =3D { > > > > {STRING_TOKEN(STR_PARTITION_INFO), > > > > &gEfiPartitionInfoProtocolGuid, > > > > PartitionInfoProtocolDumpInformation}, > > > > {STRING_TOKEN(STR_HII_POPUP), > &gEfiHiiPopupProtocolGuid, > > > > NULL}, > > > > > > > > +// > > > > +// UEFI 2.8 > > > > +// > > > > + {STRING_TOKEN(STR_REST_EX), > &gEfiRestExProtocolGuid, > > > > NULL}, > > > > + {STRING_TOKEN(STR_REDFISH_DISCOVER), > > > > &gEfiRedfishDiscoverProtocolGuid, NULL}, > > > > + > > > > // > > > > // PI Spec ones > > > > // > > > > diff --git > > > > a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.uni > > > > index 9c8028d0d5..69fcbdfe0e 100644 > > > > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.u= ni > > > > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.u= ni > > > > @@ -2,7 +2,7 @@ > > > > // > > > > // Copyright (c) 2010 - 2017, Intel Corporation. All rights > > > > reserved.
// > > > (C) > > > > Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> > > > -// > > > > (C) Copyright 2015-2016 Hewlett Packard Enterprise Development > > > > LP
> > > > +// (C) Copyright 2015-2020 Hewlett Packard Enterprise Development > > > > +LP
> > > > // SPDX-License-Identifier: BSD-2-Clause-Patent // // Module > Name: > > > > @@ -308,6 +308,8 @@ > > > > #string STR_NET_HTTP #language en-US "Http" > > > > #string STR_NET_HTTP_U #language en-US > "HttpUtilities" > > > > #string STR_REST #language en-US "Rest" > > > > +#string STR_REST_EX #language en-US "RestEx" > > > > +#string STR_REDFISH_DISCOVER #language en-US > "RedfishDiscover" > > > > > > > > #string STR_MM_EOD #language en-US > "MmEndOfDxe" > > > > #string STR_MM_ITD #language en-US > "MmIoTrapDispatch" > > > > -- > > > > 2.17.1 > > >=20 >=20 >=20 >=20 >=20