public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] BaseTools: Change non-ascii character of StructurePcd comment
@ 2021-04-28  8:44 Yuwei Chen
  2021-04-28 16:10 ` [edk2-devel] " Michael D Kinney
  0 siblings, 1 reply; 6+ messages in thread
From: Yuwei Chen @ 2021-04-28  8:44 UTC (permalink / raw)
  To: devel; +Cc: Bob Feng, Liming Gao

Currently, the ConvertFceToStructurePcd.py tool generate StructurePcd
dsc file with comments including non-ascii character circle R. This
patch changes the non-ascii character circle R to (R) when adding the
comment.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
 BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py b/BaseTools/Scripts/ConvertFceToStructurePcd.py
index 2052db8c4b..d029ed6a28 100644
--- a/BaseTools/Scripts/ConvertFceToStructurePcd.py
+++ b/BaseTools/Scripts/ConvertFceToStructurePcd.py
@@ -285,6 +285,10 @@ class Config(object):
         comment_list = value_re.findall(line) # the string \\... in "Q...." line
         comment_list[0] = comment_list[0].replace('//', '')
         comment = comment_list[0].strip()
+        comment_b = bytes(comment, encoding = "utf8")
+        if b"\xae" in comment_b:
+            comment_b = comment_b.replace(b"\xc2\xae", b"(R)") # Change the circle "R" character to ascii character
+        comment = str(comment_b, encoding = "utf-8")
         line=value_re.sub('',line) #delete \\... in "Q...." line
         list1=line.split(' ')
         value=self.value_parser(list1)
-- 
2.26.1.windows.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-04-29  2:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-28  8:44 [PATCH] BaseTools: Change non-ascii character of StructurePcd comment Yuwei Chen
2021-04-28 16:10 ` [edk2-devel] " Michael D Kinney
2021-04-29  0:25   ` Yuwei Chen
2021-04-29  1:18     ` 回复: " gaoliming
2021-04-29  1:23       ` Yuwei Chen
2021-04-29  2:12         ` Michael D Kinney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox