public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <rebecca@bsdio.com>,
	"'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
Date: Thu, 17 Jun 2021 09:36:35 +0800	[thread overview]
Message-ID: <004801d76319$35933110$a0b99330$@byosoft.com.cn> (raw)
In-Reply-To: <20210613034301.98641-1-rebecca@bsdio.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:43
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat
> after edk2basetools check
> 
> When using the in-source BaseTools, edksetup.bat will exit with an
> ERRORLEVEL of 1 because the line in toolsetup.bat
> "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL"
> fails.
> 
> Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is
> successfully run.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  BaseTools/toolsetup.bat | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
> index a766a69f08..ca8bfdd677 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -401,6 +401,8 @@ goto end
>    if %ERRORLEVEL% EQU 0 (
> 
>      goto use_pip_basetools
> 
>    ) else (
> 
> +    REM reset ERRORLEVEL
> 
> +    type nul>nul
> 
>      goto use_builtin_basetools
> 
>    )
> 
> 
> 
> --
> 2.32.0
> 
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76442): https://edk2.groups.io/g/devel/message/76442
> Mute This Topic: https://groups.io/mt/83503069/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
> 




  reply	other threads:[~2021-06-17  1:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13  3:43 [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check Rebecca Cran
2021-06-17  1:36 ` gaoliming [this message]
2021-06-25  1:53 ` [edk2-devel] " Bob Feng
     [not found] ` <168BB05C0D926F60.31827@groups.io>
2021-06-25  4:20   ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004801d76319$35933110$a0b99330$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox