* [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
@ 2021-06-13 3:43 Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rebecca Cran @ 2021-06-13 3:43 UTC (permalink / raw)
To: Bob Feng, Liming Gao, Yuwei Chen; +Cc: Rebecca Cran, devel
When using the in-source BaseTools, edksetup.bat will exit with an
ERRORLEVEL of 1 because the line in toolsetup.bat
"%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL"
fails.
Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is
successfully run.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
index a766a69f08..ca8bfdd677 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -401,6 +401,8 @@ goto end
if %ERRORLEVEL% EQU 0 (
goto use_pip_basetools
) else (
+ REM reset ERRORLEVEL
+ type nul>nul
goto use_builtin_basetools
)
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* 回复: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
2021-06-13 3:43 [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check Rebecca Cran
@ 2021-06-17 1:36 ` gaoliming
2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB05C0D926F60.31827@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: gaoliming @ 2021-06-17 1:36 UTC (permalink / raw)
To: devel, rebecca, 'Bob Feng', 'Yuwei Chen'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
> 发送时间: 2021年6月13日 11:43
> 收件人: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> 主题: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat
> after edk2basetools check
>
> When using the in-source BaseTools, edksetup.bat will exit with an
> ERRORLEVEL of 1 because the line in toolsetup.bat
> "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL"
> fails.
>
> Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is
> successfully run.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/toolsetup.bat | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat
> index a766a69f08..ca8bfdd677 100755
> --- a/BaseTools/toolsetup.bat
> +++ b/BaseTools/toolsetup.bat
> @@ -401,6 +401,8 @@ goto end
> if %ERRORLEVEL% EQU 0 (
>
> goto use_pip_basetools
>
> ) else (
>
> + REM reset ERRORLEVEL
>
> + type nul>nul
>
> goto use_builtin_basetools
>
> )
>
>
>
> --
> 2.32.0
>
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#76442): https://edk2.groups.io/g/devel/message/76442
> Mute This Topic: https://groups.io/mt/83503069/4905953
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaoliming@byosoft.com.cn]
> -=-=-=-=-=-=
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
2021-06-13 3:43 [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
@ 2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB05C0D926F60.31827@groups.io>
2 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-06-25 1:53 UTC (permalink / raw)
To: devel@edk2.groups.io, rebecca@bsdio.com, Liming Gao,
Chen, Christine
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Sunday, June 13, 2021 11:43 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
When using the in-source BaseTools, edksetup.bat will exit with an ERRORLEVEL of 1 because the line in toolsetup.bat "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL"
fails.
Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is successfully run.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index a766a69f08..ca8bfdd677 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -401,6 +401,8 @@ goto end
if %ERRORLEVEL% EQU 0 ( goto use_pip_basetools ) else (+ REM reset ERRORLEVEL+ type nul>nul goto use_builtin_basetools ) --
2.32.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76442): https://edk2.groups.io/g/devel/message/76442
Mute This Topic: https://groups.io/mt/83503069/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <168BB05C0D926F60.31827@groups.io>]
* Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
[not found] ` <168BB05C0D926F60.31827@groups.io>
@ 2021-06-25 4:20 ` Bob Feng
0 siblings, 0 replies; 4+ messages in thread
From: Bob Feng @ 2021-06-25 4:20 UTC (permalink / raw)
To: devel@edk2.groups.io, Feng, Bob C, rebecca@bsdio.com, Liming Gao,
Chen, Christine
Merged.
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Friday, June 25, 2021 9:53 AM
To: devel@edk2.groups.io; rebecca@bsdio.com; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
Sent: Sunday, June 13, 2021 11:43 AM
To: Feng, Bob C <bob.c.feng@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
Subject: [edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check
When using the in-source BaseTools, edksetup.bat will exit with an ERRORLEVEL of 1 because the line in toolsetup.bat "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL"
fails.
Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is successfully run.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
BaseTools/toolsetup.bat | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index a766a69f08..ca8bfdd677 100755
--- a/BaseTools/toolsetup.bat
+++ b/BaseTools/toolsetup.bat
@@ -401,6 +401,8 @@ goto end
if %ERRORLEVEL% EQU 0 ( goto use_pip_basetools ) else (+ REM reset ERRORLEVEL+ type nul>nul goto use_builtin_basetools ) --
2.32.0
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#76442): https://edk2.groups.io/g/devel/message/76442
Mute This Topic: https://groups.io/mt/83503069/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-25 4:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-13 3:43 [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check Rebecca Cran
2021-06-17 1:36 ` 回复: [edk2-devel] " gaoliming
2021-06-25 1:53 ` Bob Feng
[not found] ` <168BB05C0D926F60.31827@groups.io>
2021-06-25 4:20 ` Bob Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox