[PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[Rebecca Cran]

Fix typos in MdePkg/Include/IndustryStandard/SmBios.h and make
corresponding changes to the ShellPkg smbiosview command.

Testing:

Built OvmfPkgX64, OvmfPkgIa32, OvmfPkgIa32X64 for DEBUG, RELEASE, NOOPT
Built edk2-platforms RPi4, SbsaQemu for DEBUG, RELEASE, NOOPT
Built edk2-platforms Armada80x0McBin for RELEASE
Built edk2-platforms Intel UpXtreme, GalagoPro3, KabylakeRvp3

Ran stuart_ci_build with X64,AARCH64,RISCV64,IA32 for NO-TARGET,NOOPT,RELEASE,DEBUG

Ran OVMF X64 and verified smbiosview runs correctly.

Ran Gitlab CI: https://github.com/tianocore/edk2/pull/1178

Changes from v1:

Added updates to fix the smbiosview shell command.

Rebecca Cran (3):
  MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct
  MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
    ProcessorManufacturer
  MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion

 MdePkg/Include/IndustryStandard/SmBios.h                           | 26 ++++++++++----------
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c |  4 +--
 2 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.26.2

[PATCH v2 1/3] MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct

[Rebecca Cran]

Fix typos of "Processor64BitCapable", "ProcessorEnhancedVirtualization",
and Processor128BitCapable.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 22 ++++++++++----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 1ee01645679a..400bdef90b4f 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -862,17 +862,17 @@ typedef struct {
 } PROCESSOR_FEATURE_FLAGS;
 
 typedef struct {
-  UINT16  ProcessorReserved1             :1;
-  UINT16  ProcessorUnknown               :1;
-  UINT16  Processor64BitCapble           :1;
-  UINT16  ProcessorMultiCore             :1;
-  UINT16  ProcessorHardwareThread        :1;
-  UINT16  ProcessorExecuteProtection     :1;
-  UINT16  ProcessorEnhancedVirtulization :1;
-  UINT16  ProcessorPowerPerformanceCtrl  :1;
-  UINT16  Processor128bitCapble          :1;
-  UINT16  ProcessorArm64SocId            :1;
-  UINT16  ProcessorReserved2             :6;
+  UINT16  ProcessorReserved1              :1;
+  UINT16  ProcessorUnknown                :1;
+  UINT16  Processor64BitCapable           :1;
+  UINT16  ProcessorMultiCore              :1;
+  UINT16  ProcessorHardwareThread         :1;
+  UINT16  ProcessorExecuteProtection      :1;
+  UINT16  ProcessorEnhancedVirtualization :1;
+  UINT16  ProcessorPowerPerformanceCtrl   :1;
+  UINT16  Processor128BitCapable          :1;
+  UINT16  ProcessorArm64SocId             :1;
+  UINT16  ProcessorReserved2              :6;
 } PROCESSOR_CHARACTERISTIC_FLAGS;
 
 typedef struct {
-- 
2.26.2

[PATCH v2 2/3] MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field ProcessorManufacturer

[Rebecca Cran]

In SmBios.h, the SMBIOS_TABLE_TYPE4 field "ProcessorManufacture"
should be "ProcessorManufacturer".

Also, update SmbiosView PrintInfo.c to use the new field name.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h                           | 2 +-
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 400bdef90b4f..ac2498482a92 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -894,7 +894,7 @@ typedef struct {
   SMBIOS_TABLE_STRING   Socket;
   UINT8                 ProcessorType;          ///< The enumeration value from PROCESSOR_TYPE_DATA.
   UINT8                 ProcessorFamily;        ///< The enumeration value from PROCESSOR_FAMILY_DATA.
-  SMBIOS_TABLE_STRING   ProcessorManufacture;
+  SMBIOS_TABLE_STRING   ProcessorManufacturer;
   PROCESSOR_ID_DATA     ProcessorId;
   SMBIOS_TABLE_STRING   ProcessorVersion;
   PROCESSOR_VOLTAGE     Voltage;
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 478811f0fd40..3d12b25bf91c 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -427,7 +427,7 @@ SmbiosPrintStructure (
     } else {
       DisplayProcessorFamily (Struct->Type4->ProcessorFamily, Option);
     }
-    PRINT_PENDING_STRING (Struct, Type4, ProcessorManufacture);
+    PRINT_PENDING_STRING (Struct, Type4, ProcessorManufacturer);
     PRINT_BIT_FIELD (Struct, Type4, ProcessorId, 8);
     PRINT_PENDING_STRING (Struct, Type4, ProcessorVersion);
     DisplayProcessorVoltage (*(UINT8 *) &(Struct->Type4->Voltage), Option);
-- 
2.26.2

[PATCH v2 3/3] MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion

[Rebecca Cran]

"FirmwareVersion" was misspelled "FirwareVersion".
Also, update SmbiosView PrintInfo.c to use the new field name.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h                           | 2 +-
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index ac2498482a92..3bc8732eef99 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1837,7 +1837,7 @@ typedef struct {
   //
   UINT8                                     MemoryTechnology;   ///< The enumeration value from MEMORY_DEVICE_TECHNOLOGY
   MEMORY_DEVICE_OPERATING_MODE_CAPABILITY   MemoryOperatingModeCapability;
-  SMBIOS_TABLE_STRING                       FirwareVersion;
+  SMBIOS_TABLE_STRING                       FirmwareVersion;
   UINT16                                    ModuleManufacturerID;
   UINT16                                    ModuleProductID;
   UINT16                                    MemorySubsystemControllerManufacturerID;
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 3d12b25bf91c..be8ae13c17d1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -776,7 +776,7 @@ SmbiosPrintStructure (
       if (Struct->Hdr->Length > 0x28) {
         DisplayMemoryDeviceMemoryTechnology (Struct->Type17->MemoryTechnology, Option);
         DisplayMemoryDeviceMemoryOperatingModeCapability (Struct->Type17->MemoryOperatingModeCapability.Uint16, Option);
-        PRINT_PENDING_STRING (Struct, Type17, FirwareVersion);
+        PRINT_PENDING_STRING (Struct, Type17, FirmwareVersion);
         PRINT_STRUCT_VALUE_H (Struct, Type17, ModuleManufacturerID);
         PRINT_STRUCT_VALUE_H (Struct, Type17, ModuleProductID);
         PRINT_STRUCT_VALUE_H (Struct, Type17, MemorySubsystemControllerManufacturerID);
-- 
2.26.2

回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[gaoliming]

Rebecca:
  Thanks for your updating to make edk2 pass build with this change. 

  Can you also provide the patch to edk2-platforms if the change is small?

Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@nuviainc.com>
> 发送时间: 2020年12月4日 13:11
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>
> 主题: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in
> IndustryStandard/SmBios.h
> 
> Fix typos in MdePkg/Include/IndustryStandard/SmBios.h and make
> corresponding changes to the ShellPkg smbiosview command.
> 
> Testing:
> 
> Built OvmfPkgX64, OvmfPkgIa32, OvmfPkgIa32X64 for DEBUG, RELEASE,
> NOOPT
> Built edk2-platforms RPi4, SbsaQemu for DEBUG, RELEASE, NOOPT
> Built edk2-platforms Armada80x0McBin for RELEASE
> Built edk2-platforms Intel UpXtreme, GalagoPro3, KabylakeRvp3
> 
> Ran stuart_ci_build with X64,AARCH64,RISCV64,IA32 for
> NO-TARGET,NOOPT,RELEASE,DEBUG
> 
> Ran OVMF X64 and verified smbiosview runs correctly.
> 
> Ran Gitlab CI: https://github.com/tianocore/edk2/pull/1178
> 
> Changes from v1:
> 
> Added updates to fix the smbiosview shell command.
> 
> Rebecca Cran (3):
>   MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS
> struct
>   MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE4 field
>     ProcessorManufacturer
>   MdePkg,ShellPkg: Fix typo in SMBIOS_TABLE_TYPE17 field FirmwareVersion
> 
>  MdePkg/Include/IndustryStandard/SmBios.h
> | 26 ++++++++++----------
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c |
> 4 +--
>  2 files changed, 15 insertions(+), 15 deletions(-)
> 
> --
> 2.26.2

Re: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[Rebecca Cran]

> On Dec 7, 2020, at 10:38 PM, gaoliming <gaoliming@byosoft.com.cn> wrote:
> 
> Rebecca:
>  Thanks for your updating to make edk2 pass build with this change. 
> 
>  Can you also provide the patch to edk2-platforms if the change is small?

No changes to edk2-platforms are needed.

— 
Rebecca Cran 

回复: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[gaoliming]

That's great. So, this patch set has no impact to edk2-platforms.

For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68440+4905953+8761045@groups.io
> <bounce+27952+68440+4905953+8761045@groups.io> 代表 Rebecca Cran
> 发送时间: 2020年12月8日 13:53
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Ray
> Ni <ray.ni@intel.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in
> IndustryStandard/SmBios.h
> 
> 
> 
> > On Dec 7, 2020, at 10:38 PM, gaoliming <gaoliming@byosoft.com.cn>
> wrote:
> >
> > Rebecca:
> >  Thanks for your updating to make edk2 pass build with this change.
> >
> >  Can you also provide the patch to edk2-platforms if the change is small?
> 
> No changes to edk2-platforms are needed.
> 
> —
> Rebecca Cran
> 
> 
> 
> 
> 

回复: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in IndustryStandard/SmBios.h

[gaoliming]

Rebecca:
  I create PR https://github.com/tianocore/edk2/pull/1214 for this patch set.

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+68442+4905953+8761045@groups.io
> <bounce+27952+68442+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年12月8日 14:04
> 收件人: devel@edk2.groups.io; rebecca@bsdio.com
> 抄送: 'Rebecca Cran' <rebecca@nuviainc.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Ray
> Ni' <ray.ni@intel.com>
> 主题: 回复: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos
> in IndustryStandard/SmBios.h
> 
> That's great. So, this patch set has no impact to edk2-platforms.
> 
> For this patch set, Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+68440+4905953+8761045@groups.io
> > <bounce+27952+68440+4905953+8761045@groups.io> 代表 Rebecca
> Cran
> > 发送时间: 2020年12月8日 13:53
> > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>; Ray
> > Ni <ray.ni@intel.com>
> > 主题: Re: [edk2-devel] 回复: [PATCH v2 0/3] MdePkg,ShellPkg: Fix typos in
> > IndustryStandard/SmBios.h
> >
> >
> >
> > > On Dec 7, 2020, at 10:38 PM, gaoliming <gaoliming@byosoft.com.cn>
> > wrote:
> > >
> > > Rebecca:
> > >  Thanks for your updating to make edk2 pass build with this change.
> > >
> > >  Can you also provide the patch to edk2-platforms if the change is small?
> >
> > No changes to edk2-platforms are needed.
> >
> > —
> > Rebecca Cran
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
>