From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.2017.1623894353406429248
 for <devel@edk2.groups.io>;
 Wed, 16 Jun 2021 18:45:53 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bret.barkelew@microsoft.com>; Thu, 17 Jun 2021 09:45:50 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Kun Qin'" <kuqin12@gmail.com>,
	<devel@edk2.groups.io>
Cc: "'Sean Brogan'" <sean.brogan@microsoft.com>,
	"'Bret Barkelew'" <Bret.Barkelew@microsoft.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Bret Barkelew'" <bret.barkelew@microsoft.com>
References: <20210615165357.1993-1-kuqin12@gmail.com> <20210615165357.1993-2-kuqin12@gmail.com>
In-Reply-To: <20210615165357.1993-2-kuqin12@gmail.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggdjIgMS8xXSBQeXRvb2w6IFNwZWxsQ2hlY2s6IERlZmVyIHBhdGggZXhwYW5zaW9uIGluIGNzcGVsbCBwYXJhbWV0ZXJz?=
Date: Thu, 17 Jun 2021 09:45:51 +0800
Message-ID: <004a01d7631a$8107f1c0$8317d540$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQItnrYaynKWIh+G9e9KvKEOKESbXgEu3iFsqmGAncA=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Kun Qin <kuqin12@gmail.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA6=D4=C216=C8=D5 0:54
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Bret Barkelew <bret.barkelew@microsoft.com>
> =D6=F7=CC=E2: [PATCH v2 1/1] Pytool: SpellCheck: Defer path expansion =
in cspell
> parameters
>=20
> From: Sean Brogan <sean.brogan@microsoft.com>
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3454
>=20
> On Linux the shell expands the wildcard paths and causes multiple =
files
> to be missed. This change adds additional quotes to defer expansion in
> order to bring parity in cspell result.
>=20
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>=20
> Signed-off-by: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Sean Brogan <sean.brogan@microsoft.com>
> Reviewed-by: Bret Barkelew <bret.barkelew@microsoft.com>
> ---
>=20
> Notes:
>     v2:
>     - Added reviewed-by tags [Bret]
>     - Added reviewed-by tag [Sean]
>     - Added signed-off-by tag from Kun [Sean]
>=20
>  .pytool/Plugin/SpellCheck/SpellCheck.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/.pytool/Plugin/SpellCheck/SpellCheck.py
> b/.pytool/Plugin/SpellCheck/SpellCheck.py
> index 9ad57632a6e8..05c471d91ba1 100644
> --- a/.pytool/Plugin/SpellCheck/SpellCheck.py
> +++ b/.pytool/Plugin/SpellCheck/SpellCheck.py
> @@ -134,7 +134,8 @@ class SpellCheck(ICiBuildPlugin):
>          #
>          relpath =3D os.path.relpath(abs_pkg_path)
>          cpsell_paths =3D " ".join(
> -            [f"{relpath}/**/{x}" for x in
> package_relative_paths_to_spell_check])
> +            # Double quote each path to defer expansion to cspell
> parameters
> +            [f'"{relpath}/**/{x}"' for x in
> package_relative_paths_to_spell_check])
>=20
>          # Make the config file
>          config_file_path =3D os.path.join(
> --
> 2.31.1.windows.1