From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.29797.1610342561764056477
 for <devel@edk2.groups.io>;
 Sun, 10 Jan 2021 21:22:43 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <ard.biesheuvel@arm.com>; Mon, 11 Jan 2021 13:22:31 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<leif@nuviainc.com>,
	"'Rebecca Cran'" <rebecca@nuviainc.com>
Cc: "'Ard Biesheuvel'" <ard.biesheuvel@arm.com>,
	"'nd @ arm . com . Sami Mujawar'" <Sami.Mujawar@arm.com>,
	"'Michael D Kinney'" <michael.d.kinney@intel.com>,
	"'Zhiguang Liu'" <zhiguang.liu@intel.com>
References: <20210104225830.12606-1-rebecca@nuviainc.com> <20210104225830.12606-19-rebecca@nuviainc.com> <20210110020349.GD1664@vanye> <83f2cdf3-d988-e943-3347-12a7dab20ea9@nuviainc.com> <20210111012937.GL1664@vanye>
In-Reply-To: <20210111012937.GL1664@vanye>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY1IDE4LzIzXSBBcm1Qa2c6IEFkZCBVbml2ZXJzYWwvU21iaW9zL1NtYmlvc01pc2NEeGU=?=
Date: Mon, 11 Jan 2021 13:22:31 +0800
Message-ID: <004b01d6e7d9$c3304b90$4990e2b0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKGtHd950kezobvPx17obXtRTCYcgIDyTfXAzxv5FUBtabp1wCKfiTgqIZErJA=
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Leif:
  There are three SmBios.h files in MdePkg. Their file name are
inconsistent. But, they exist since they were added, Protocol\Smbios.h was
added on 2009. This is the known issue. So, I don't suggest to rename thei=
r
file name.

MdePkg\Include\Guid\SmBios.h
MdePkg\Include\Protocol\Smbios.h
MdePkg\Include\IndustryStandard\SmBios.h

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: bounce+27952+70095+4905953+8761045@groups.io
> <bounce+27952+70095+4905953+8761045@groups.io> =B4=FA=B1=ED Leif Lindhol=
m
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA1=D4=C211=C8=D5 9:30
> =CA=D5=BC=FE=C8=CB: Rebecca Cran <rebecca@nuviainc.com>
> =B3=AD=CB=CD: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@arm.c=
om>; nd
> @ arm . com . Sami Mujawar <Sami.Mujawar@arm.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Michael D Kinney
> <michael.d.kinney@intel.com>; Zhiguang Liu <zhiguang.liu@intel.com>
> =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v5 18/23] ArmPkg: Add
> Universal/Smbios/SmbiosMiscDxe
>=20
> On Sun, Jan 10, 2021 at 17:21:16 -0700, Rebecca Cran wrote:
> > On 1/9/21 7:03 PM, Leif Lindholm wrote:
> > > On Mon, Jan 04, 2021 at 15:58:25 -0700, Rebecca Cran wrote:
> >
> > > > +#include <Protocol/Smbios.h>
> > > > +#include <IndustryStandard/SmBios.h>
> > >
> > > We appear to still have a discrepancy w.r.t. Smbios/SmBios
capitalisation.
> >
> > I was planning to commit the SMBIOS series and then fix the
capitalization
> > of the header to be Smbios.h - should I do it the other way around?
>=20
> That would make this set cleaner.
>=20
> Also, we're approaching the halfway point of this development cycle,
> and since renaming IndustryStandard/SmBios.h and Guid/SmBios.h *will*
> break many out-of-tree platforms, it's better to get it in sooner
> rather than later.
>=20
> (Presumably builds on Windows and Os X will succeed anyway, but ...)
>=20
> It would be nice if you could also submit a set fixing up the include
> statements in all of the edk2-platforms ports.
>=20
> /
>     Leif
>=20
>=20
>=20
>=20