回复: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC discard list

["gaoliming" <gaoliming@byosoft.com.cn>]

Christopher:
  Based on current information, I am OK for this change. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Christopher
> Zurcher
> 发送时间: 2021年7月21日 9:15
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn
> 抄送: 'Ard Biesheuvel' <ardb@kernel.org>; 'Bob Feng' <bob.c.feng@intel.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON
> section from the GCC discard list
> 
> Yes, this was verified with OVMF.
> 
> Thanks,
> Christopher Zurcher
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Tuesday, July 20, 2021 18:12
> To: christopher.zurcher@outlook.com; devel@edk2.groups.io
> Cc: 'Ard Biesheuvel' <ardb@kernel.org>; 'Bob Feng' <bob.c.feng@intel.com>
> Subject: [edk2-devel] 回复: [PATCH v7 1/3] BaseTools: Remove COMMON
> section from the GCC discard list
> 
> Christopher:
>   Thanks for your update. Can you let me know which platform is verified
> with this change by GCC tool chain? Ovmf?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: christopher.zurcher@outlook.com
> > <christopher.zurcher@outlook.com>
> > 发送时间: 2021年7月21日 6:07
> > 收件人: devel@edk2.groups.io
> > 抄送: Ard Biesheuvel <ardb@kernel.org>; Bob Feng
> <bob.c.feng@intel.com>;
> > Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: [PATCH v7 1/3] BaseTools: Remove COMMON section from the GCC
> > discard list
> >
> > From: Christopher Zurcher <christopher.zurcher@microsoft.com>
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507
> >
> > The COMMON section is used by OpenSSL assembly-optimized crypto
> > functions. OpenSSL assembly code is auto-generated from the submodule
> > and cannot be modified to remove dependence on the COMMON section.
> > The default -fno-common compiler flag should still prevent variable
> > from being emitted into the COMMON section.
> >
> > Cc: Ard Biesheuvel <ardb@kernel.org>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Christopher Zurcher <christopher.zurcher@microsoft.com>
> > ---
> >  BaseTools/Scripts/GccBase.lds | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/BaseTools/Scripts/GccBase.lds
> > b/BaseTools/Scripts/GccBase.lds index a9dd2138d4..83cebd29d5 100644
> > --- a/BaseTools/Scripts/GccBase.lds
> > +++ b/BaseTools/Scripts/GccBase.lds
> > @@ -74,6 +74,5 @@ SECTIONS {
> >      *(.dynamic)
> >      *(.hash .gnu.hash)
> >      *(.comment)
> > -    *(COMMON)
> >    }
> >  }
> > --
> > 2.32.0.windows.1
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
>