From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.1111.1626832012726861091 for ; Tue, 20 Jul 2021 18:46:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 21 Jul 2021 09:46:48 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Ard Biesheuvel'" , "'Bob Feng'" References: <20210720220646.659-1-christopher.zurcher@outlook.com> <004301d77dcd$670f1b90$352d52b0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0ggdjcgMS8zXSBCYXNlVG9vbHM6IFJlbW92ZSBDT01NT04gc2VjdGlvbiBmcm9tIHRoZSBHQ0MgZGlzY2FyZCBsaXN0?= Date: Wed, 21 Jul 2021 09:46:50 +0800 Message-ID: <004e01d77dd2$4633c100$d29b4300$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJ5kGoOeGOvNUe1+U4VClsJD2mD/gKputGHAV5G6sICNeHN26nWlFkw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Christopher: Based on current information, I am OK for this change. Reviewed-by: Limi= ng Gao Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Christopher > Zurcher > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8821=E6=97=A5= 9:15 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com= .cn > =E6=8A=84=E9=80=81: 'Ard Biesheuvel' ; 'Bob Feng' > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH v7 1/3] = BaseTools: Remove COMMON > section from the GCC discard list >=20 > Yes, this was verified with OVMF. >=20 > Thanks, > Christopher Zurcher >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Tuesday, July 20, 2021 18:12 > To: christopher.zurcher@outlook.com; devel@edk2.groups.io > Cc: 'Ard Biesheuvel' ; 'Bob Feng' > Subject: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH v7 1/3] BaseTools: Remo= ve COMMON > section from the GCC discard list >=20 > Christopher: > Thanks for your update. Can you let me know which platform is verified > with this change by GCC tool chain? Ovmf? >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: christopher.zurcher@outlook.com > > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B47=E6=9C=8821=E6=97= =A5 6:07 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Ard Biesheuvel ; Bob Feng > ; > > Liming Gao > > =E4=B8=BB=E9=A2=98: [PATCH v7 1/3] BaseTools: Remove COMMON section fr= om the GCC > > discard list > > > > From: Christopher Zurcher > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2507 > > > > The COMMON section is used by OpenSSL assembly-optimized crypto > > functions. OpenSSL assembly code is auto-generated from the submodule > > and cannot be modified to remove dependence on the COMMON section. > > The default -fno-common compiler flag should still prevent variable > > from being emitted into the COMMON section. > > > > Cc: Ard Biesheuvel > > Cc: Bob Feng > > Cc: Liming Gao > > Signed-off-by: Christopher Zurcher > > --- > > BaseTools/Scripts/GccBase.lds | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/GccBase.lds > > b/BaseTools/Scripts/GccBase.lds index a9dd2138d4..83cebd29d5 100644 > > --- a/BaseTools/Scripts/GccBase.lds > > +++ b/BaseTools/Scripts/GccBase.lds > > @@ -74,6 +74,5 @@ SECTIONS { > > *(.dynamic) > > *(.hash .gnu.hash) > > *(.comment) > > - *(COMMON) > > } > > } > > -- > > 2.32.0.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20