From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.2217.1623895517743126030 for ; Wed, 16 Jun 2021 19:05:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 17 Jun 2021 10:05:13 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Kun Qin'" , Cc: "'Sean Brogan'" , "'Bret Barkelew'" , "'Michael D Kinney'" , "'Ard Biesheuvel'" References: <20210614183431.1657-1-kuqin12@gmail.com> <168886A01B551E5C.18371@groups.io> <3a843b53-28f4-0a8a-d123-faf4ae6af2dd@gmail.com> In-Reply-To: <3a843b53-28f4-0a8a-d123-faf4ae6af2dd@gmail.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDQvNF0gQXp1cmVwaXBlbGluZTogU3BlbGxDaGVjazogRW5mb3JjZSBOb2RlIGRlcGVuZGVuY3kgdG8gdXNlIHZlcnNpb24gMTQueA==?= Date: Thu, 17 Jun 2021 10:05:14 +0800 Message-ID: <004f01d7631d$3651f060$a2f5d120$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHOU9J9XN6zf+1jb0LJJlzs0grWFQJjM3qvAZQyKTyrCdeMsA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Acked-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Kun Qin > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: = 2021=E5=B9=B46=E6=9C=8817=E6=97=A5 5:08 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Sean Brogan ; Bret = Barkelew > ; Michael D Kinney > ; Liming Gao ; > Ard Biesheuvel > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: = SpellCheck: Enforce > Node dependency to use version 14.x >=20 > Hi pipeline maintainers, >=20 > Could you please help reviewing this specific patch? >=20 > Thanks to Ard, the other patches in this series are already reviewed = and > merged. >=20 > Regards, > Kun >=20 > On 06/14/2021 11:34, Kun Qin via groups.io wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3445 > > > > Per update from Cspell tool, the minimal requirement of Cspell 5.x > > regarding Node is 12 and above. This has caused multple Cspell = failures > > during CI build validation: > > "Failed to process "**.c" TypeError: text.matchAll(...) is not a = function > > or its return value is not iterable" > > > > This change updates the lowest required node version to 14.x to = support > > Cspell functionalities. > > > > Cc: Sean Brogan > > Cc: Bret Barkelew > > Cc: Michael D Kinney > > Cc: Liming Gao > > > > Signed-off-by: Kun Qin > > Reviewed-by: Ard Biesheuvel > > --- > > > > Notes: > > v2: > > - Added reviewed-by tag [Ard] > > > > .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml > b/.azurepipelines/templates/spell-check-prereq-steps.yml > > index e1570d4f2aac..98ee3cfa6bc6 100644 > > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > > @@ -13,7 +13,7 @@ parameters: > > steps: > > - task: NodeTool@0 > > inputs: > > - versionSpec: '10.x' > > + versionSpec: '14.x' > > #checkLatest: false # Optional > > condition: and(gt(variables.pkg_count, 0), succeeded()) > > > >