MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

[Anbazhagan, Baraneedharan]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

Coding error in converting memset call to SetMem - Length and Value
is not swapped on calling SetMem

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com>
---
MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
index 2b2b0d420d..9aa7b0a68e 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int count)
 void* memset (void *dest, char ch, unsigned int count)
{
-  return SetMem (dest, ch, count);
+  return SetMem (dest, count, ch);
}
--
2.29.2.windows.3


[-- Attachment #2: Type: text/html, Size: 3271 bytes --]

回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

发件人: bounce+27952+68609+4905953+8761045@groups.io
<bounce+27952+68609+4905953+8761045@groups.io> 代表 Anbazhagan,
Baraneedharan via groups.io
发送时间: 2020年12月10日 8:21
收件人: devel@edk2.groups.io
抄送: gaoliming@byosoft.com.cn; jian.j.wang@intel.com; hao.a.wu@intel.com
主题: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

 

Coding error in converting memset call to SetMem - Length and Value

is not swapped on calling SetMem

 

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com
<mailto:anbazhagan@hp.com> >

---

MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

index 2b2b0d420d..9aa7b0a68e 100644

--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int
count)

 

 void* memset (void *dest, char ch, unsigned int count)

{

-  return SetMem (dest, ch, count);

+  return SetMem (dest, count, ch);

}

 

-- 

2.29.2.windows.3

 




[-- Attachment #2: Type: text/html, Size: 5787 bytes --]

回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]

Create PR https://github.com/tianocore/edk2/pull/1219

 

Thanks

Liming

发件人: bounce+27952+68612+4905953+8761045@groups.io
<bounce+27952+68612+4905953+8761045@groups.io> 代表 gaoliming
发送时间: 2020年12月10日 9:28
收件人: devel@edk2.groups.io; anbazhagan@hp.com
抄送: jian.j.wang@intel.com; hao.a.wu@intel.com
主题: 回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in
OnigurumaUefiPort

 

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.
com.cn> >

 

发件人: bounce+27952+68609+4905953+8761045@groups.io
<mailto:bounce+27952+68609+4905953+8761045@groups.io>
<bounce+27952+68609+4905953+8761045@groups.io
<mailto:bounce+27952+68609+4905953+8761045@groups.io> > 代表 Anbazhagan,
Baraneedharan via groups.io
发送时间: 2020年12月10日 8:21
收件人: devel@edk2.groups.io <mailto:devel@edk2.groups.io> 
抄送: gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ;
jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> ; hao.a.wu@intel.com
<mailto:hao.a.wu@intel.com> 
主题: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

 

Coding error in converting memset call to SetMem - Length and Value

is not swapped on calling SetMem

 

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com
<mailto:anbazhagan@hp.com> >

---

MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

index 2b2b0d420d..9aa7b0a68e 100644

--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int
count)

 

 void* memset (void *dest, char ch, unsigned int count)

{

-  return SetMem (dest, ch, count);

+  return SetMem (dest, count, ch);

}

 

-- 

2.29.2.windows.3

 




[-- Attachment #2: Type: text/html, Size: 7918 bytes --]