From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.11102.1614260182676594748 for ; Thu, 25 Feb 2021 05:36:25 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([101.86.139.83]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 25 Feb 2021 21:36:10 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.86.139.83 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Michael Kubacki'" Cc: "'Ard Biesheuvel'" , "'Sami Mujawar'" , "'Jiewen Yao'" , "'Supreeth Venkatesh'" , "'Laszlo Ersek'" References: <20210225033312.2324-1-mikuback@linux.microsoft.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gU3RhbmRhbG9uZU1tUGtnOiBSZW1vdmUgU3RhbmRhbG9uZU1tRHJpdmVyRW50cnlQb2ludC5o?= Date: Thu, 25 Feb 2021 21:36:02 +0800 Message-ID: <005601d70b7b$2ed59070$8c80b150$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHiSYVVOUI7CVDe4Y3nL/+Dh8l6QwI0KJwpqkDBSPA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Ard: I think it is a code bug fix, because the module should use the one in M= dePkg instead of the one in StandaloneMmPkg. So, I am OK to merge it for th= is stable tag. Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Ard > Biesheuvel > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B42=E6=9C=8825=E6=97=A5= 16:08 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Michael Kubacki ; Liming Gao > (Byosoft address) > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Ard Biesheuvel ; > Sami Mujawar ; Jiewen Yao > ; Supreeth Venkatesh > ; Laszlo Ersek > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Rem= ove > StandaloneMmDriverEntryPoint.h >=20 > (+ Liming) >=20 > On Thu, 25 Feb 2021 at 04:33, wrote: > > > > From: Michael Kubacki > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3235 > > > > The library for this header initially resided in StandaloneMmPkg > > but moved to MdePkg and now this file is a duplicate of the header > > file in MdePkg. > > > > This change removes the header file from StandaloneMmPkg. More > > details regarding the history of the library transitioning from > > StandaloneMmPkg to MdePkg are below. > > > > The following commit removed the library from StandaloneMmPkg: > > d6253d2f9a33 ("StandaloneMmPkg: remove redundant > > StandaloneMmDriverEntryPoint driver", 2019-03-11) > > > > The following commits added the library class & instance to MdePkg: > > 7df4764e6a81a ("MdePkg: introduce standalone MM entry point > > library class", 2019-01-14) > > > > 5866d4992396 ("MdePkg: introduce standalone MM entry point > > library implementation", 2019-01-14) > > > > Cc: Ard Biesheuvel > > Cc: Sami Mujawar > > Cc: Jiewen Yao > > Cc: Supreeth Venkatesh > > Cc: Laszlo Ersek > > Signed-off-by: Michael Kubacki > > Acked-by: Ard Biesheuvel >=20 > Thanks Michael. >=20 > If Liming agrees, I'll merge this today. >=20 >=20 > > --- > > StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | > 142 -------------------- > > StandaloneMmPkg/StandaloneMmPkg.dec > | 3 - > > 2 files changed, 145 deletions(-) > > > > diff --git > a/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > b/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > > deleted file mode 100644 > > index b72b64704d16..000000000000 > > --- a/StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h > > +++ /dev/null > > @@ -1,142 +0,0 @@ > > -/** @file > > - Module entry point library for Standalone MM Drivers. > > - > > -Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved. > > -Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
> > - > > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#ifndef __MODULE_ENTRY_POINT_H__ > > -#define __MODULE_ENTRY_POINT_H__ > > - > > -/// > > -///Declare the PI Specification Revision that this driver requires to= execute > correctly. > > -/// > > -extern CONST UINT32 _gMmRevision; > > - > > -/** > > - The entry point of PE/COFF Image for a Standalone MM Driver. > > - > > - This function is the entry point for a Standalone MM Driver. > > - This function must call ProcessLibraryConstructorList() and > > - ProcessModuleEntryPointList(). > > - If the return status from ProcessModuleEntryPointList() > > - is an error status, then ProcessLibraryDestructorList() must be cal= led. > > - The return value from ProcessModuleEntryPointList() is returned. > > - If _gDriverUnloadImageCount is greater > > - than zero, then an unload handler must be registered for this image= and > > - the unload handler must invoke ProcessModuleUnloadList(). > > - If _gUefiDriverRevision is not zero and SystemTable->Hdr.Revision i= s > > - less than _gUefiDriverRevision, then return > EFI_INCOMPATIBLE_VERSION. > > - > > - @param ImageHandle The image handle of the Standalone MM > Driver. > > - @param SystemTable A pointer to the EFI System Table. > > - > > - @retval EFI_SUCCESS The Standalone MM Driver > exited normally. > > - @retval EFI_INCOMPATIBLE_VERSION _gUefiDriverRevision is > greater than > > - SystemTable->Hdr.Revision. > > - @retval Other Return value from > > - > ProcessModuleEntryPointList(). > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -_ModuleEntryPoint ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > > - ); > > - > > - > > -/** > > - Required by the EBC compiler and identical in functionality to > _ModuleEntryPoint(). > > - > > - This function is required to call _ModuleEntryPoint() passing in > ImageHandle, and SystemTable. > > - > > - @param ImageHandle The image handle of the Standalone MM > Driver. > > - @param SystemTable A pointer to the EFI System Table. > > - > > - @retval EFI_SUCCESS The Standalone MM Driver > exited normally. > > - @retval EFI_INCOMPATIBLE_VERSION _gUefiDriverRevision is > greater than > > - SystemTable->Hdr.Revision. > > - @retval Other Return value from > ProcessModuleEntryPointList(). > > -**/ > > -EFI_STATUS > > -EFIAPI > > -EfiMain ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > > - ); > > - > > -/** > > - Auto generated function that calls the library constructors for all= of the > module's > > - dependent libraries. > > - > > - This function must be called by _ModuleEntryPoint(). > > - This function calls the set of library constructors for the set of = library > instances > > - that a module depends on. This includes library instances that a > module depends on > > - directly and library instances that a module depends on indirectly > through other libraries. > > - This function is auto generated by build tools and those build tool= s are > responsible > > - for collecting the set of library instances, determine which ones h= ave > constructors, > > - and calling the library constructors in the proper order based upon= each > of the library > > - instances own dependencies. > > - > > - @param ImageHandle The image handle of the Standalone MM > Driver. > > - @param SystemTable A pointer to the EFI System Table. > > - > > -**/ > > -VOID > > -EFIAPI > > -ProcessLibraryConstructorList ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > > - ); > > - > > - > > -/** > > - Auto generated function that calls the library descructors for all = of the > module's > > - dependent libraries. > > - > > - This function may be called by _ModuleEntryPoint() or ExitDriver(). > > - This function calls the set of library destructors for the set of l= ibrary > instances > > - that a module depends on. This includes library instances that a mo= dule > depends on > > - directly and library instances that a module depends on indirectly > through other libraries. > > - This function is auto generated by build tools and those build tool= s are > responsible for > > - collecting the set of library instances, determine which ones have > destructors, and calling > > - the library destructors in the proper order based upon each of the = library > instances own dependencies. > > - > > - @param ImageHandle The image handle of the Standalone MM > Driver. > > - @param SystemTable A pointer to the EFI System Table. > > - > > -**/ > > -VOID > > -EFIAPI > > -ProcessLibraryDestructorList ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > > - ); > > - > > - > > -/** > > - Auto generated function that calls a set of module entry points. > > - > > - This function must be called by _ModuleEntryPoint(). > > - This function calls the set of module entry points. > > - This function is auto generated by build tools and those build tool= s are > responsible > > - for collecting the module entry points and calling them in a specif= ied > order. > > - > > - @param ImageHandle The image handle of the Standalone MM > Driver. > > - @param SystemTable A pointer to the EFI System Table. > > - > > - @retval EFI_SUCCESS The Standalone MMDriver executed > normally. > > - @retval !EFI_SUCCESS The Standalone MM Driver failed to execute > normally. > > -**/ > > -EFI_STATUS > > -EFIAPI > > -ProcessModuleEntryPointList ( > > - IN EFI_HANDLE ImageHandle, > > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > > - ); > > - > > -#endif > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dec > b/StandaloneMmPkg/StandaloneMmPkg.dec > > index 36de8d561bf3..0dfed4ee995a 100644 > > --- a/StandaloneMmPkg/StandaloneMmPkg.dec > > +++ b/StandaloneMmPkg/StandaloneMmPkg.dec > > @@ -25,9 +25,6 @@ [LibraryClasses] > > ## @libraryclass Defines a set of interfaces for the MM core > entrypoint. > > > StandaloneMmCoreEntryPoint|Include/Library/StandaloneMmCoreEntryPoin > t.h > > > > - ## @libraryclass Defines a set of interfaces for the MM driver > entrypoint. > > - > StandaloneMmDriverEntryPoint|Include/Library/StandaloneMmDriverEntryP > oint.h > > - > > ## @libraryclass Defines a set of interfaces that provides servic= es > for > > ## MM Memory Operation. > > MemLib|Include/Library/StandaloneMmMemLib.h > > -- > > 2.28.0.windows.1 > > >=20 >=20 >=20 >=20