From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.1442.1605574134204891098 for ; Mon, 16 Nov 2020 16:48:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 17 Nov 2020 08:48:51 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Ma, Maurice'" , "'You, Benjamin'" References: <1647D5DAE0E6DDAF.27572@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYyIDAvMV0gVWVmaVBheWxvYWRQa2c6IFJlbW92ZSBQRUkgcGhhc2UgZnJvbSBQYXlsb2Fk?= Date: Tue, 17 Nov 2020 08:48:52 +0800 Message-ID: <005801d6bc7b$6b90f670$42b2e350$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIZvME/nFQ4NtiAzi0MpmSgfQrWDgIOfxVuqTUHJvA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Guo: This is a feature. So, please submit BZ for it.=20 =20 And, the first version patch is sent before soft feature freeze, and got comments. Then, the second version patch is sent and got reviewed after soft featu= re freeze. Based on https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreeze,= =20 this patch can't catch this stable tag.=20 If you really want to catch this patch for this stable tag, please speci= fy your reason. I will collect the community feedback and decide whether delay this stab= le tag.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: bounce+27952+67620+4905953+8761045@groups.io > =B4=FA=B1=ED Guo Dong > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C217=C8=D5 5:59 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Dong, Guo = ; gaoliming > > =B3=AD=CB=CD: Ma, Maurice ; You, Benjamin > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI= phase > from Payload >=20 >=20 > Hi Liming, >=20 > This patch is sent before the soft freeze and passed review. > I would like to merge this patch into edk2-stable202011 tomorrow if ther= e is > no additional feedback. >=20 > And here is the PR and it passed all CI checks. > https://github.com/tianocore/edk2/pull/1127 >=20 > Thanks, > Guo >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Guo > Dong > > Sent: Sunday, November 15, 2020 5:35 PM > > To: devel@edk2.groups.io > > Cc: Ma, Maurice ; You, Benjamin > > > > Subject: [edk2-devel] [PATCH V2 0/1] UefiPayloadPkg: Remove PEI phase > from > > Payload > > > > Hi All, > > > > This patch removed UEFI payload PEI phase to make UEFI payload simple. > > It uses UefiPayloadEntry module to bridge bootloader and DXE phase. > > > > Original DSC files UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc > > are replaced by a single DSC UefiPayloadPkg.dsc. Pure IA32 support > > is replaced by Pure X64 support. IA32 Entry point with X64 DXE phase > > is still supported. > > > > Changes in V2: > > Addressed all the review comments from Maurice. > > Fixed debug msg in UefiPayloadEntry. > > Updated the Handoff HOB to DXE core to include Payload FV. > > Synced the GHCB changes from DxeIpl to UefiPayloadEntry. > > > > V1: > > It is not necessary to have a PEI phase in the UEFI payload since no > > specific PEI task is required. This patch adds a UefiPayloadEntry > > driver to get UEFI Payload required information from the bootloaders, > > convert them into a HOB list, load DXE core and transfer control to it= . > > > > Here is the change details: > > 1) Removed PEI phase, including Peicore, BlSupportPei, SecCore, etc. > > 2) Added UefiPayloadEntry driver. this is the only driver before DXE core. > > 3) Added Pure X64 support, dropped Pure IA32 (Could add later if required) > > 64bit payload with 32bit entry point is still supported. > > 4) Use one DSC file UefiPayloadPkg.dsc to support X64 and IA32X64 buil= d. > > Removed UefiPayloadIa32.dsc and UefiPayloadIa32X64.dsc > > > > Tested with SBL and coreboot on QEMU. > > > > Refs: https://github.com/tianocore/edk2/pull/1127 > > > > CC: maurice.ma@intel.com > > CC: benjamin.you@intel.com > > Signed-off-by: Guo Dong > > > > Guo Dong (1): > > UefiPayloadPkg: Remove PEI phase from Payload > > > > UefiPayloadPkg/BlSupportPei/BlSupportPei.h | 39 - > > UefiPayloadPkg/BlSupportPei/BlSupportPei.inf | 73 -- > > UefiPayloadPkg/BuildAndIntegrationInstructions.txt | 32 +- > > UefiPayloadPkg/Include/Library/BlParseLib.h | 4 +- > > UefiPayloadPkg/Library/HobLib/Hob.c | 706 > ++++++++++++++++ > > UefiPayloadPkg/Library/HobLib/HobLib.inf | 39 + > > UefiPayloadPkg/SecCore/FindPeiCore.c | 193 ----- > > UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm | 78 -- > > UefiPayloadPkg/SecCore/Ia32/Stack.nasm | 72 -- > > UefiPayloadPkg/SecCore/SecCore.inf | 58 -- > > UefiPayloadPkg/SecCore/SecMain.c | 288 ------- > > UefiPayloadPkg/SecCore/SecMain.h | 131 --- > > UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c | 365 ++++++++ > > .../UefiPayloadEntry/Ia32/IdtVectorAsm.nasm | 71 ++ > > UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm | 46 + > > UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c | 307 +++++++ > > UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c | 201 +++++ > > .../UefiPayloadEntry.c} | 451 ++++------ > > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h | 134 +++ > > .../UefiPayloadEntry/UefiPayloadEntry.inf | 93 ++ > > UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c | 107 +++ > > UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm | 47 ++ > > .../UefiPayloadEntry/X64/VirtualMemory.c | 939 > > +++++++++++++++++++++ > > .../UefiPayloadEntry/X64/VirtualMemory.h | 330 ++++++++ > > UefiPayloadPkg/UefiPayloadPkg.dec | 5 +- > > ...efiPayloadPkgIa32X64.dsc =3D> UefiPayloadPkg.dsc} | 57 +- > > UefiPayloadPkg/UefiPayloadPkg.fdf | 32 +- > > UefiPayloadPkg/UefiPayloadPkgIa32.dsc | 585 > ------------- > > 28 files changed, 3576 insertions(+), 1907 deletions(-) > > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.h > > delete mode 100644 UefiPayloadPkg/BlSupportPei/BlSupportPei.inf > > create mode 100644 UefiPayloadPkg/Library/HobLib/Hob.c > > create mode 100644 UefiPayloadPkg/Library/HobLib/HobLib.inf > > delete mode 100644 UefiPayloadPkg/SecCore/FindPeiCore.c > > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm > > delete mode 100644 UefiPayloadPkg/SecCore/Ia32/Stack.nasm > > delete mode 100644 UefiPayloadPkg/SecCore/SecCore.inf > > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.c > > delete mode 100644 UefiPayloadPkg/SecCore/SecMain.h > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/Ia32/DxeLoadFunc.c > > create mode 100644 > > UefiPayloadPkg/UefiPayloadEntry/Ia32/IdtVectorAsm.nasm > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/Ia32/SecEntry.nasm > > create mode 100644 UefiPayloadPkg/UefiPayloadEntry/LoadDxeCore.c > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/MemoryAllocation.c > > rename UefiPayloadPkg/{BlSupportPei/BlSupportPei.c =3D> > > UefiPayloadEntry/UefiPayloadEntry.c} (52%) > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.inf > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/X64/DxeLoadFunc.c > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/X64/SecEntry.nasm > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.c > > create mode 100644 > UefiPayloadPkg/UefiPayloadEntry/X64/VirtualMemory.h > > rename UefiPayloadPkg/{UefiPayloadPkgIa32X64.dsc =3D> > UefiPayloadPkg.dsc} > > (90%) > > delete mode 100644 UefiPayloadPkg/UefiPayloadPkgIa32.dsc > > > > -- > > 2.16.2.windows.1 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20