From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
<devel@edk2.groups.io>
Cc: "'Zhiguang Liu'" <zhiguang.liu@intel.com>,
"'Jiewen Yao'" <jiewen.yao@intel.com>,
"'Jian J Wang'" <jian.j.wang@intel.com>,
"'Xiaoyu Lu'" <xiaoyux.lu@intel.com>,
"'Guomin Jiang'" <guomin.jiang@intel.com>
Subject: 回复: [Patch 0/3] Remove duplicate type declarations in MdePkg and CryptoPkg
Date: Wed, 31 Mar 2021 09:19:45 +0800 [thread overview]
Message-ID: <005a01d725cb$ef8cf460$cea6dd20$@byosoft.com.cn> (raw)
In-Reply-To: <20210330230405.1162-1-michael.d.kinney@intel.com>
Mike:
The change is good. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Besides, which compiler option can detect this warning?
Thanks
Liming
> -----邮件原件-----
> 发件人: Michael D Kinney <michael.d.kinney@intel.com>
> 发送时间: 2021年3月31日 7:04
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Jian J Wang
> <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyux.lu@intel.com>; Guomin Jiang
> <guomin.jiang@intel.com>
> 主题: [Patch 0/3] Remove duplicate type declarations in MdePkg and
> CryptoPkg
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3287
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3286
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3285
>
> Remove duplicate declarations of the following types that may
> generate compiler warnings or errors:
> * EFI_HII_POPUP_PROTOCOL
> * EFI_RESET_NOTIFICATION_PROTOCOL
> * EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509
>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>
> Michael D Kinney (3):
> MdePkg/Include/Protocol: EFI_HII POPUP_PROTOCOL duplicate declaration
> MdePkg/Include/Protocol: EFI_RESET_NOTIFICATION_PROTOCOL duplicate
> CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type
>
> CryptoPkg/Private/Protocol/Crypto.h | 28 +--------------------
> MdePkg/Include/Protocol/HiiPopup.h | 6 ++---
> MdePkg/Include/Protocol/ResetNotification.h | 6 ++---
> 3 files changed, 7 insertions(+), 33 deletions(-)
>
> --
> 2.31.1.windows.1
next prev parent reply other threads:[~2021-03-31 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:04 [Patch 0/3] Remove duplicate type declarations in MdePkg and CryptoPkg Michael D Kinney
2021-03-30 23:04 ` [Patch 1/3] MdePkg/Include/Protocol: EFI_HII POPUP_PROTOCOL duplicate declaration Michael D Kinney
2021-03-30 23:04 ` [Patch 2/3] MdePkg/Include/Protocol: EFI_RESET_NOTIFICATION_PROTOCOL duplicate Michael D Kinney
2021-03-30 23:04 ` [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type Michael D Kinney
2021-03-30 23:14 ` Yao, Jiewen
2021-03-31 1:19 ` gaoliming [this message]
2021-03-31 2:04 ` [Patch 0/3] Remove duplicate type declarations in MdePkg and CryptoPkg Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005a01d725cb$ef8cf460$cea6dd20$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox