From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web12.698.1617153587844517492
 for <devel@edk2.groups.io>;
 Tue, 30 Mar 2021 18:19:48 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <devel@edk2.groups.io>; Wed, 31 Mar 2021 09:19:42 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Michael D Kinney'" <michael.d.kinney@intel.com>,
	<devel@edk2.groups.io>
Cc: "'Zhiguang Liu'" <zhiguang.liu@intel.com>,
	"'Jiewen Yao'" <jiewen.yao@intel.com>,
	"'Jian J Wang'" <jian.j.wang@intel.com>,
	"'Xiaoyu Lu'" <xiaoyux.lu@intel.com>,
	"'Guomin Jiang'" <guomin.jiang@intel.com>
References: <20210330230405.1162-1-michael.d.kinney@intel.com>
In-Reply-To: <20210330230405.1162-1-michael.d.kinney@intel.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUGF0Y2ggMC8zXSBSZW1vdmUgZHVwbGljYXRlIHR5cGUgZGVjbGFyYXRpb25zIGluIE1kZVBrZyBhbmQgQ3J5cHRvUGtn?=
Date: Wed, 31 Mar 2021 09:19:45 +0800
Message-ID: <005a01d725cb$ef8cf460$cea6dd20$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGP9VIaCAjSHmP0bV9gY0dPqLhFy6srrPzw
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Mike:=20
 The change is good. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 Besides, which compiler option can detect this warning?=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Michael D Kinney <michael.d.kinney@intel.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA3=D4=C231=C8=D5 7:04
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu
> <zhiguang.liu@intel.com>; Jiewen Yao <jiewen.yao@intel.com>; Jian J =
Wang
> <jian.j.wang@intel.com>; Xiaoyu Lu <xiaoyux.lu@intel.com>; Guomin =
Jiang
> <guomin.jiang@intel.com>
> =D6=F7=CC=E2: [Patch 0/3] Remove duplicate type declarations in MdePkg =
and
> CryptoPkg
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3287
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3286
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3285
>=20
> Remove duplicate declarations of the following types that may
> generate compiler warnings or errors:
> * EFI_HII_POPUP_PROTOCOL
> * EFI_RESET_NOTIFICATION_PROTOCOL
> * EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509
>=20
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Guomin Jiang <guomin.jiang@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>=20
> Michael D Kinney (3):
>   MdePkg/Include/Protocol: EFI_HII POPUP_PROTOCOL duplicate =
declaration
>   MdePkg/Include/Protocol: EFI_RESET_NOTIFICATION_PROTOCOL duplicate
>   CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate function type
>=20
>  CryptoPkg/Private/Protocol/Crypto.h         | 28 =
+--------------------
>  MdePkg/Include/Protocol/HiiPopup.h          |  6 ++---
>  MdePkg/Include/Protocol/ResetNotification.h |  6 ++---
>  3 files changed, 7 insertions(+), 33 deletions(-)
>=20
> --
> 2.31.1.windows.1