public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>, "Ni, Ray" <ray.ni@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: Reviewer for the possible duplicated CSM components in OvmfPkg
Date: Sun, 19 May 2019 22:40:01 -0700	[thread overview]
Message-ID: <005afbebcbda0108aa69c9c41f2e3352a63cacbf.camel@infradead.org> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8D4E38@SHSMSX104.ccr.corp.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]

On Mon, 2019-05-20 at 05:32 +0000, Wu, Hao A wrote:
> My thought on this is the CSM components in the framework packages are
> stable for a period of time. So my guess is that the issue is not directly
> related to these components.

Right. I went back to a SeaBIOS and OVMF from the time I last had this
working, and then I tripped over lots of toolchain issues. I ended up
having to git-bisect for various different issues at once.

ISTR I eventually got to the point where I could build the "last known
good" versions with the minimal set of fixes... and still they didn't
actually work. I need to revisit that.

> Also, if it turns out that there are some missing components left
> uncopied, we are able to get them back (from the repo history) and put
> them into OvmfPkg then. I can help on that.
> 
> Does this sound good to you?

That would be great. Thanks. I don't think there's anything really
*missing*. We do get into SeaBIOS as a CSM but SeaBIOS itself then
crashes somehow, in a hard-to-debug way.

In fact I did all this before we had proper SMM support in OVMF and
SeaBIOS, and I should probably revisit it completely. Originally I took
the simple approach where SeaBIOS takes over the hardware completely,
and returning from CSM to UEFI on a boot failure was not really going
to work. But if I move to what I understand is the "normal" CSM model
of invoking UEFI services through SMM instead of taking full control,
things might be a little saner.


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5174 bytes --]

  reply	other threads:[~2019-05-20  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  5:08 Reviewer for the possible duplicated CSM components in OvmfPkg Wu, Hao A
2019-05-20  5:11 ` David Woodhouse
2019-05-20  5:32   ` Wu, Hao A
2019-05-20  5:40     ` David Woodhouse [this message]
2019-05-20  5:59       ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=005afbebcbda0108aa69c9c41f2e3352a63cacbf.camel@infradead.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox