public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'manickavasakam karpagavinayagam'" <manickavasakamk@ami.com>,
	<devel@edk2.groups.io>
Cc: <isaac.w.oram@intel.com>, <nathaniel.l.desimone@intel.com>,
	<Felixp@ami.com>, <Harikrishnad@ami.com>, <manishj@ami.com>,
	<zacharyb@ami.com>
Subject: 回复: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error
Date: Thu, 17 Jun 2021 10:50:15 +0800	[thread overview]
Message-ID: <005e01d76323$801f9e80$805edb80$@byosoft.com.cn> (raw)
In-Reply-To: <20210611215004.8873-1-manickavasakamk@ami.com>



> -----邮件原件-----
> 发件人: manickavasakam karpagavinayagam <manickavasakamk@ami.com>
> 发送时间: 2021年6月12日 5:50
> 收件人: devel@edk2.groups.io
> 抄送: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com;
> Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com;
> zacharyb@ami.com; manickavasakamk@ami.com;
> gaoliming@byosoft.com.cn
> 主题: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions
> to resolve the IPMI build error
> 
> Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> 
> MdePkg : Rename IPMI Macro and Structure Defintions
> 
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
> ---
> 
> Notes:
>     V1 :
>     - Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
>     - EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
>     - IPMI_BMC_IN_FORCED_UPDATE_MODE
> 
>  0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch | 61
> ++++++++++++++++++++
>  MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h              |
> 4 ++
>  MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h             |
> 18 ++++++
>  3 files changed, 83 insertions(+)
> 
> diff --git
> a/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
> b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
> new file mode 100644
> index 0000000000..16d149e2d8
> --- /dev/null
> +++ b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
> @@ -0,0 +1,61 @@
> +From c5e221cfe5d815883f39b71667b6e8f644a27390 Mon Sep 17 00:00:00
> 2001
> +From: manickavasakam karpagavinayagam <manickavasakamk@ami.com>
> +Date: Thu, 10 Jun 2021 14:59:22 -0400
> +Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions
> to resolve
> + the IPMI build error
> +
> +Build error reported for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> +EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> +EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORC
> ED_UPDATE_MODE
> +when using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
> +---
> + MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h  |  4 ++++
> + MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19
> +++++++++++++++++++
> + 2 files changed, 23 insertions(+)
> +
> +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +index 79db55523d..d7cdd3a865 100644
> +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +@@ -186,6 +186,10 @@ typedef struct {
> +   UINT8                                  ParameterData[0];
> + } IPMI_SET_BOOT_OPTIONS_REQUEST;
> +
> ++typedef struct {
> ++  UINT8   CompletionCode:8;
> ++} IPMI_SET_BOOT_OPTIONS_RESPONSE;
> ++
> + //
> + //  Definitions for Get System Boot options command
> + //
> +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +index 2d892dbd5a..1c692cc792 100644
> +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +@@ -17,4 +17,23 @@
> + // All Firmware commands and their structure definitions to follow here
> + //
> +
>
++/*------------------------------------------------------------------------
---------------
> -
> ++    Definitions for Get BMC Execution Context
>
++--------------------------------------------------------------------------
--------------*
> /
> ++#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT  0x23
> ++
> ++//
> ++//  Constants and Structure definitions for "Get Device ID" command to
> follow here
> ++//
> ++typedef struct {
> ++  UINT8   CurrentExecutionContext;
> ++  UINT8   PartitionPointer;
> ++} EFI_IPMI_MSG_GET_BMC_EXEC_RSP;
> ++
> ++//
> ++// Current Execution Context responses
> ++//
> ++#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME        0x10
> ++#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE  0x11
> ++
> + #endif
> +--
> +2.25.0.windows.1
> +
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
>    UINT8                                  ParameterData[0];
> 
>  } IPMI_SET_BOOT_OPTIONS_REQUEST;
> 
> 
> 
> +typedef struct {
> 
> +  UINT8   CompletionCode:8;
> 
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
> 
> +
> 
>  //
> 
>  //  Definitions for Get System Boot options command
> 
>  //
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..c4cbe2349b 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,22 @@
>  // All Firmware commands and their structure definitions to follow here
> 
>  //
> 
> 
> 
> +//
----------------------------------------------------------------------------
------------
> 
> +//    Definitions for Get BMC Execution Context
> 
> +//
----------------------------------------------------------------------------
------------
> 
> +#define IPMI_GET_BMC_EXECUTION_CONTEXT  0x23
> 
> +
> 
> +//
> 
> +//  Constants and Structure definitions for "Get Device ID" command to
> follow here
> 
> +//
> 
> +typedef struct {
> 
> +  UINT8   CurrentExecutionContext;
> 
> +  UINT8   PartitionPointer;
> 
> +} IPMI_MSG_GET_BMC_EXEC_RSP;
> 
> +
> 
> +//
> 
> +// Current Execution Context responses
> 
> +//
> 
> +#define IPMI_BMC_IN_FORCED_UPDATE_MODE  0x11
> 
> +
> 
>  #endif
> 
> --
> 2.25.0.windows.1
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI).  This communication is intended
> to be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.



  parent reply	other threads:[~2021-06-17  2:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210611215004.8873-1-manickavasakamk@ami.com>
2021-06-11 22:15 ` [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Oram, Isaac W
2021-06-17  2:50 ` gaoliming [this message]
2021-06-17  2:51 ` 回复: " gaoliming
2021-06-17 17:42   ` [EXTERNAL] " manickavasakam karpagavinayagam
2021-06-18  1:05     ` 回复: " gaoliming
2021-06-18 15:39       ` manickavasakam karpagavinayagam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005e01d76323$801f9e80$805edb80$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox