From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.2664.1623898220930134369 for ; Wed, 16 Jun 2021 19:50:21 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 17 Jun 2021 10:50:14 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'manickavasakam karpagavinayagam'" , Cc: , , , , , References: <20210611215004.8873-1-manickavasakamk@ami.com> In-Reply-To: <20210611215004.8873-1-manickavasakamk@ami.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMl1bUEFUQ0ggVjFdIE1kZVBrZyA6IEFkZCBJUE1JIE1hY3JvIGFuZCBTdHJ1Y3R1cmUgRGVmaW50aW9ucyB0byByZXNvbHZlIHRoZSBJUE1JIGJ1aWxkIGVycm9y?= Date: Thu, 17 Jun 2021 10:50:15 +0800 Message-ID: <005e01d76323$801f9e80$805edb80$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQK59nhV0Ohq4KM3aYmee3SBoO4P/qlSWf9g Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: manickavasakam karpagavinayagam = > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA6=D4=C212=C8=D5 5:50 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; > Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; > zacharyb@ami.com; manickavasakamk@ami.com; > gaoliming@byosoft.com.cn > =D6=F7=CC=E2: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure = Defintions > to resolve the IPMI build error >=20 > Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > D_UPDATE_MODE > when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg >=20 > MdePkg : Rename IPMI Macro and Structure Defintions >=20 > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE > --- >=20 > Notes: > V1 : > - Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > - EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > - IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch | 61 > ++++++++++++++++++++ > MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | > 4 ++ > MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | > 18 ++++++ > 3 files changed, 83 insertions(+) >=20 > diff --git > a/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > new file mode 100644 > index 0000000000..16d149e2d8 > --- /dev/null > +++ b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch > @@ -0,0 +1,61 @@ > +From c5e221cfe5d815883f39b71667b6e8f644a27390 Mon Sep 17 00:00:00 > 2001 > +From: manickavasakam karpagavinayagam > +Date: Thu, 10 Jun 2021 14:59:22 -0400 > +Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure = Defintions > to resolve > + the IPMI build error > + > +Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > +EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > +EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORC > ED_UPDATE_MODE > +when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg > +--- > + MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > + MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19 > +++++++++++++++++++ > + 2 files changed, 23 insertions(+) > + > +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +index 79db55523d..d7cdd3a865 100644 > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +@@ -186,6 +186,10 @@ typedef struct { > + UINT8 ParameterData[0]; > + } IPMI_SET_BOOT_OPTIONS_REQUEST; > + > ++typedef struct { > ++ UINT8 CompletionCode:8; > ++} IPMI_SET_BOOT_OPTIONS_RESPONSE; > ++ > + // > + // Definitions for Get System Boot options command > + // > +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +index 2d892dbd5a..1c692cc792 100644 > +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +@@ -17,4 +17,23 @@ > + // All Firmware commands and their structure definitions to follow = here > + // > + > ++/*---------------------------------------------------------------------= --- --------------- > - > ++ Definitions for Get BMC Execution Context > ++-----------------------------------------------------------------------= --- --------------* > / > ++#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 > ++ > ++// > ++// Constants and Structure definitions for "Get Device ID" command = to > follow here > ++// > ++typedef struct { > ++ UINT8 CurrentExecutionContext; > ++ UINT8 PartitionPointer; > ++} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; > ++ > ++// > ++// Current Execution Context responses > ++// > ++#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 > ++#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 > ++ > + #endif > +-- > +2.25.0.windows.1 > + > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > index 79db55523d..d7cdd3a865 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > @@ -186,6 +186,10 @@ typedef struct { > UINT8 ParameterData[0]; >=20 > } IPMI_SET_BOOT_OPTIONS_REQUEST; >=20 >=20 >=20 > +typedef struct { >=20 > + UINT8 CompletionCode:8; >=20 > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; >=20 > + >=20 > // >=20 > // Definitions for Get System Boot options command >=20 > // >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > index 2d892dbd5a..c4cbe2349b 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > @@ -17,4 +17,22 @@ > // All Firmware commands and their structure definitions to follow = here >=20 > // >=20 >=20 >=20 > +// -------------------------------------------------------------------------= --- ------------ >=20 > +// Definitions for Get BMC Execution Context >=20 > +// -------------------------------------------------------------------------= --- ------------ >=20 > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > + >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command = to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > #endif >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is = intended > to be read only by the individual or entity to whom it is addressed or = by their > designee. If the reader of this message is not the intended recipient, = you are > on notice that any distribution of this message, in any form, is = strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of = the > transmission.