From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.132.1625016151661567752 for ; Tue, 29 Jun 2021 18:22:32 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 30 Jun 2021 09:22:23 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'manickavasakam karpagavinayagam'" , , , , , , References: <20210618153734.11983-1-manickavasakamk@ami.com> <008101d7663f$a0a85c40$e1f914c0$@byosoft.com.cn> <168B5E8EE0C4DCE3.15098@groups.io> In-Reply-To: <168B5E8EE0C4DCE3.15098@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbZWRrMl1bUEFUQ0ggVjNdIE1kZVBrZyA6IEFkZCBJUE1JIE1hY3JvIGFuZCBTdHJ1Y3R1cmUgRGVmaW50aW9ucyB0byByZXNvbHZlIGJ1aWxkIGVycm9ycw==?= Date: Wed, 30 Jun 2021 09:22:23 +0800 Message-ID: <005e01d76d4e$61923f10$24b6bd30$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKnQ/fofiCCKF3z1d0NqyaDwGwf0AHmU43KAORKmXMCYRnInKlitwIA Content-Type: multipart/alternative; boundary="----=_NextPart_000_005F_01D76D91.6FB6B790" Content-Language: zh-cn ------=_NextPart_000_005F_01D76D91.6FB6B790 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable If no other comment, I will create PR to merge this patch.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8824=E6=97=A5 8= :54 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; lateefcs@gmail.com =E6=8A=84=E9=80=81: 'manickavasakam karpagavinayagam' ; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp@ami.c= om; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: [= edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve= build errors =20 AbduL: This is same to the definition of UINT8 CompletionCode without bitfield. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8= =A1=A8 AbduL Lateef =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8823=E6=97=A5 1= 9:43 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; gaoliming@byosoft.com.cn =20 =E6=8A=84=E9=80=81: manickavasakam karpagavinayagam >; isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com ; Felixp@ami.com ; Harikrishnad@am= i.com ; manishj@ami.com ; zacharyb@ami.com =20 =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] = MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors =20 whats the use of bitfield:8 for UINT8 variable type? +typedef struct { + UINT8 CompletionCode:8; +} IPMI_SET_BOOT_OPTIONS_RESPONSE; =20 Thanks AbduL =20 On Mon, Jun 21, 2021 at 7:19 AM gaoliming > wrote: Thanks for you update.=20 Reviewed-by: Liming Gao > Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97=A5= 23:38 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =20 > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com = ; > Felixp@ami.com ; Harikrishnad@ami.com ; manishj@ami.com ; > zacharyb@ami.com ; manickavasakamk@ami.com ; > gaoliming@byosoft.com.cn =20 > =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structu= re Defintions > to resolve build errors >=20 > Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > D_UPDATE_MODE > when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg >=20 > MdePkg : Rename IPMI Macro and Structure Defintions >=20 > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > Notes: > V1 : > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > V2: >=20 > Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch >=20 > V3: >=20 > Add Signed-off-by information >=20 > Signed-off-by: Manickavasakam Karpagavinayagam > > > --- > .../IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > .../IndustryStandard/IpmiNetFnFirmware.h | 18 > ++++++++++++++++++ > 2 files changed, 22 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > index 79db55523d..d7cdd3a865 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > @@ -186,6 +186,10 @@ typedef struct { > UINT8 ParameterData[0]; >=20 > } IPMI_SET_BOOT_OPTIONS_REQUEST; >=20 >=20 >=20 > +typedef struct { >=20 > + UINT8 CompletionCode:8; >=20 > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; >=20 > + >=20 > // >=20 > // Definitions for Get System Boot options command >=20 > // >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > index 2d892dbd5a..c4cbe2349b 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > @@ -17,4 +17,22 @@ > // All Firmware commands and their structure definitions to follow here >=20 > // >=20 >=20 >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +// Definitions for Get BMC Execution Context >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > + >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > #endif >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. =20 --=20 Thanks and Regards Abdul Lateef Attar Bangalore ------=_NextPart_000_005F_01D76D91.6FB6B790 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

If no other comment, I will create PR to merge this pa= tch.

 <= /p>

Thanks

= Liming

=E5=8F=91=E4=BB=B6= = =E4=BA=BA: devel@edk2.groups.io <= ;devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 gaoliming
=E5=8F= = =91=E9=80=81=E6=97=B6=E9=97=B4: 202= 1=E5= = =B9=B46=E6=9C=8824=E6= =97=A5 8:54
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; latee= fcs@gmail.com
=E6=8A=84=E9=80=81: 'manickavasakam karpagavinayagam' <manickavasakamk@= ami.com>; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp= @ami.com; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com
=E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E= =E5=A4=8D: [edk2][PATCH V3] MdePkg : Add IPMI Macro and= Structure Defintions to resolve build errors

<= /div>

 =

AbduL:

 This is same to the definition of UINT8 CompletionCode without = bitfield.

 

Thanks

Liming

=E5= =8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 = AbduL Lateef
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C= =8823=E6=97=A5 19:43
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io= ; gaoliming@byosoft.com.cn<= br>=E6=8A=84=E9=80=81: manickavasakam karpagavinayagam <manickavasakamk@ami.com>; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp@ami.com; Harikr= ishnad@ami.com; manishj@ami.com;= zacharyb@ami.com
=E4= =B8=BB=E9=A2=98: Re: [edk= 2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] Mde= Pkg : Add IPMI Macro and Structure Defintions to resolve build errors<= /o:p>

=  

wh= ats the use of bitfield:8 for UINT8 variable type?

+typedef struct {
+ UINT8 = CompletionCode:8;
+} IPMI_SET_BOOT_OPTIONS_RESPONSE;

 

Thanks

=

AbduL

 

On Mon, Jun 21, 2021 at 7:19 AM gaoliming <gaoliming@byosoft.com.cn> wrote:

Thanks for you update.

Reviewed-by: Liming Gao= <gaolimin= g@byosoft.com.cn>

Thanks
Liming
> -----=E9=82= = =AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5= =8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayag= am <manicka= vasakamk@ami.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97= =B4: 2021=E5=B9=B46=E6= = =9C=8818=E6=97=A5 23:38
&g= t; =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> <= /span>=E6=8A=84=E9=80=81: isaac.w.oram@intel.com; nathaniel.l.desimone@int= el.com;
> Fel= ixp@ami.com; = Harikrishnad@ami.com; manishj@ami.com;
> zacharyb@ami.com; manickavasakamk@ami.com;
> gaoliming@byosoft.com.cn> =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePk= g : Add IPMI Macro and Structure Defintions
> to resolve build errors=
>
> Build error reported for missing structures
> IPMI_= SET_BOOT_OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
>= ; macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN= _FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when = using
> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeature= Pkg
>
> MdePkg : Rename IPMI Macro and Structure Defintions>
> Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMW= ARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MOD= E to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
&= gt; IPMI_BMC_IN_FORCED_UPDATE_MODE
>
> Notes:
> V1 :
= > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BM= C_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
&g= t; IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_B= MC_IN_FORCED_UPDATE_MODE
>
> V2:
>
> Remove 0001-= MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch
>
>= V3:
>
> Add Signed-off-by information
>
> Signed= -off-by: Manickavasakam Karpagavinayagam
> <manickavasakamk@ami.com>
&= gt; ---
>  .../IndustryStandard/IpmiNetFnChassis.h    =     |  4 ++++
>  .../IndustryStandard/IpmiNetFnFi= rmware.h       | 18
> ++++++++++++++++++
>&= nbsp; 2 files changed, 22 insertions(+)
>
> diff --git a/MdePk= g/Include/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/Indu= stryStandard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644=
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> += ++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 += 186,10 @@ typedef struct {
>    UINT8      &= nbsp;                    =       ParameterData[0];
>
>  } IPMI_SET_B= OOT_OPTIONS_REQUEST;
>
>
>
> +typedef struct {>
> +  UINT8   CompletionCode:8;
>
>= ; +} IPMI_SET_BOOT_OPTIONS_RESPONSE;
>
> +
>
>&nb= sp; //
>
>  //  Definitions for Get System Boot opti= ons command
>
>  //
>
> diff --git a/MdePkg/= Include/IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/Indus= tryStandard/IpmiNetFnFirmware.h
> index 2d892dbd5a..c4cbe2349b 100644=
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> = +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 = +17,22 @@
>  // All Firmware commands and their structure defini= tions to follow here
>
>  //
>
>
> > +//
-------------------------------------------------------------= ---------------
------------
>
> +//    Definitio= ns for Get BMC Execution Context
>
> +//
------------------= ----------------------------------------------------------
------------<= br>>
> +#define IPMI_GET_BMC_EXECUTION_CONTEXT  0x23
>=
> +
>
> +//
>
> +//  Constants and S= tructure definitions for "Get Device ID" command to
> follo= w here
>
> +//
>
> +typedef struct {
>
= > +  UINT8   CurrentExecutionContext;
>
> +&= nbsp; UINT8   PartitionPointer;
>
> +} IPMI_MSG_GET_= BMC_EXEC_RSP;
>
> +
>
> +//
>
> +// = Current Execution Context responses
>
> +//
>
> += #define IPMI_BMC_IN_FORCED_UPDATE_MODE  0x11
>
> +
>= ;
>  #endif
>
> --
> 2.25.0.windows.1
>= ;
>
> Please consider the environment before printing this em= ail.
>
> The information contained in this message may be conf= idential and
> proprietary to American Megatrends (AMI).  This c= ommunication is intended
> to be read only by the individual or entit= y to whom it is addressed or by
their
> designee. If the reader of= this message is not the intended recipient, you
are
> on notice t= hat any distribution of this message, in any form, is strictly
> proh= ibited.  Please promptly notify the sender by reply e-mail or by
&g= t; telephone at 770-246-8600, and then delete or destroy all copies of the<= br>> transmission.






 

--

Thanks and Regards
= Abdul Lateef Attar
Bangalore

------=_NextPart_000_005F_01D76D91.6FB6B790--