From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.3355.1633656364224717903 for ; Thu, 07 Oct 2021 18:26:05 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 08 Oct 2021 09:25:53 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: , , , , , , References: <20211006101154.20589-1-christopher.jones@arm.com> In-Reply-To: <20211006101154.20589-1-christopher.jones@arm.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gTWRlUGtnOiBGaXggQUNQSSBtZW1vcnkgYWdncmVnYXRvci9kZXZpY2UgdHlwZSBtaXNtYXRjaA==?= Date: Fri, 8 Oct 2021 09:25:54 +0800 Message-ID: <005e01d7bbe3$70b63a80$5222af80$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHtEPFXU7b29eDIWS+m4pOB9DaWvqudpJtA Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Jones:=20 Do you know what impact will be introduced by this change?=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Chris Jones > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C26=C8=D5 18:12 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; > zhiguang.liu@intel.com; Sami.Mujawar@arm.com; Ben.Adderson@arm.com; > Akanksha.Jain2@arm.com; Matteo.Carlini@arm.com; nd@arm.com > =D6=F7=CC=E2: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory > aggregator/device type mismatch >=20 > Bugzilla: 3578 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3579) >=20 > Since the Common Memory Device (formerly Memory Aggregator Device) > was > introduced in ACPI 5.0, the edk2 type values have not matched the > values defined in the ACPI specification. >=20 > Fix this discrepancy by aligning the code to match the specification. >=20 > Signed-off-by: Chris Jones > --- > MdePkg/Include/IndustryStandard/Acpi50.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi51.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi62.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi63.h | 6 +++--- > MdePkg/Include/IndustryStandard/Acpi64.h | 6 +++--- > 7 files changed, 21 insertions(+), 21 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h > b/MdePkg/Include/IndustryStandard/Acpi50.h > index > 31a47e6a2c4276d5b1ad7b834af84844090b64c5..83d787c7650cf649fe3d2e1 > 2e7983bae86a2a114 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > @@ -996,9 +996,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h > b/MdePkg/Include/IndustryStandard/Acpi51.h > index > fc28ffa18fc6a22e52fda88fade6ad80b2817cc3..5fbf7c99f1f7d6ca9109f198bd > 3f25f12bd47961 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > @@ -951,9 +951,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h > b/MdePkg/Include/IndustryStandard/Acpi60.h > index > 5dcd73b6f1ec4bccc7fdae7d56c2963ab58764f9..eba4248e1d5733d21973f0d > ac2286e02238a0aae 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > @@ -966,9 +966,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h > b/MdePkg/Include/IndustryStandard/Acpi61.h > index > 8626833a794dfb4a6f19d459d5214c6caefdbbee..7a776020baa8f3ee7b6f05fe > e336225ab6589ce0 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > @@ -966,9 +966,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h > b/MdePkg/Include/IndustryStandard/Acpi62.h > index > 1b2704e98e3703a4405075247432ec842e45021b..33a0a0f21959df8b64803e > 972ab19f0c0ab1619e 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > @@ -1078,9 +1078,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h > b/MdePkg/Include/IndustryStandard/Acpi63.h > index > b281b30155e90eba5169dc39bde9a3379e3b7005..3b1426af27ea4ebada1a1 > 2e99ce958bb288ad931 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > @@ -1040,9 +1040,9 @@ typedef struct { > /// > /// Memory Aggregator Device Type > /// > -#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x2 > -#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x3 > +#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > ONTROLLER 0x1 > +#define > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > 0x2 >=20 > /// > /// Socket Memory Aggregator Device Structure. > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index > 3a91302f8c0e71d4951d27aac35322073219c836..8346d83f1249045497b602 > 907b94fbb2b495cd56 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -1075,9 +1075,9 @@ typedef struct { > /// > /// Memory Device Type. > /// > -#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_SOCKET > 0x1 > -#define > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_MEMORY_CONTROLLER > 0x2 > -#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_DIMM > 0x3 > +#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_SOCKET > 0x0 > +#define > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_MEMORY_CONTROLLER > 0x1 > +#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_DIMM > 0x2 > #define > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_VENDOR_SPECIFIC_TYPE > 0xFF >=20 > /// > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >=20 >=20 >=20 >=20 >=20