* [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
@ 2020-09-02 8:38 Zhang, Shenglei
2020-09-02 9:05 ` 回复: " gaoliming
[not found] ` <1630EC2C35B89AD7.28345@groups.io>
0 siblings, 2 replies; 6+ messages in thread
From: Zhang, Shenglei @ 2020-09-02 8:38 UTC (permalink / raw)
To: devel; +Cc: Sean Brogan, Bret Barkelew, Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
As the false positive issue whose error code is 10014 has been
fixed, we need to re-enable it on open CI.
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.pytool/Plugin/EccCheck/EccCheck.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py
index 3eaad0bf5623..eee1ff7a77b5 100644
--- a/.pytool/Plugin/EccCheck/EccCheck.py
+++ b/.pytool/Plugin/EccCheck/EccCheck.py
@@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
"10011",
"10012",
"10013",
- "10014", #need to be removed after BZ2904 is fixed
"10015",
"10016",
"10017",
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
2020-09-02 8:38 [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI Zhang, Shenglei
@ 2020-09-02 9:05 ` gaoliming
[not found] ` <1630EC2C35B89AD7.28345@groups.io>
1 sibling, 0 replies; 6+ messages in thread
From: gaoliming @ 2020-09-02 9:05 UTC (permalink / raw)
To: 'Shenglei Zhang', devel
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: Shenglei Zhang <shenglei.zhang@intel.com>
> 发送时间: 2020年9月2日 16:38
> 收件人: devel@edk2.groups.io
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
CI
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> As the false positive issue whose error code is 10014 has been
> fixed, we need to re-enable it on open CI.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> b/.pytool/Plugin/EccCheck/EccCheck.py
> index 3eaad0bf5623..eee1ff7a77b5 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> "10011",
> "10012",
> "10013",
> - "10014", #need to be removed after
> BZ2904 is fixed
> "10015",
> "10016",
> "10017",
> --
> 2.18.0.windows.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
[not found] ` <1630EC2C35B89AD7.28345@groups.io>
@ 2020-09-02 9:36 ` gaoliming
2020-09-02 11:08 ` Laszlo Ersek
0 siblings, 1 reply; 6+ messages in thread
From: gaoliming @ 2020-09-02 9:36 UTC (permalink / raw)
To: devel, gaoliming, 'Shenglei Zhang', afish,
'Laszlo Ersek', 'Leif Lindholm'
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Because the fix for ECC tool has been merged, I also request to catch this
change for stable202008 tag.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+64967+4905953+8761045@groups.io
> <bounce+27952+64967+4905953+8761045@groups.io> 代表 gaoliming
> 发送时间: 2020年9月2日 17:06
> 收件人: 'Shenglei Zhang' <shenglei.zhang@intel.com>; devel@edk2.groups.io
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>
> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error
> code 10014 for open CI
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Shenglei Zhang <shenglei.zhang@intel.com>
> > 发送时间: 2020年9月2日 16:38
> > 收件人: devel@edk2.groups.io
> > 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> > 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
> CI
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> > As the false positive issue whose error code is 10014 has been
> > fixed, we need to re-enable it on open CI.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> > b/.pytool/Plugin/EccCheck/EccCheck.py
> > index 3eaad0bf5623..eee1ff7a77b5 100644
> > --- a/.pytool/Plugin/EccCheck/EccCheck.py
> > +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> > "10011",
> > "10012",
> > "10013",
> > - "10014", #need to be removed after
> > BZ2904 is fixed
> > "10015",
> > "10016",
> > "10017",
> > --
> > 2.18.0.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
2020-09-02 9:36 ` 回复: [edk2-devel] " gaoliming
@ 2020-09-02 11:08 ` Laszlo Ersek
2020-09-02 11:12 ` Laszlo Ersek
2020-09-02 14:58 ` 回复: " gaoliming
0 siblings, 2 replies; 6+ messages in thread
From: Laszlo Ersek @ 2020-09-02 11:08 UTC (permalink / raw)
To: devel, gaoliming, 'Shenglei Zhang', afish,
'Leif Lindholm'
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Hi Liming, Shenglei,
On 09/02/20 11:36, gaoliming wrote:
> Because the fix for ECC tool has been merged, I also request to catch this
> change for stable202008 tag.
I'm OK with that, given that this patch modifies .pytool (that is, CI)
-- in other words, I'm OK because the patch affects our workflow only,
and doesn't really affect the edk2 codebase itself.
(Put differently, downstream parties that fork edk2 at
edk2-stable202008, or rebase their current forks to edk2-stable202008,
cannot be affected by this change in any way.)
However, I suggest a different approach for the patch itself (the end
result will be the same, code-wise). Please start the patch by running:
$ git revert d4e0b9607c9a
and then please extend the commit message. It should be clear from the
commit log (subject and first paragraph) that this patch is a revert.
Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
even the code comment, from the original patch, says: "need to be
removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
the revert, is not expected to be a part of BZ2904.)
So I suggest opening a new TianoCore BZ as well, making it *dependent*
on 2904. And the revert should reference the new BZ.
Again, I'm fine with merging this patch before the stable tag, I'd just
like the BZ reference and the revert statement to be clean.
Thanks!
Laszlo
>> -----邮件原件-----
>> 发件人: bounce+27952+64967+4905953+8761045@groups.io
>> <bounce+27952+64967+4905953+8761045@groups.io> 代表 gaoliming
>> 发送时间: 2020年9月2日 17:06
>> 收件人: 'Shenglei Zhang' <shenglei.zhang@intel.com>; devel@edk2.groups.io
>> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
>> <Bret.Barkelew@microsoft.com>; 'Michael D Kinney'
>> <michael.d.kinney@intel.com>
>> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error
>> code 10014 for open CI
>>
>> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>>
>> Thanks
>> Liming
>>> -----邮件原件-----
>>> 发件人: Shenglei Zhang <shenglei.zhang@intel.com>
>>> 发送时间: 2020年9月2日 16:38
>>> 收件人: devel@edk2.groups.io
>>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
>>> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open
>> CI
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
>>> As the false positive issue whose error code is 10014 has been
>>> fixed, we need to re-enable it on open CI.
>>>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
>>> ---
>>> .pytool/Plugin/EccCheck/EccCheck.py | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
>>> b/.pytool/Plugin/EccCheck/EccCheck.py
>>> index 3eaad0bf5623..eee1ff7a77b5 100644
>>> --- a/.pytool/Plugin/EccCheck/EccCheck.py
>>> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
>>> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
>>> "10011",
>>> "10012",
>>> "10013",
>>> - "10014", #need to be removed after
>>> BZ2904 is fixed
>>> "10015",
>>> "10016",
>>> "10017",
>>> --
>>> 2.18.0.windows.1
>>
>>
>>
>>
>>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
2020-09-02 11:08 ` Laszlo Ersek
@ 2020-09-02 11:12 ` Laszlo Ersek
2020-09-02 14:58 ` 回复: " gaoliming
1 sibling, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2020-09-02 11:12 UTC (permalink / raw)
To: devel, gaoliming, 'Shenglei Zhang', afish,
'Leif Lindholm', 'Michael D Kinney'
Cc: 'Sean Brogan', 'Bret Barkelew'
(request for Mike below)
On 09/02/20 13:08, Laszlo Ersek wrote:
> Hi Liming, Shenglei,
>
> On 09/02/20 11:36, gaoliming wrote:
>> Because the fix for ECC tool has been merged, I also request to catch this
>> change for stable202008 tag.
>
> I'm OK with that, given that this patch modifies .pytool (that is, CI)
> -- in other words, I'm OK because the patch affects our workflow only,
> and doesn't really affect the edk2 codebase itself.
>
> (Put differently, downstream parties that fork edk2 at
> edk2-stable202008, or rebase their current forks to edk2-stable202008,
> cannot be affected by this change in any way.)
>
> However, I suggest a different approach for the patch itself (the end
> result will be the same, code-wise). Please start the patch by running:
>
> $ git revert d4e0b9607c9a
>
> and then please extend the commit message. It should be clear from the
> commit log (subject and first paragraph) that this patch is a revert.
>
> Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
> even the code comment, from the original patch, says: "need to be
> removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
> the revert, is not expected to be a part of BZ2904.)
>
> So I suggest opening a new TianoCore BZ as well, making it *dependent*
> on 2904. And the revert should reference the new BZ.
>
> Again, I'm fine with merging this patch before the stable tag, I'd just
> like the BZ reference and the revert statement to be clean.
... also wanted to mention that #2904 is a BaseTools BZ, but this revert
patch is for .pytool (CI).
In fact: Mike, can we please add ".pytool" or maybe "Core CI" to the
Package list in the TianoCore Bugzilla installation? The original BZ for
commit d4e0b9607c9a -- i.e., the one that's now being reverted -- says
"Package: N/A", and that's not really helpful.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI
2020-09-02 11:08 ` Laszlo Ersek
2020-09-02 11:12 ` Laszlo Ersek
@ 2020-09-02 14:58 ` gaoliming
1 sibling, 0 replies; 6+ messages in thread
From: gaoliming @ 2020-09-02 14:58 UTC (permalink / raw)
To: devel, lersek, 'Shenglei Zhang', afish,
'Leif Lindholm'
Cc: 'Sean Brogan', 'Bret Barkelew',
'Michael D Kinney'
Laszlo:
> -----邮件原件-----
> 发件人: bounce+27952+64972+4905953+8761045@groups.io
> <bounce+27952+64972+4905953+8761045@groups.io> 代表 Laszlo Ersek
> 发送时间: 2020年9月2日 19:09
> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn; 'Shenglei Zhang'
> <shenglei.zhang@intel.com>; afish@apple.com; 'Leif Lindholm'
> <leif@nuviainc.com>
> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> <Bret.Barkelew@microsoft.com>; 'Michael D Kinney'
> <michael.d.kinney@intel.com>
> 主题: Re: 回复: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable
> Ecc error code 10014 for open CI
>
> Hi Liming, Shenglei,
>
> On 09/02/20 11:36, gaoliming wrote:
> > Because the fix for ECC tool has been merged, I also request to catch this
> > change for stable202008 tag.
>
> I'm OK with that, given that this patch modifies .pytool (that is, CI)
> -- in other words, I'm OK because the patch affects our workflow only,
> and doesn't really affect the edk2 codebase itself.
>
> (Put differently, downstream parties that fork edk2 at
> edk2-stable202008, or rebase their current forks to edk2-stable202008,
> cannot be affected by this change in any way.)
>
> However, I suggest a different approach for the patch itself (the end
> result will be the same, code-wise). Please start the patch by running:
>
> $ git revert d4e0b9607c9a
>
> and then please extend the commit message. It should be clear from the
> commit log (subject and first paragraph) that this patch is a revert.
>
Good point. The patch is just a revert. It should include revert message.
> Furthermore, TianoCore#2904 is in RESOLVED|FIXED status already. (And
> even the code comment, from the original patch, says: "need to be
> removed *after* BZ2904 is fixed" [emphasis mine] -- so this new patch,
> the revert, is not expected to be a part of BZ2904.)
>
> So I suggest opening a new TianoCore BZ as well, making it *dependent*
> on 2904. And the revert should reference the new BZ.
>
https://bugzilla.tianocore.org/show_bug.cgi?id=2951 is submitted for this issue.
Thanks
Liming
> Again, I'm fine with merging this patch before the stable tag, I'd just
> like the BZ reference and the revert statement to be clean.
>
> Thanks!
> Laszlo
>
> >> -----邮件原件-----
> >> 发件人: bounce+27952+64967+4905953+8761045@groups.io
> >> <bounce+27952+64967+4905953+8761045@groups.io> 代表 gaoliming
> >> 发送时间: 2020年9月2日 17:06
> >> 收件人: 'Shenglei Zhang' <shenglei.zhang@intel.com>;
> devel@edk2.groups.io
> >> 抄送: 'Sean Brogan' <sean.brogan@microsoft.com>; 'Bret Barkelew'
> >> <Bret.Barkelew@microsoft.com>; 'Michael D Kinney'
> >> <michael.d.kinney@intel.com>
> >> 主题: [edk2-devel] 回复: [PATCH 1/1] .pytool/EccCheck: Enable Ecc
> error
> >> code 10014 for open CI
> >>
> >> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> >>
> >> Thanks
> >> Liming
> >>> -----邮件原件-----
> >>> 发件人: Shenglei Zhang <shenglei.zhang@intel.com>
> >>> 发送时间: 2020年9月2日 16:38
> >>> 收件人: devel@edk2.groups.io
> >>> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> >>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> >>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> >>> 主题: [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for
> open
> >> CI
> >>>
> >>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2904
> >>> As the false positive issue whose error code is 10014 has been
> >>> fixed, we need to re-enable it on open CI.
> >>>
> >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> >>> ---
> >>> .pytool/Plugin/EccCheck/EccCheck.py | 1 -
> >>> 1 file changed, 1 deletion(-)
> >>>
> >>> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> >>> b/.pytool/Plugin/EccCheck/EccCheck.py
> >>> index 3eaad0bf5623..eee1ff7a77b5 100644
> >>> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> >>> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> >>> @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin):
> >>> "10011",
> >>> "10012",
> >>> "10013",
> >>> - "10014", #need to be removed after
> >>> BZ2904 is fixed
> >>> "10015",
> >>> "10016",
> >>> "10017",
> >>> --
> >>> 2.18.0.windows.1
> >>
> >>
> >>
> >>
> >>
> >
> >
> >
> >
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-02 14:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-02 8:38 [PATCH 1/1] .pytool/EccCheck: Enable Ecc error code 10014 for open CI Zhang, Shenglei
2020-09-02 9:05 ` 回复: " gaoliming
[not found] ` <1630EC2C35B89AD7.28345@groups.io>
2020-09-02 9:36 ` 回复: [edk2-devel] " gaoliming
2020-09-02 11:08 ` Laszlo Ersek
2020-09-02 11:12 ` Laszlo Ersek
2020-09-02 14:58 ` 回复: " gaoliming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox