From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: "'Nhi Pham'" <nhi@os.amperecomputing.com>, <devel@edk2.groups.io>,
<jake@nvidia.com>
Cc: <jian.j.wang@intel.com>
Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error
Date: Mon, 6 Nov 2023 08:59:57 +0800 [thread overview]
Message-ID: <006001da104c$8f83f640$ae8be2c0$@byosoft.com.cn> (raw)
In-Reply-To: <2ec7ff5b-11ab-499d-8b51-92795de878ca@os.amperecomputing.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Nhi Pham <nhi@os.amperecomputing.com>
> 发送时间: 2023年11月5日 15:09
> 收件人: devel@edk2.groups.io; jake@nvidia.com
> 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix
> clang error
>
> Hi Liming,
>
> Could you please help review and get this patch merged within the next
> edk2-stable tag?
>
> Thanks,
> Nhi
>
> On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote:
> > This looks good to me. I also build-tested this patch.
> >
> > Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>
> > Tested-by: Nhi Pham <nhi@os.amperecomputing.com>
> >
> > On 10/3/2023 10:04 PM, Jake Garver via groups.io wrote:
> >> Ignore old style declaration warnings in oniguruma/src/st.c. This was
> >> already ignored for MSFT, but newer versions of clang complain as well.
> >>
> >> Signed-off-by: Jake Garver <jake@nvidia.com>
> >> ---
> >> .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git
> >>
> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> >>
> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> >> index 84489c2942..0092531a67 100644
> >> ---
> >>
> a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> >> +++
> >>
> b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
> >> @@ -102,6 +102,7 @@
> >> # Oniguruma: old style declaration in st.c
> >> MSFT:*_*_*_CC_FLAGS = /wd4131
> >> + GCC:*_*_*_CC_FLAGS = -Wno-deprecated-non-prototype
> >> # Oniguruma: 'type cast' : truncation from 'OnigUChar *' to
> >> 'unsigned int'
> >> MSFT:*_*_*_CC_FLAGS = /wd4305 /wd4306
> >
> >
> >
> >
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110689): https://edk2.groups.io/g/devel/message/110689
Mute This Topic: https://groups.io/mt/102412041/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-06 1:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 15:04 [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error Jake Garver via groups.io
2023-10-23 4:27 ` Nhi Pham via groups.io
[not found] ` <1790A21286FB1538.11247@groups.io>
2023-11-05 7:09 ` Nhi Pham via groups.io
2023-11-06 0:59 ` gaoliming via groups.io [this message]
2023-11-05 11:32 ` Laszlo Ersek
2023-11-06 0:59 ` 回复: " gaoliming via groups.io
2023-11-07 12:04 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006001da104c$8f83f640$ae8be2c0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox