From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.4120.1635820284405182967 for ; Mon, 01 Nov 2021 19:31:25 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 02 Nov 2021 10:31:21 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Michael D Kinney'" , Cc: "'Ard Biesheuvel'" , "'Jiewen Yao'" , "'Jordan Justen'" , "'Gerd Hoffmann'" , "'Michael Kubacki'" , "'Jian J Wang'" , "'Maciej Rabeda'" , "'Jiaxin Wu'" , "'Siyuan Fu'" , "'Leif Lindholm'" , "'Zhiguang Liu'" References: <20211101213737.586-1-michael.d.kinney@intel.com> In-Reply-To: <20211101213737.586-1-michael.d.kinney@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUGF0Y2ggVjIgMC83XSBSZXByb2R1Y2UgYnVpbGRzIGFjcm9zcyBzb3VyY2UgZm9ybWF0IGNoYW5nZXM=?= Date: Tue, 2 Nov 2021 10:31:22 +0800 Message-ID: <006201d7cf91$b9e15980$2da40c80$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIZONpyVmW43l3onK7cMciy0JFcc6tsrI4A Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike=A3=BA Seemly, this change is for debug image build reproduce. But, if the = fixed value is used, they are not correct for the debug image. If so, can = RELEASE image be used for the binary comparison? Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Michael D Kinney > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA11=D4=C22=C8=D5 5:38 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Ard Biesheuvel ; Jiewen Yao > ; Jordan Justen ; = Gerd > Hoffmann ; Michael Kubacki > ; Jian J Wang ; > Maciej Rabeda ; Jiaxin Wu > ; Siyuan Fu ; Liming Gao > ; Leif Lindholm ; = Zhiguang > Liu > =D6=F7=CC=E2: [Patch V2 0/7] Reproduce builds across source format = changes >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3688 >=20 > New in V2 > ------------ > * Split MdePkg DebugLib class enhancements out into its own commit > * Address ECC failures > * Align macro continuation marks in same column >=20 > This change is required to help verify that source code formatting > changes such as the use of uncrustify and line ending corrections > do not have any functional differences. Source format changes may > add or remove line endings that change the source file line numbers > of C statements or may change the use of spaces in C expressions > used in an ASSERT() statements. These types of changes can impact > the generated binaries when DEBUG() and ASSERT() macros are > enabled. The following set of changes adds 2 defines that can be used > to override the use of `__LINE__` in DEBUG() macros and the use of > #Expression in ASSERT() macros. >=20 > * Add DEBUG_LINE_NUMBER define to DebugLib.h that is > by default mapped to `__LINE__`. A build can pre-define > DEBUG_LINE_NUMBER to use a fixed value. > * Add DEBUG_EXPRESSION_STRING(Expression) macros to > DebugLib.h that is by default mapped to #Expression. > A build can define DEBUG_EXPRESSION_STRING_VALUE to > set all expression strings to a fixed string value. > * Use DEBUG_LINE_NUMBER instead of `__LINE__`. > * Use DEBUG_EXPRESSION_STRING instead of #Expression. >=20 > Submodules that use `__LINE__` are not updated. These do not > currently impact build reproducibility unless the debug features > of those submodules are enabled. >=20 > The one exception is the UnitTestFrameworkPkg cmocka submodule > that uses `__LINE__`. This means that the binaries generated by host > based unit tests that use cmocka features may not be identical across > a source format change. >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Michael Kubacki > Cc: Jian J Wang > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Zhiguang Liu > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (7): > MdePkg/Include: Enhance DebugLib to support reproduce builds > MdePkg: Reproduce builds across source format changes > ArmPkg: Reproduce builds across source format changes > MdeModulePkg: Reproduce builds across source format changes > NetworkPkg: Reproduce builds across source format changes > SecurityPkg: Reproduce builds across source format changes > OvmfPkg: Reproduce builds across source format changes >=20 > .../ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > .../Type00/MiscBiosVendorFunction.c | 2 +- > .../Type01/MiscSystemManufacturerFunction.c | 2 +- > .../MiscBaseBoardManufacturerFunction.c | 2 +- > .../Type03/MiscChassisManufacturerFunction.c | 2 +- > ...MiscNumberOfInstallableLanguagesFunction.c | 2 +- > .../Type32/MiscBootInformationFunction.c | 2 +- > .../Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 2 +- > .../UefiBootManagerLib/BmDriverHealth.c | 2 +- > MdePkg/Include/Library/DebugLib.h | 43 > +++++++++++++++-- > MdePkg/Include/Library/UnitTestLib.h | 46 = +++++++++---------- > MdePkg/Library/BaseLib/SafeString.c | 2 +- > NetworkPkg/Include/Library/NetLib.h | 8 ++-- > NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- > OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 6 +-- > .../PlatformBootManagerLib/BdsPlatform.c | 4 +- > .../PlatformBootManagerLibBhyve/BdsPlatform.c | 2 +- > .../PlatformBootManagerLibGrub/BdsPlatform.c | 4 +- > .../Include/Library/TcgStorageCoreLib.h | 26 +++++------ > 19 files changed, 98 insertions(+), 63 deletions(-) >=20 > -- > 2.32.0.windows.1