From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6DB73AC0A6E for ; Mon, 6 Nov 2023 01:04:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JmlHlh3y0xIK7v/jpgwd+uHA2o7+auWrwmJzCFcmWZk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1699232658; v=1; b=Lnblpys/lyXoqiNeGUR4dwZ0/NccAyp7XVQ1tOsLMMlLjLuARK7Jv9WZlNT3ywBlJWbbiO1f UnS23d/PdjXlMw/IkpSrY9ve8QijrvQXNLWcOQw9ctk8vf46U8PQsPAmey+EMTu+bkvQ/XvQfIX aAYY8GHpYb1bfnGtcojlqFvQ= X-Received: by 127.0.0.2 with SMTP id 1ZmuYY7687511xFmOA81e8ct; Sun, 05 Nov 2023 17:04:18 -0800 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web11.43857.1699232657288296203 for ; Sun, 05 Nov 2023 17:04:17 -0800 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id BD25EDDA7E1 for ; Mon, 6 Nov 2023 09:04:15 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id B883EDDA7DE for ; Mon, 6 Nov 2023 09:04:15 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 13F3CDDA7EB for ; Mon, 6 Nov 2023 09:04:12 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Mon, 06 Nov 2023 09:04:07 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Bob Feng'" , "'Yuwei Chen'" References: <20231102002052.17494-1-rebecca@bsdio.com> <3ac69a14-90fe-4358-9f36-207b63a25f42@bsdio.com> In-Reply-To: <3ac69a14-90fe-4358-9f36-207b63a25f42@bsdio.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvMV0gQmFzZVRvb2xzOiBVcGRhdGUgUGF0Y2hDaGVjay5weSB0byBhbGxvdyB3aGl0ZXNwYWNlIGlzc3VlcyBpbiAucnRmIGZpbGVz?= Date: Mon, 6 Nov 2023 09:04:08 +0800 Message-ID: <006201da104d$2539c480$6fad4d80$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQHaVSBLtk5csrDwV2n6RvN8r8upTwE5zaBjsGIhm2A= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0cA8Sy9mONFddArFLMLn2sihx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="Lnblpys/"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Rebecca Cran > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B411=E6=9C=883=E6=97=A5 = 22:42 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Liming Gao > =E6=8A=84=E9=80=81: devel@edk2.groups.io; Bob Feng = ; Yuwei Chen > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchC= heck.py to > allow whitespace issues in .rtf files >=20 > Liming, could you review this please? It's blocking another patch from > being committed. >=20 > -- > Rebecca >=20 > On 11/1/2023 6:20 PM, Rebecca Cran wrote: > > Allow .rtf files created by applications such as Notepad to be committe= d > > as-is without further manual editing by skipping the requirements for > > CRLF, no tabs and no trailing whitespace. > > > > Signed-off-by: Rebecca Cran > > --- > > BaseTools/Scripts/PatchCheck.py | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py > > index 900226f18fe5..7f372d40b570 100755 > > --- a/BaseTools/Scripts/PatchCheck.py > > +++ b/BaseTools/Scripts/PatchCheck.py > > @@ -363,6 +363,9 @@ class GitDiffCheck: > > self.is_newfile =3D False > > self.force_crlf =3D True > > self.force_notabs =3D True > > + if self.filename.endswith('.rtf'): > > + self.force_crlf =3D False > > + self.force_notabs =3D False > > if self.filename.endswith('.sh') or \ > > > self.filename.startswith('BaseTools/BinWrappers/PosixLike/') or \ > > > self.filename.startswith('BaseTools/BinPipWrappers/PosixLike/') or \ > > @@ -416,7 +419,7 @@ class GitDiffCheck: > > self.format_error("didn't find diff hunk marker > (@@)") > > self.line_num +=3D 1 > > elif self.state =3D=3D PATCH: > > - if self.binary: > > + if self.binary or self.filename.endswith(".rtf"): > > pass > > elif line.startswith('-'): > > pass >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110691): https://edk2.groups.io/g/devel/message/110691 Mute This Topic: https://groups.io/mt/102412114/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-