From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.3748.1633658991198678852 for ; Thu, 07 Oct 2021 19:09:52 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 08 Oct 2021 10:09:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Samer El-Haj-Mahmoud'" , , "'Christopher Jones'" Cc: , , "'Sami Mujawar'" , "'Ben Adderson'" , "'Akanksha Jain'" , "'Matteo Carlini'" , "'nd'" References: <20211006101154.20589-1-christopher.jones@arm.com> <005e01d7bbe3$70b63a80$5222af80$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gTWRlUGtnOiBGaXggQUNQSSBtZW1vcnkgYWdncmVnYXRvci9kZXZpY2UgdHlwZSBtaXNtYXRjaA==?= Date: Fri, 8 Oct 2021 10:09:44 +0800 Message-ID: <006301d7bbe9$8fbad840$af3088c0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHtEPFXU7b29eDIWS+m4pOB9DaWvgJ/XTrrAbVJlkqrfAd0UA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Samer: Thanks for your information. I agree this change. Reviewed-by: Liming Gao= Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Samer El-Haj-Mahmoud > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=888=E6=97=A5 = 9:45 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.= cn; Christopher > Jones > =E6=8A=84=E9=80=81: michael.d.kinney@intel.com; zhiguang.liu@intel.com; S= ami Mujawar > ; Ben Adderson ; > Akanksha Jain ; Matteo Carlini > ; nd ; Samer El-Haj-Mahmoud > > =E4=B8=BB=E9=A2=98: RE: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memo= ry > aggregator/device type mismatch >=20 > We did investigate this in the BZ, and the conclusion was it is safer to = update > the code to match the spec. The only OS implementation we have seen so fa= r > is in Linux, and it uses the spec defined values (although for limited us= age). > See https://bugzilla.tianocore.org/show_bug.cgi?id=3D3579 >=20 >=20 >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > gaoliming via groups.io > > Sent: Thursday, October 7, 2021 9:26 PM > > To: devel@edk2.groups.io; Christopher Jones > > > > Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Sami Mujawar > > ; Ben Adderson ; > > Akanksha Jain ; Matteo Carlini > > ; nd > > Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix AC= PI memory > > aggregator/device type mismatch > > > > Jones: > > Do you know what impact will be introduced by this change? > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Chris > Jones > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B410=E6=9C=886=E6=97= =A5 18:12 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: michael.d.kinney@intel.com; gaoliming@byosoft.com= .cn; > > > zhiguang.liu@intel.com; Sami.Mujawar@arm.com; > > Ben.Adderson@arm.com; > > > Akanksha.Jain2@arm.com; Matteo.Carlini@arm.com; nd@arm.com > > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memo= ry > > > aggregator/device type mismatch > > > > > > Bugzilla: 3578 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3579= ) > > > > > > Since the Common Memory Device (formerly Memory Aggregator Device) > > > was > > > introduced in ACPI 5.0, the edk2 type values have not matched the > > > values defined in the ACPI specification. > > > > > > Fix this discrepancy by aligning the code to match the specification. > > > > > > Signed-off-by: Chris Jones > > > --- > > > MdePkg/Include/IndustryStandard/Acpi50.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi51.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi60.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi61.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi62.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi63.h | 6 +++--- > > > MdePkg/Include/IndustryStandard/Acpi64.h | 6 +++--- > > > 7 files changed, 21 insertions(+), 21 deletions(-) > > > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h > > > b/MdePkg/Include/IndustryStandard/Acpi50.h > > > index > > > > 31a47e6a2c4276d5b1ad7b834af84844090b64c5..83d787c7650cf649fe3d2e1 > > > 2e7983bae86a2a114 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi50.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi50.h > > > @@ -996,9 +996,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_5_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h > > > b/MdePkg/Include/IndustryStandard/Acpi51.h > > > index > > > > fc28ffa18fc6a22e52fda88fade6ad80b2817cc3..5fbf7c99f1f7d6ca9109f198bd > > > 3f25f12bd47961 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi51.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi51.h > > > @@ -951,9 +951,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_5_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h > > > b/MdePkg/Include/IndustryStandard/Acpi60.h > > > index > > > > 5dcd73b6f1ec4bccc7fdae7d56c2963ab58764f9..eba4248e1d5733d21973f0d > > > ac2286e02238a0aae 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi60.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi60.h > > > @@ -966,9 +966,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_6_0_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h > > > b/MdePkg/Include/IndustryStandard/Acpi61.h > > > index > > > > 8626833a794dfb4a6f19d459d5214c6caefdbbee..7a776020baa8f3ee7b6f05fe > > > e336225ab6589ce0 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi61.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi61.h > > > @@ -966,9 +966,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_6_1_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h > > > b/MdePkg/Include/IndustryStandard/Acpi62.h > > > index > > > > 1b2704e98e3703a4405075247432ec842e45021b..33a0a0f21959df8b64803e > > > 972ab19f0c0ab1619e 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi62.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi62.h > > > @@ -1078,9 +1078,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_6_2_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h > > > b/MdePkg/Include/IndustryStandard/Acpi63.h > > > index > > > > b281b30155e90eba5169dc39bde9a3379e3b7005..3b1426af27ea4ebada1a1 > > > 2e99ce958bb288ad931 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi63.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi63.h > > > @@ -1040,9 +1040,9 @@ typedef struct { > > > /// > > > /// Memory Aggregator Device Type > > > /// > > > -#define > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x2 > > > -#define > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_MEMORY_C > > > ONTROLLER 0x1 > > > +#define > > > EFI_ACPI_6_3_PMMT_MEMORY_AGGREGATOR_DEVICE_TYPE_DIMM > > > 0x2 > > > > > > /// > > > /// Socket Memory Aggregator Device Structure. > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > > > b/MdePkg/Include/IndustryStandard/Acpi64.h > > > index > > > > 3a91302f8c0e71d4951d27aac35322073219c836..8346d83f1249045497b602 > > > 907b94fbb2b495cd56 100644 > > > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > > > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > > > @@ -1075,9 +1075,9 @@ typedef struct { > > > /// > > > /// Memory Device Type. > > > /// > > > -#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_SOCKET > > > 0x1 > > > -#define > > > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_MEMORY_CONTROLLER > > > 0x2 > > > -#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_DIMM > > > 0x3 > > > +#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_SOCKET > > > 0x0 > > > +#define > > > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_MEMORY_CONTROLLER > > > 0x1 > > > +#define EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_DIMM > > > 0x2 > > > #define > > > EFI_ACPI_6_4_PMTT_MEMORY_DEVICE_TYPE_VENDOR_SPECIFIC_TYPE > > > 0xFF > > > > > > /// > > > -- > > > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >