From: "MrChromebox" <matt.devillier@gmail.com>
To: devel@edk2.groups.io
Cc: Matt DeVillier <matt.devillier@gmail.com>
Subject: [edk2-devel] [PATCH 3/3] PlatformHookLib: Set PcdSerialClockRate using HOB data
Date: Wed, 4 Oct 2023 15:01:35 -0500 [thread overview]
Message-ID: <00631c0eb096de9089a9fe123e905b435d83da2e.1696448945.git.matt.devillier@gmail.com> (raw)
In-Reply-To: <9143994e6a5f37650930abfc4141c6061e5bef98.1696448945.git.matt.devillier@gmail.com>
Fixes serial output on platforms using coreboot and a non-default
clock rate such as AMD Picasso and newer Zen-based platforms.
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Change-Id: I91290397852176754e9a34ec6e5829044f41d15a
---
UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c | 5 +++++
UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf | 1 +
2 files changed, 6 insertions(+)
diff --git a/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c b/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c
index 60a17b8fc2..e3d47ac2fa 100644
--- a/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c
+++ b/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c
@@ -90,6 +90,11 @@ PlatformHookSerialPortInitialize (
return Status;
}
+ Status = PcdSet32S (PcdSerialClockRate, SerialPortInfo->ClockRate);
+ if (RETURN_ERROR (Status)) {
+ return Status;
+ }
+
return RETURN_SUCCESS;
}
diff --git a/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf b/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf
index 7ac6bfa1b1..e2908cfbca 100644
--- a/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf
+++ b/UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf
@@ -38,3 +38,4 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase ## PRODUCES
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialBaudRate ## PRODUCES
gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride ## PRODUCES
+ gEfiMdeModulePkgTokenSpaceGuid.PcdSerialClockRate ## PRODUCES
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109337): https://edk2.groups.io/g/devel/message/109337
Mute This Topic: https://groups.io/mt/101763377/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-10-04 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 20:01 [edk2-devel] [PATCH 1/3] MdeModulePkg: Add ClockRate field to SerialPortInfo MrChromebox
2023-10-04 20:01 ` [edk2-devel] [PATCH 2/3] UefiPayloadEntry: Set serial ClockRate from parsed SerialInfo MrChromebox
2023-10-04 20:01 ` MrChromebox [this message]
2024-04-03 7:53 ` [edk2-devel] [PATCH 3/3] PlatformHookLib: Set PcdSerialClockRate using HOB data Sean Rhodes
2023-10-05 19:45 ` [edk2-devel] [PATCH 1/3] MdeModulePkg: Add ClockRate field to SerialPortInfo Pedro Falcato
2023-10-09 15:54 ` MrChromebox
2023-10-11 21:15 ` Pedro Falcato
2023-10-11 23:21 ` MrChromebox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00631c0eb096de9089a9fe123e905b435d83da2e.1696448945.git.matt.devillier@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox