From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
"'Garrett Kirkendall'" <Garrett.Kirkendall@amd.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
"'Yuwei Chen'" <yuwei.chen@intel.com>
Subject: 回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
Date: Fri, 21 May 2021 14:28:47 +0800 [thread overview]
Message-ID: <006401d74e0a$8e7ac910$ab705b30$@byosoft.com.cn> (raw)
In-Reply-To: <167F7DB41BEEF9C0.24037@groups.io>
This patch is reviewed before soft feature freeze.
So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it for
this stable tag.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming
> 发送时间: 2021年5月16日 16:10
> 收件人: 'Garrett Kirkendall' <Garrett.Kirkendall@amd.com>;
> devel@edk2.groups.io
> 抄送: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: build: Set ReturnCode
on
> POSTBUILD fail
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: Garrett Kirkendall <Garrett.Kirkendall@amd.com>
> > 发送时间: 2021年5月14日 23:02
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> Garrett
> > Kirkendall <garrett.kirkendall@amd.com>
> > 主题: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTBUILD fail
> >
> > When build.by POSTBUILD handling section returns other than 0, set
> > ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> > than 0.
> >
> > Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=1977
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> >
> > Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > ---
> > BaseTools/Source/Python/build/build.py | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/build/build.py
> > b/BaseTools/Source/Python/build/build.py
> > index 037493f0b02a..3e4d83409f49 100755
> > --- a/BaseTools/Source/Python/build/build.py
> > +++ b/BaseTools/Source/Python/build/build.py
> > @@ -2757,6 +2757,7 @@ def Main():
> > Conclusion = "Done"
> >
> > except:
> >
> > Conclusion = "Failed"
> >
> > + ReturnCode = POSTBUILD_ERROR
> >
> > elif ReturnCode == ABORT_ERROR:
> >
> > Conclusion = "Aborted"
> >
> > else:
> >
> > --
> > 2.30.1.windows.1
>
>
>
>
>
>
>
prev parent reply other threads:[~2021-05-21 6:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 15:01 [PATCH v1 0/1] BaseTools: build: Set ReturnCode on POSTBUILD fail Kirkendall, Garrett
2021-05-14 15:01 ` [PATCH v1 1/1] " Kirkendall, Garrett
2021-05-16 8:09 ` 回复: " gaoliming
2021-05-19 16:55 ` Kirkendall, Garrett
[not found] ` <167F7DB41BEEF9C0.24037@groups.io>
2021-05-21 6:28 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006401d74e0a$8e7ac910$ab705b30$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox