From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web09.5571.1621578534584609814
 for <devel@edk2.groups.io>;
 Thu, 20 May 2021 23:28:55 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <bob.c.feng@intel.com>; Fri, 21 May 2021 14:28:44 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>,
	<gaoliming@byosoft.com.cn>,
	"'Garrett Kirkendall'" <Garrett.Kirkendall@amd.com>
Cc: "'Bob Feng'" <bob.c.feng@intel.com>,
	"'Yuwei Chen'" <yuwei.chen@intel.com>
References: <20210514150143.5-1-Garrett.Kirkendall@amd.com> <20210514150143.5-2-Garrett.Kirkendall@amd.com> <167F7DB41BEEF9C0.24037@groups.io>
In-Reply-To: <167F7DB41BEEF9C0.24037@groups.io>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUEFUQ0ggdjEgMS8xXSBCYXNlVG9vbHM6IGJ1aWxkOiBTZXQgUmV0dXJuQ29kZSBvbiBQT1NUQlVJTEQgZmFpbA==?=
Date: Fri, 21 May 2021 14:28:47 +0800
Message-ID: <006401d74e0a$8e7ac910$ab705b30$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQKVofpEwYBIn0QYcvI4WhjGVRMXmwHWX1IjAfxlm7upUjrL4A==
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

This patch is reviewed before soft feature freeze.=20

So, I create PR https://github.com/tianocore/edk2/pull/1659 to merge it fo=
r
this stable tag.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io <devel@edk2.groups.io> =B4=FA=
=B1=ED gaoliming
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C216=C8=D5 16:10
> =CA=D5=BC=FE=C8=CB: 'Garrett Kirkendall' <Garrett.Kirkendall@amd.com>;
> devel@edk2.groups.io
> =B3=AD=CB=CD: 'Bob Feng' <bob.c.feng@intel.com>; 'Yuwei Chen'
> <yuwei.chen@intel.com>
> =D6=F7=CC=E2: [edk2-devel] =BB=D8=B8=B4: [PATCH v1 1/1] BaseTools: build=
: Set ReturnCode
on
> POSTBUILD fail
>=20
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>=20
> > -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> > =B7=A2=BC=FE=C8=CB: Garrett Kirkendall <Garrett.Kirkendall@amd.com>
> > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C214=C8=D5 23:02
> > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> > =B3=AD=CB=CD: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>;
> Garrett
> > Kirkendall <garrett.kirkendall@amd.com>
> > =D6=F7=CC=E2: [PATCH v1 1/1] BaseTools: build: Set ReturnCode on POSTB=
UILD fail
> >
> > When build.by POSTBUILD handling section returns other than 0, set
> > ReturnCode to POSTBUILD_ERROR so build.py exits with return code other
> > than 0.
> >
> > Fix for https://bugzilla.tianocore.org/show_bug.cgi?id=3D1977
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> >
> > Signed-off-by: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > ---
> >  BaseTools/Source/Python/build/build.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/BaseTools/Source/Python/build/build.py
> > b/BaseTools/Source/Python/build/build.py
> > index 037493f0b02a..3e4d83409f49 100755
> > --- a/BaseTools/Source/Python/build/build.py
> > +++ b/BaseTools/Source/Python/build/build.py
> > @@ -2757,6 +2757,7 @@ def Main():
> >              Conclusion =3D "Done"
> >
> >          except:
> >
> >              Conclusion =3D "Failed"
> >
> > +            ReturnCode =3D POSTBUILD_ERROR
> >
> >      elif ReturnCode =3D=3D ABORT_ERROR:
> >
> >          Conclusion =3D "Aborted"
> >
> >      else:
> >
> > --
> > 2.30.1.windows.1
>=20
>=20
>=20
>=20
>=20
>=20
>=20