From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.6111.1633915352426875350 for ; Sun, 10 Oct 2021 18:22:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 11 Oct 2021 09:22:27 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'Ard Biesheuvel'" , "'Leif Lindholm'" , "'Sami Mujawar'" , "'Jiewen Yao'" , "'Jordan Justen'" , "'Gerd Hoffmann'" , "'Schaefer, Daniel'" , "'Sunil V L'" , "'Zhiguang Liu'" , "'Michael D Kinney'" References: <20210930004548.3033-1-abner.chang@hpe.com> <16AB2A90260D3DD8.20282@groups.io> <008d01d7bbf2$8de53ed0$a9afbc70$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFYzIDAwLzEyXSBNaWdyYXRlIEFybVZpcnRQa2cgbW9kdWxlcyB0byBPdm1mUGtn?= Date: Mon, 11 Oct 2021 09:22:27 +0800 Message-ID: <006601d7be3e$7477ff70$5d67fe50$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHPNjQFN8GQVZAdNC5xuimmIlkcvQHQd0UlAg+TYuYBnByd7wGpMKJDAerj1J2rlY57IA== Content-Type: multipart/alternative; boundary="----=_NextPart_000_0067_01D7BE81.829DB070" Content-Language: zh-cn ------=_NextPart_000_0067_01D7BE81.829DB070 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable The change in MdePkg is good to me. Reviewed-by: Liming Gao =20 =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Abner Chang =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C28=C8=D5 11:39 =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn; ardb@ke= rnel.org =B3=AD=CB=CD: 'Ard Biesheuvel' ; 'Leif Lindholm' ; 'Sami Mujawar' ; 'Jiewen Yao' ; 'Jordan Justen' ; 'Gerd Hoffmann' ; Schaefer, Daniel ; 'Sunil V L' ; 'Zhiguang Liu' ; 'Michael D Kinney' =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules = to OvmfPkg =20 Thanks Liming, could you please also give the reviewed-by. =20 Hi Ard, also need your reviewed-by for ArmPkg. Then this changes could be upstream and finished.=20 Thanks=20 Abner =20 =20 From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of gaoliming Sent: Friday, October 8, 2021 11:14 AM To: Chang, Abner (HPS SW/FW Technologist) >; 'edk2-devel-groups-io' >; ardb@kernel.org = =20 Cc: 'Ard Biesheuvel' >; 'Leif Lindholm' >; 'Sami Mujawar' >; 'Jiewen Yao' >; 'Jordan Justen' >; 'Gerd Hoffmann' >; Schaefer, Daniel >; 'Sunil V L' >; 'Zhiguang Liu' >; 'Michael D Kinney' > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg mod= ules to OvmfPkg =20 Ard and Abner: I am OK to add these three PCDs PcdPciMmio32Translation, PcdPciMmio64Translation, PcdPciIoTranslation to MdePkg.=20 =20 Thanks Liming =B7=A2=BC=FE=C8=CB: Chang, Abner (HPS SW/FW Technologist) >=20 =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C26=C8=D5 17:27 =CA=D5=BC=FE=C8=CB: edk2-devel-groups-io ; ardb@kerne= l.org ; Chang, Abner (HPS SW/FW Technologist) > =B3=AD=CB=CD: Ard Biesheuvel >; Leif Lindholm >; Sami Mujawar >; Jiewen Yao >; Jordan Justen >; Gerd Hoffmann >; Schaefer, Daniel >; Sunil V L >; Liming Gao >; Zhiguang Liu >; Michael D Kinney > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules = to OvmfPkg =20 Hi Ard, I realized there is a problem if we duplicate ArmPkg defined PCD to under OvmfPkg (e.g. PcdPciIoTranslate PCD) when I was duplicating this PCD to OvmfPkg. FdtPciProducerLib is relocated to OvmfPkg/Fdt and uses PcdPciIoTranslate PC= D declared with OvmfPkg namespace. FdtPciProducerLib is also used by both ArmVirtPkg and RiscVVirtPkg. ArmVirtPkg uses ArmPciCpuIoDxe provided by ArmPkg however PcdPciIoTranslate used by ArmPciCpuIoDxe is declared with ArmPkg namespace. I think this results in the problem because PcdPciIoTranslate(s) that are referred by ArmPkg and ArmVirtPkg come from two different namespaces, right= ? Unless ArmPciCpuIoDxe uses the one declared in OvmfPkg, but I don't think w= e want to do this. Thought? Otherwise, we should still keep the original patch that relocates these PCDs under MdePkg. =20 Thanks Abner =20 =20 _____ =20 From: devel@edk2.groups.io > on behalf of Abner Chang > Sent: Tuesday, October 5, 2021 11:00 PM To: edk2-devel-groups-io >; ardb@kernel.org > Cc: Ard Biesheuvel >; Leif Lindholm >; Sami Mujawar >; Jiewen Yao >; Jordan Justen >; Gerd Hoffmann >; Schaefer, Daniel >; Sunil V L >; Liming Gao >; Zhiguang Liu >; Michael D Kinney > Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg=20 =20 Hi Ard, This way reduces the impact of MdePkg. We can try it. =20 Thanks Abner =20 _____ =20 From: devel@edk2.groups.io > on behalf of Ard Biesheuvel > Sent: Tuesday, October 5, 2021 5:30 PM To: edk2-devel-groups-io >; Chang, Abner (HPS SW/FW Technologist) > Cc: Ard Biesheuvel >; Leif Lindholm >; Sami Mujawar >; Jiewen Yao >; Jordan Justen >; Gerd Hoffmann >; Schaefer, Daniel >; Sunil V L >; Liming Gao >; Zhiguang Liu >; Michael D Kinney > Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg=20 =20 On Thu, 30 Sept 2021 at 03:43, Abner Chang > wrote: > > In V3: Address comments on V2. > In V2: Remove HPE license on the files that just moved around or > the changes in the file are just code removal. > > edk2 BZ #: 3665 > edk2 platform corresponding changes will be submitted after > this pactch set is reviewed. > > This pacthes set is to migrate some modules from ArmVirtPkg > to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage > those modules without the dependency with Arm*Pkg. > > The modules moved from ArmVirtPkg to OvmfPkg are, > - FdtClientDxe > - PciPcdProducerLib > - HighMemDxe > - QemuFwCfgLib > - FdtPciHostBridgeLib > - VirtioFdtDxe > > Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg. > This change also remove the dependency on ArmPkg of OvmfPkg. > - PcdPciIoTranslation > - PcdPciIoTranslation > - PcdPciMmio32(64)Translation > > Signed-off-by: Abner Chang > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Sami Mujawar > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Daniel Schaefer > > Cc: Sunil V L > > Cc: Liming Gao > > Cc: Zhiguang Liu = > > Cc: Michael D Kinney > > > Abner Chang (12): > ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg > MdePkg: Add PcdPciIoTranslation PCD > ArmPkg: Use PcdPciIoTranslation PCD from MdePkg > ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg > ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg > OvmfPkg/HighMemDxe: Add RISC-V in the supported arch. > ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg > OvmfPkg/QemuFwCfgLibMMIO: Add RISC-V arch support > MdePkg: Add PcdPciMmio32(64)Translation PCDs > ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to > OvmfPkg/Fdt > OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported arch. > ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt > Hello all, These patches look ok to me, but I wonder if the MdePkg maintainers are happy taking these PCD declaration changes. Translations for PCIe are typically defined per host bridge, and I would rather move away from using PCDs for this entirely than 'promote' them by carrying them in MdePkg. As this issue is somewhat orthogonal to what Abner is trying to fix, perhaps it is better to avoid MdePkg changes for now, and just duplicate these PCDs into OvmfPkg. This is reasonable, given that we know that QEMU only exposes a single host bridge. The one in ArmPkg can hopefully be removed and replaced with something that is more appropriate. > ArmPkg/ArmPkg.dec | 15 ++++++-------- > ArmVirtPkg/ArmVirtPkg.dec | 3 --- > EmbeddedPkg/EmbeddedPkg.dec | 1 + > MdePkg/MdePkg.dec | 12 +++++++++++ > ArmVirtPkg/ArmVirtCloudHv.dsc | 18 ++++++++--------- > ArmVirtPkg/ArmVirtKvmTool.dsc | 18 ++++++++--------- > ArmVirtPkg/ArmVirtQemu.dsc | 20 +++++++++---------- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 +++++++++---------- > ArmVirtPkg/ArmVirtXen.dsc | 2 +- > EmbeddedPkg/EmbeddedPkg.dsc | 1 + > ArmVirtPkg/ArmVirtCloudHv.fdf | 6 +++--- > ArmVirtPkg/ArmVirtKvmTool.fdf | 6 +++--- > ArmVirtPkg/ArmVirtXen.fdf | 2 +- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 6 +++--- > .../ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf | 2 +- > .../ArmVirtGicArchLib/ArmVirtGicArchLib.inf | 1 + > .../ArmVirtPL031FdtClientLib.inf | 1 + > .../ArmVirtPsciResetSystemLib.inf | 1 + > .../ArmVirtTimerFdtClientLib.inf | 1 + > .../KvmtoolRtcFdtClientLib.inf | 1 + > .../NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf | 1 + > .../NorFlashQemuLib/NorFlashQemuLib.inf | 1 + > .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 + > ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.inf | 1 + > .../Drivers}/FdtClientDxe/FdtClientDxe.inf | 1 - > .../FdtPciHostBridgeLib.inf | 11 +++++----- > .../FdtPciPcdProducerLib.inf | 5 ++--- > .../Fdt}/HighMemDxe/HighMemDxe.inf | 7 ++++--- > .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf | 2 +- > .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 6 +++--- > .../Include/Protocol/FdtClient.h | 0 > .../Drivers}/FdtClientDxe/FdtClientDxe.c | 0 > .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 0 > .../FdtPciPcdProducerLib.c | 0 > .../Fdt}/HighMemDxe/HighMemDxe.c | 3 ++- > .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.c | 0 > .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 7 ++++--- > Maintainers.txt | 6 ++++++ > 38 files changed, 106 insertions(+), 83 deletions(-) > rename {ArmVirtPkg =3D> EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.i= nf (92%) > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf (77%) > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf (87%) > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.inf (83%) > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf (92%) > rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf =3D> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf (86%) > rename {ArmVirtPkg =3D> EmbeddedPkg}/Include/Protocol/FdtClient.h (100%) > rename {ArmVirtPkg =3D> EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.c (100%) > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c (100%) > rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c (100%) > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.c (95%) > rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.c (100%) > rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c =3D> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.c (93%) > > -- > 2.17.1 > > > >=20 > > ------=_NextPart_000_0067_01D7BE81.829DB070 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

The change in MdePkg is good to me. Reviewed-by: Liming Gao <= gaoliming@byosoft.com.cn>

&nb= sp;

=B7=A2=BC=FE=C8=CB: devel@edk2.grou= ps.io <devel@edk2.groups.io> =B4=FA=B1=ED Abner Chang
=B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C28=C8=D5 11:39
=CA=D5=BC=FE= =C8=CB: devel@edk2.groups.= io; gaoliming@byosoft.com.cn; ardb@kernel.org
=B3=AD=CB=CD: 'Ard Biesheuvel' <ardb+ti= anocore@kernel.org>; 'Leif Lindholm' <leif@nuviainc.com>; 'Sami Mu= jawar' <sami.mujawar@arm.com>; 'Jiewen Yao' <jiewen.yao@intel.com&= gt;; 'Jordan Justen' <jordan.l.justen@intel.com>; 'Gerd Hoffmann' <= ;kraxel@redhat.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; '= Sunil V L' <sunilvl@ventanamicro.com>; 'Zhiguang Liu' <zhiguang.li= u@intel.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
<= /span>=D6=F7=CC=E2: Re:= [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

<= o:p> 

Thanks Liming, could you please = also give the reviewed-by.

 =

Hi Ard, also need your reviewed-by for Arm= Pkg. Then this changes could be upstream and finished.

Thanks

Abner

 

=  

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of gaoliming
Sent= : Friday, October 8, 2021 11:14 AM
To: Chang, Abner (HPS SW/F= W Technologist) <abner.chang@hpe.= com>; 'edk2-devel-groups-io' <devel@edk2.groups.io>; ardb@= kernel.org
Cc: 'Ard Biesheuvel' <ardb+tianocore@kernel.org>; 'Leif Lindholm' <= leif@nuviainc.com>; 'Sami Mujaw= ar' <sami.mujawar@arm.com>= ;; 'Jiewen Yao' <jiewen.yao@inte= l.com>; 'Jordan Justen' <jordan.l.justen@intel.com>; 'Gerd Hoffmann' <kraxel@redhat.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; 'Sun= il V L' <sunilvl@ventanamicr= o.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
Subject= : =BB=D8=B8=B4: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules= to OvmfPkg

 

Ard and Abner:<= /o:p>

 I am OK to add these three PCDs PcdP= ciMmio32Translation, PcdPciMmio64Translation, PcdPciIoTranslation to MdePkg= .

 

Thanks

Liming

=B7=A2=BC=FE=C8=CB: Chang, Abner (HPS S= W/FW Technologist) <abner.chang@h= pe.com>
=B7= =A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA10=D4=C2= 6=C8=D5 17:27
=CA=D5=BC=FE=C8=CB: edk2-devel-groups-io <devel@edk2.groups.io>; ardb@kernel.org; Chang, Abner (HPS SW/FW Te= chnologist) <abner.chang@hpe.com<= /a>>
=B3=AD=CB=CD: Ard Biesheuvel <a= rdb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Sami Mujawar <sami.mujawar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Jordan Juste= n <jordan.l.justen@intel.co= m>; Gerd Hoffmann <kraxel@re= dhat.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>; Sunil V L <sunilvl@ventanamicro.com>; Liming Gao <gaoliming@byosoft.com.cn>; = Zhiguang Liu <zhiguang.liu@int= el.com>; Michael D Kinney <michael.d.kinney@intel.com>
=D6=F7=CC=E2: Re: [edk2-devel] [PATCH V3 00/1= 2] Migrate ArmVirtPkg modules to OvmfPkg

=

 

<= div>

Hi Ard,

=

I realized there is a problem if we duplicat= e ArmPkg defined PCD to under OvmfPkg (e.g. PcdPciIoTranslate PCD) when I was duplicating this PCD to = OvmfPkg.

FdtPciProducerLib is relocated to OvmfPkg/Fdt an= d uses PcdPciIoTranslate PCD declared with OvmfPkg namespace.&nbs= p;FdtPciProducerLib is also used by both ArmVirtPkg  and Ris= cVVirtPkg.=

ArmVirtPkg = uses ArmPciCpuIoDxe provided by ArmPkg however PcdPciIoTranslate used by ArmPciCpuIoDxe  is declared w= ith ArmPkg namespace.

I think this results in the problem becau= se PcdPciIoTranslate(s) that are referred by ArmPkg and = ;ArmVirtPkg come from two different namespaces, right? Unless ArmPciCp= uIoDxe uses the one declared in OvmfPkg, but I don't think we want to = do this.

Thought? Othe= rwise, we should still keep the original patch that relocates these PCDs un= der MdePkg.

=  

Thank= s

Abner=

 

 

=

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Abner Chang <abner.chang@hpe.com>
Sent: Tu= esday, October 5, 2021 11:00 PM
To: edk2-devel-groups-io <devel@edk2.groups.io>; ardb@kernel.org <ardb@kernel.org>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; L= eif Lindholm <leif@nuviainc.com= >; Sami Mujawar <sami.mujawar= @arm.com>; Jiewen Yao <ji= ewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Schaefer, Daniel = <daniel.schaefer@hpe.com&= gt;; Sunil V L <sunilvl@vent= anamicro.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Michael D Kinney &l= t;michael.d.kinney@intel.com<= /a>>
Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVir= tPkg modules to OvmfPkg

 

 

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard B= iesheuvel <ardb@kernel.org>Sent: Tuesday, October 5, 2021 5:30 PM
To: edk2-devel-gro= ups-io <devel@edk2.groups.io= >; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>= ;; Leif Lindholm <leif@nuviainc.com= >; Sami Mujawar <sami.muj= awar@arm.com>; Jiewen Yao <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Schaefer, Dan= iel <daniel.schaefer@hpe.com<= /a>>; Sunil V L <sunilvl@= ventanamicro.com>; Liming Gao <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Michael D Kinne= y <michael.d.kinney@intel.= com>
Subject: Re: [edk2-devel] [PATCH V3 00/12] Migrate Ar= mVirtPkg modules to OvmfPkg

 

<= /div>

On Thu, 30 Sept 2021 at 03:43, Abner Chang <abner.chang@hpe.com> wrote:
>
&= gt; In V3: Address comments on V2.
> In V2: Remove HPE license on the= files that just moved around or
>      = ;  the changes in the file are just code removal.
>
> edk2= BZ #: 3665
> edk2 platform corresponding changes will be submitted a= fter
> this pactch set is reviewed.
>
> This pacthes set = is to migrate some modules from ArmVirtPkg
> to under OvmfPkg for the= upcoming RiscVVirtPkg that can leverage
> those modules without the = dependency with Arm*Pkg.
>
> The modules moved from ArmVirtPkg = to OvmfPkg are,
> - FdtClientDxe
> - PciPcdProducerLib
> = - HighMemDxe
> - QemuFwCfgLib
> - FdtPciHostBridgeLib
> -= VirtioFdtDxe
>
> Below PCDs are moved to under MdePkg and leve= rage by RiscVVirtPkg.
> This change also remove the dependency on Arm= Pkg of OvmfPkg.
> - PcdPciIoTranslation
> - PcdPciIoTranslation=
> - PcdPciMmio32(64)Translation
>
> Signed-off-by: Abner= Chang <abner.chang@hpe.com&g= t;
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mu= jawar <sami.mujawar@arm.com&= gt;
> Cc: Jiewen Yao <jiew= en.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd= Hoffmann <kraxel@redhat.com>= ;
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: L= iming Gao <gaoliming@byosoft= .com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Michael D Kinney <= ;michael.d.kinney@intel.com>
>
> Abner Chang (12):
>   ArmVirtPkg/Fdt= ClintDxe: Move FdtClientDxe to EmbeddedPkg
>   MdePkg: Add = PcdPciIoTranslation PCD
>   ArmPkg: Use PcdPciIoTranslation= PCD from MdePkg
>   ArmVirtPkg/FdtPciPcdProducerLib: Reloc= ate PciPcdProducerLib to OvmfPkg
>   ArmVirtPkg/HighMemDxe:= Relocate HighMemDxe to OvmfPkg
>   OvmfPkg/HighMemDxe: Add= RISC-V in the supported arch.
>   ArmVirtPkg/QemuFwCfgLib:= Relocate QemuFwCfgLib to OvmfPkg
>   OvmfPkg/QemuFwCfgLibM= MIO: Add RISC-V arch support
>   MdePkg: Add PcdPciMmio32(6= 4)Translation PCDs
>   ArmVirtPkg/FdtPciHostBridgeLib: Relo= cate FdtPciHostBridgeLib to
>     OvmfPkg/Fdt
= >   OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported a= rch.
>   ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to = OvmfPkg/Fdt
>

Hello all,

These patches look ok to me, b= ut I wonder if the MdePkg maintainers
are happy taking these PCD declara= tion changes. Translations for PCIe
are typically defined per host bridg= e, and I would rather move away
from using PCDs for this entirely than '= promote' them by carrying them
in MdePkg.

As this issue is somewh= at orthogonal to what Abner is trying to fix,
perhaps it is better to av= oid MdePkg changes for now, and just
duplicate these PCDs into OvmfPkg. = This is reasonable, given that we
know that QEMU only exposes a single h= ost bridge.

The one in ArmPkg can hopefully be removed and replaced = with something
that is more appropriate.


>  ArmPkg/Ar= mPkg.dec           &= nbsp;           &nbs= p;     | 15 ++++++--------
>  ArmVirtPkg/Arm= VirtPkg.dec          &nbs= p;          |  3 ---
&= gt;  EmbeddedPkg/EmbeddedPkg.dec      &n= bsp;            |&nb= sp; 1 +
>  MdePkg/MdePkg.dec      =             &nb= sp;          | 12 +++++++++++<= br>>  ArmVirtPkg/ArmVirtCloudHv.dsc     &n= bsp;           | 18 +++++= +++---------
>  ArmVirtPkg/ArmVirtKvmTool.dsc   &= nbsp;           &nbs= p; | 18 ++++++++---------
>  ArmVirtPkg/ArmVirtQemu.dsc &nb= sp;            =       | 20 +++++++++----------
>  ArmVi= rtPkg/ArmVirtQemuKernel.dsc        =       | 20 +++++++++----------
>  ArmVi= rtPkg/ArmVirtXen.dsc         &= nbsp;           |  2= +-
>  EmbeddedPkg/EmbeddedPkg.dsc     =             &nb= sp; |  1 +
>  ArmVirtPkg/ArmVirtCloudHv.fdf  &nbs= p;            &= nbsp; |  6 +++---
>  ArmVirtPkg/ArmVirtKvmTool.fdf &nb= sp;            =    |  6 +++---
>  ArmVirtPkg/ArmVirtXen.fdf =             &nb= sp;       |  2 +-
>  ArmVirtP= kg/ArmVirtQemuFvMain.fdf.inc        = ;  |  6 +++---
>  .../ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.= inf       |  2 +-
>  .../ArmV= irtGicArchLib/ArmVirtGicArchLib.inf   |  1 +
>  .= ../ArmVirtPL031FdtClientLib.inf       &n= bsp;      |  1 +
>  .../ArmVirtPsc= iResetSystemLib.inf         &n= bsp;   |  1 +
>  .../ArmVirtTimerFdtClientLib.inf=             &nb= sp; |  1 +
>  .../KvmtoolRtcFdtClientLib.inf  &nb= sp;            = |  1 +
>  .../NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf |&= nbsp; 1 +
>  .../NorFlashQemuLib/NorFlashQemuLib.inf  =      |  1 +
>  .../XenAcpiPlatformDxe/X= enAcpiPlatformDxe.inf |  1 +
>  ArmVirtPkg/XenioFdtDxe/Xeni= oFdtDxe.inf        |  1 +
>&n= bsp; .../Drivers}/FdtClientDxe/FdtClientDxe.inf    |  1= -
>  .../FdtPciHostBridgeLib.inf     &= nbsp;           &nbs= p; | 11 +++++-----
>  .../FdtPciPcdProducerLib.inf  &n= bsp;            = ;   |  5 ++---
>  .../Fdt}/HighMemDxe/HighMemDxe.= inf            |&nbs= p; 7 ++++---
>  .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf &nbs= p;      |  2 +-
>  .../Library/Qem= uFwCfgLib/QemuFwCfgLibMmio.inf |  6 +++---
>  .../Include/P= rotocol/FdtClient.h         &n= bsp;    |  0
>  .../Drivers}/FdtClientDxe/Fd= tClientDxe.c      |  0
>  .../FdtP= ciHostBridgeLib/FdtPciHostBridgeLib.c |  0
>  .../FdtPciPcd= ProducerLib.c          &n= bsp;         |  0
> = ; .../Fdt}/HighMemDxe/HighMemDxe.c       = ;       |  3 ++-
>  .../Fdt}/= VirtioFdtDxe/VirtioFdtDxe.c        =   |  0
>  .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c&= nbsp;  |  7 ++++---
>  Maintainers.txt  &nbs= p;            &= nbsp;           &nbs= p;   |  6 ++++++
>  38 files changed, 106 inserti= ons(+), 83 deletions(-)
>  rename {ArmVirtPkg =3D> EmbeddedPk= g/Drivers}/FdtClientDxe/FdtClientDxe.inf (92%)
>  rename {ArmVir= tPkg/Library =3D> OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.i= nf (77%)
>  rename {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtP= ciPcdProducerLib/FdtPciPcdProducerLib.inf (87%)
>  rename {ArmVi= rtPkg =3D> OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.inf (83%)
>  re= name {ArmVirtPkg =3D> OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf (92%)>  rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf =3D>= ; OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf (86%)
>  ren= ame {ArmVirtPkg =3D> EmbeddedPkg}/Include/Protocol/FdtClient.h (100%)>  rename {ArmVirtPkg =3D> EmbeddedPkg/Drivers}/FdtClientDxe/Fd= tClientDxe.c (100%)
>  rename {ArmVirtPkg/Library =3D> OvmfPk= g/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c (100%)
>  renam= e {ArmVirtPkg/Library =3D> OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdPr= oducerLib.c (100%)
>  rename {ArmVirtPkg =3D> OvmfPkg/Fdt}/Hi= ghMemDxe/HighMemDxe.c (95%)
>  rename {ArmVirtPkg =3D> OvmfPk= g/Fdt}/VirtioFdtDxe/VirtioFdtDxe.c (100%)
>  rename ArmVirtPkg/L= ibrary/QemuFwCfgLib/QemuFwCfgLib.c =3D> OvmfPkg/Library/QemuFwCfgLib/Qem= uFwCfgLibMmio.c (93%)
>
> --
> 2.17.1
>
>
= >
>
>
>


=

<= /html> ------=_NextPart_000_0067_01D7BE81.829DB070--