From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 53740940043 for ; Fri, 8 Sep 2023 00:39:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VbGvMJlPub1Hg0BD3LASpoInU41MIV0Ckovq34DAgnE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1694133546; v=1; b=I9TKKd7cHo5SixymEKqNRIJIXu35ST0GUTg0FNFOr+kZ893u9qVpLE8Y8H8TFsbRK11oXVHs wTm8G/qV/Y4exBxQzvdjQv9vlcvNzHD6DIQNvTbZBLT4SYcVyASPTY+KFus1ZusPhuT4WrHLor1 HmGYb8BQmNgtp6WWP4rSKtNA= X-Received: by 127.0.0.2 with SMTP id OHHzYY7687511xCLjEzqCiZx; Thu, 07 Sep 2023 17:39:06 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.29384.1694133544506162392 for ; Thu, 07 Sep 2023 17:39:05 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 488F6DDA85D for ; Fri, 8 Sep 2023 08:39:02 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 444C9DDA85A for ; Fri, 8 Sep 2023 08:39:02 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id A53DBDDA84C for ; Fri, 8 Sep 2023 08:38:58 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Fri, 08 Sep 2023 08:38:51 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Yao, Jiewen'" , , Cc: "'Kinney, Michael D'" , "'Liu, Zhiguang'" , "'Rebecca Cran'" References: <20230906173402.1842-1-mikuback@linux.microsoft.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gTWRlUGtnL0xpYnJhcnkvVGR4TGliOiBSZW1vdmUgdW5uZWNlc3NhcnkgY29tcGFyaXNvbg==?= Date: Fri, 8 Sep 2023 08:38:54 +0800 Message-ID: <006b01d9e1ec$d8c39c90$8a4ad5b0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQFa4psbPxiAI27uVz4tZO9s3UecVwGf/jNIsQEUbmA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KZEJXBVIxYMX8XpDG8oNwwD9x7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I9TKKd7c; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Yao, Jiewen > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA9=D4=C27=C8=D5 7:32 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; mikuback@linux.microsoft.com > =B3=AD=CB=CD: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Rebecca Cran > =D6=F7=CC=E2: RE: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/TdxLib: Remo= ve > unnecessary comparison >=20 > Reviewed-by: Jiewen Yao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Michael > > Kubacki > > Sent: Thursday, September 7, 2023 1:34 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > Rebecca > > Cran > > Subject: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/TdxLib: Remove > > unnecessary comparison > > > > From: Michael Kubacki > > > > Removes the comparison since unsigned values are always greater than > > or equal to 0. > > > > See the following CodeQL query for more info: > > /cpp/cpp-unsigned-comparison-zero/ > > > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Rebecca Cran > > Signed-off-by: Michael Kubacki > > --- > > MdePkg/Library/TdxLib/Rtmr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Library/TdxLib/Rtmr.c b/MdePkg/Library/TdxLib/Rtmr.= c > > index a0283966b353..cbf1dda7bcff 100644 > > --- a/MdePkg/Library/TdxLib/Rtmr.c > > +++ b/MdePkg/Library/TdxLib/Rtmr.c > > @@ -51,7 +51,7 @@ TdExtendRtmr ( > > > > ASSERT (Data !=3D NULL); > > ASSERT (DataLen =3D=3D SHA384_DIGEST_SIZE); > > - ASSERT (Index >=3D 0 && Index < RTMR_COUNT); > > + ASSERT (Index < RTMR_COUNT); > > > > if ((Data =3D=3D NULL) || (DataLen !=3D SHA384_DIGEST_SIZE) || (Inde= x >=3D > > RTMR_COUNT)) { > > return EFI_INVALID_PARAMETER; > > -- > > 2.42.0.windows.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#108335): > https://edk2.groups.io/g/devel/message/108335 > > Mute This Topic: https://groups.io/mt/101198214/1772286 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [jiewen.yao@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108427): https://edk2.groups.io/g/devel/message/108427 Mute This Topic: https://groups.io/mt/101228289/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-