[edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard

[edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

The include guard is incomplete and does not define the macro.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
index a9cbce15302f..d0abcc3452ee 100644
--- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
+++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
@@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
 
 #ifndef BASE_RNGLIB_INTERNALS_H_
+#define BASE_RNGLIB_INTERNALS_H_
 
 /**
   Generates a 16-bit random number.
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108334): https://edk2.groups.io/g/devel/message/108334
Mute This Topic: https://groups.io/mt/101198135/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard

[Rebecca Cran via groups.io]

On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> The include guard is incomplete and does not define the macro.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>   MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> index a9cbce15302f..d0abcc3452ee 100644
> --- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> +++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> @@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>   **/
>   
>   #ifndef BASE_RNGLIB_INTERNALS_H_
> +#define BASE_RNGLIB_INTERNALS_H_
>   
>   /**
>     Generates a 16-bit random number.

Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108343): https://edk2.groups.io/g/devel/message/108343
Mute This Topic: https://groups.io/mt/101198135/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Rebecca Cran <rebecca@os.amperecomputing.com>
> Sent: Wednesday, September 6, 2023 12:47 PM
> To: devel@edk2.groups.io; mikuback@linux.microsoft.com
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Rebecca Cran <rebecca@bsdio.com>
> Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix
> include guard
> 
> On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > The include guard is incomplete and does not define the macro.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > index a9cbce15302f..d0abcc3452ee 100644
> > --- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > +++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > @@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >   **/
> >
> >   #ifndef BASE_RNGLIB_INTERNALS_H_
> > +#define BASE_RNGLIB_INTERNALS_H_
> >
> >   /**
> >     Generates a 16-bit random number.
> 
> Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108422): https://edk2.groups.io/g/devel/message/108422
Mute This Topic: https://groups.io/mt/101198135/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix include guard

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@os.amperecomputing.com>
> 发送时间: 2023年9月7日 3:47
> 收件人: devel@edk2.groups.io; mikuback@linux.microsoft.com
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>;
> Rebecca Cran <rebecca@bsdio.com>
> 主题: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/Library/BaseRngLib: Fix
> include guard
> 
> On 9/6/2023 11:29 AM, Michael Kubacki via groups.io wrote:
> > From: Michael Kubacki <michael.kubacki@microsoft.com>
> >
> > The include guard is incomplete and does not define the macro.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> > ---
> >   MdePkg/Library/BaseRngLib/BaseRngLibInternals.h | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > index a9cbce15302f..d0abcc3452ee 100644
> > --- a/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > +++ b/MdePkg/Library/BaseRngLib/BaseRngLibInternals.h
> > @@ -9,6 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> >   **/
> >
> >   #ifndef BASE_RNGLIB_INTERNALS_H_
> > +#define BASE_RNGLIB_INTERNALS_H_
> >
> >   /**
> >     Generates a 16-bit random number.
> 
> Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108428): https://edk2.groups.io/g/devel/message/108428
Mute This Topic: https://groups.io/mt/101228309/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-