From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <tphan@ventanamicro.com>
Cc: <michael.d.kinney@intel.com>, <zhiguang.liu@intel.com>,
<sunilvl@ventanamicro.com>, <git@danielschaefer.me>
Subject: 回复: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated
Date: Fri, 10 Mar 2023 10:13:42 +0800 [thread overview]
Message-ID: <006d01d952f5$efbfa640$cf3ef2c0$@byosoft.com.cn> (raw)
In-Reply-To: <65120192-67F9-4D8E-9331-9C256735D454@hxcore.ol>
[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]
Tuan:
Can __FUNCTION__ be used? If yes, please still keep it.
Thanks
Liming
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Tuan Phan
发送时间: 2023年3月10日 3:19
收件人: devel@edk2.groups.io
抄送: michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; sunilvl@ventanamicro.com; git@danielschaefer.me
主题: Re: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated
Hi All,
Any updates on this patch?
Thanks,
From: Tuan Phan via groups.io <mailto:tphan=ventanamicro.com@groups.io>
Sent: Monday, March 6, 2023 9:11 AM
To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>
Cc: michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com> ; gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> ; zhiguang.liu@intel.com <mailto:zhiguang.liu@intel.com> ; sunilvl@ventanamicro.com <mailto:sunilvl@ventanamicro.com> ; git@danielschaefer.me <mailto:git@danielschaefer.me> ; Tuan Phan <mailto:tphan@ventanamicro.com>
Subject: [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated
When the range instruction cache invalidating not supported, the whole
instruction cache should be invalidated instead.
Signed-off-by: Tuan Phan <tphan@ventanamicro.com <mailto:tphan@ventanamicro.com> >
---
MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c
index 67a3387ff3c6..a744b2a6f889 100644
--- a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c
+++ b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c
@@ -76,7 +76,10 @@ InvalidateInstructionCacheRange (
IN UINTN Length
)
{
- DEBUG ((DEBUG_ERROR, "%a:RISC-V unsupported function.\n", __FUNCTION__));
+ DEBUG ((DEBUG_WARN,
+ "%a:RISC-V unsupported function.\n"
+ "Invalidating the whole instruction cache instead.\n", __func__));
+ InvalidateInstructionCache ();
return Address;
}
--
2.25.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100744): https://edk2.groups.io/g/devel/message/100744
Mute This Topic: https://groups.io/mt/97429987/7027451
Group Owner: devel+owner@edk2.groups.io <mailto:devel+owner@edk2.groups.io>
Unsubscribe: https://edk2.groups.io/g/devel/unsub [tphan@ventanamicro.com]
-=-=-=-=-=-=
[-- Attachment #2: Type: text/html, Size: 9769 bytes --]
next prev parent reply other threads:[~2023-03-10 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1749E3AC8C2AD5A2.24753@groups.io>
2023-03-09 19:19 ` [edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated Tuan Phan
2023-03-10 2:13 ` gaoliming [this message]
2023-03-10 3:14 ` 回复: " Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006d01d952f5$efbfa640$cf3ef2c0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox