[edk2-devel] 回复: [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF driver

["gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>]

Abner:
  I add my comments.

> -----邮件原件-----
> 发件人: abner.chang@amd.com <abner.chang@amd.com>
> 发送时间: 2023年8月1日 15:57
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Abdul
> Lateef Attar <abdattar@amd.com>
> 主题: [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF
> driver
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> BZ#: 4473
> 
> Signed-off-by: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Abdul Lateef Attar <abdattar@amd.com>
> ---
>  MdePkg/MdePkg.dec | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> index b85614992b9..47d8daba826 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -875,6 +875,12 @@
>    ## Include/Protocol/CcMeasurement.h
>    gEfiCcFinalEventsTableGuid     = { 0xdd4a4648, 0x2de7, 0x4665, { 0x96,
> 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, 0x46 }}
> 
> +  #
> +  # SPI NOR flash JEDEC Serial Flash Discoverable Parameters (SFDP)
driver
> GUID
> +  #
> +  gEdk2JedecSfdpSpiDxeDriverGuid  = { 0xBE71701E, 0xB63C, 0x4574,
> { 0x9C, 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }}
> +  gEdk2JedecSfdpSpiSmmDriverGuid  = { 0x95A1E915, 0x195C, 0x477C,
> { 0x92, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }}
> +

They are for JedecSfdp SPI instance. One GUID can be shared for DXE and SMM.

And, this GUID is not defined in PI spec. So, I suggest to define it into
MdeModulePkg.dec.

Thanks
Liming
>  [Guids.IA32, Guids.X64]
>    ## Include/Guid/Cper.h
>    gEfiIa32X64ErrorTypeCacheCheckGuid = { 0xA55701F5, 0xE3EF, 0x43de,
> { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }}
> @@ -2232,6 +2238,19 @@
>    # @Prompt Speculation Barrier Type.
> 
> gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x01|UINT8|0x3000
> 1018
> 
> +  ## SPI NOR Flash operation retry counts
> +  #  0x00000000:  No retry
> +  #  0xFFFFFFFF:  Maximum retry value
> +  #
> +  # @Prompt SPI NOR Flash Operation Retry Value
> +
> gEfiMdePkgTokenSpaceGuid.PcdSpiNorFlashOperationRetryCount|0xFFFFFFFF
> |UINT32|0x30001019
> +
> +  ## SPI NOR Flash operation delay in microseconds
> +  #  Deafult is set to 0x0000000f microseconds
> +  #
> +  # @Prompt SPI NOR Flash Operation Delay in Microseconds
> +
> gEfiMdePkgTokenSpaceGuid.PcdSpiNorFlashOperationDelayMicroseconds|0x
> 0000000F|UINT32|0x3000101A
> +
>  [PcdsFixedAtBuild,PcdsPatchableInModule]
>    ## Indicates the maximum length of unicode string used in the following
>    #  BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(),
StrCpy(),
> StrnCpy()<BR><BR>
> --
> 2.37.1.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107453): https://edk2.groups.io/g/devel/message/107453
Mute This Topic: https://groups.io/mt/100501078/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-