From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2A3A7D807AB for ; Wed, 2 Aug 2023 08:06:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jmXY8i6Uqx84YO5H3KV4cjvqqMD0C5/hdX3tlXqjkho=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1690963596; v=1; b=sDiU40NpOQ2uVHRHnazPT0AYTQF80cHTzKA2kP9sfKum0nOepRqh+jei2rgWWnYEcyJ9nqCK Uvt+v6CRgHZuDP5Jm0WQpdbbvsHZIT7cnJnySIBY8TcDnUjmaqzgHVMthxDmss0hOcVhZt/StgZ GXKZmjBVivzVDrgbGBm0VJp8= X-Received: by 127.0.0.2 with SMTP id alTSYY7687511xlW81mbuG7d; Wed, 02 Aug 2023 01:06:36 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.9617.1690963595140115203 for ; Wed, 02 Aug 2023 01:06:35 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 73FC5A32E04B for ; Wed, 2 Aug 2023 16:06:32 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 23745A32E002 for ; Wed, 2 Aug 2023 16:06:32 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 31135A32E0AA for ; Wed, 2 Aug 2023 16:06:29 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Wed, 02 Aug 2023 16:06:23 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Michael D Kinney'" , "'Zhiguang Liu'" , "'Abdul Lateef Attar'" References: <20230801075725.1102-1-abner.chang@amd.com> <20230801075725.1102-4-abner.chang@amd.com> In-Reply-To: <20230801075725.1102-4-abner.chang@amd.com> Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIFYyIDMvNl0gTWRlUGtnOiBBZGQgZGVmaW5pdGlvbnMgaW4gREVDIGZvciBTUEkgTk9SIEZsYXNoIFNQREYgZHJpdmVy?= Date: Wed, 2 Aug 2023 16:06:24 +0800 Message-ID: <007201d9c518$3b132e20$b1398a60$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQFXJdGtB9zHTJeIZpHVSnPOBChEGgGr8mCcsM5c0LA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6GGYXZZrd4HKPwi5Rjmw8TOZx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sDiU40Np; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none Abner: I add my comments. > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: abner.chang@amd.com > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA8=D4=C21=C8=D5 15:57 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Abdul > Lateef Attar > =D6=F7=CC=E2: [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR F= lash SPDF > driver >=20 > From: Abner Chang >=20 > BZ#: 4473 >=20 > Signed-off-by: Abner Chang > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Abdul Lateef Attar > --- > MdePkg/MdePkg.dec | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index b85614992b9..47d8daba826 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -875,6 +875,12 @@ > ## Include/Protocol/CcMeasurement.h > gEfiCcFinalEventsTableGuid =3D { 0xdd4a4648, 0x2de7, 0x4665, { 0x9= 6, > 0x4d, 0x21, 0xd9, 0xef, 0x5f, 0xb4, 0x46 }} >=20 > + # > + # SPI NOR flash JEDEC Serial Flash Discoverable Parameters (SFDP) driver > GUID > + # > + gEdk2JedecSfdpSpiDxeDriverGuid =3D { 0xBE71701E, 0xB63C, 0x4574, > { 0x9C, 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }} > + gEdk2JedecSfdpSpiSmmDriverGuid =3D { 0x95A1E915, 0x195C, 0x477C, > { 0x92, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }} > + They are for JedecSfdp SPI instance. One GUID can be shared for DXE and SMM= . And, this GUID is not defined in PI spec. So, I suggest to define it into MdeModulePkg.dec. Thanks Liming > [Guids.IA32, Guids.X64] > ## Include/Guid/Cper.h > gEfiIa32X64ErrorTypeCacheCheckGuid =3D { 0xA55701F5, 0xE3EF, 0x43de, > { 0xAC, 0x72, 0x24, 0x9B, 0x57, 0x3F, 0xAD, 0x2C }} > @@ -2232,6 +2238,19 @@ > # @Prompt Speculation Barrier Type. >=20 > gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x01|UINT8|0x3000 > 1018 >=20 > + ## SPI NOR Flash operation retry counts > + # 0x00000000: No retry > + # 0xFFFFFFFF: Maximum retry value > + # > + # @Prompt SPI NOR Flash Operation Retry Value > + > gEfiMdePkgTokenSpaceGuid.PcdSpiNorFlashOperationRetryCount|0xFFFFFFFF > |UINT32|0x30001019 > + > + ## SPI NOR Flash operation delay in microseconds > + # Deafult is set to 0x0000000f microseconds > + # > + # @Prompt SPI NOR Flash Operation Delay in Microseconds > + > gEfiMdePkgTokenSpaceGuid.PcdSpiNorFlashOperationDelayMicroseconds|0x > 0000000F|UINT32|0x3000101A > + > [PcdsFixedAtBuild,PcdsPatchableInModule] > ## Indicates the maximum length of unicode string used in the followin= g > # BaseLib functions: StrLen(), StrSize(), StrCmp(), StrnCmp(), StrCpy(), > StrnCpy()

> -- > 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107453): https://edk2.groups.io/g/devel/message/107453 Mute This Topic: https://groups.io/mt/100501078/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-