From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Konstantin Aladyshev'" <aladyshev22@gmail.com>, <devel@edk2.groups.io>
Cc: <bob.c.feng@intel.com>, <yuwei.chen@intel.com>
Subject: 回复: [PATCH] BaseTools: Correct BPDG tool error prints
Date: Wed, 21 Sep 2022 08:58:56 +0800 [thread overview]
Message-ID: <007301d8cd55$539f4250$faddc6f0$@byosoft.com.cn> (raw)
In-Reply-To: <20220905091923.23957-1-aladyshev22@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Konstantin Aladyshev <aladyshev22@gmail.com>
> 发送时间: 2022年9月5日 17:19
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.feng@intel.com; gaoliming@byosoft.com.cn;
> yuwei.chen@intel.com; Konstantin Aladyshev <aladyshev22@gmail.com>
> 主题: [PATCH] BaseTools: Correct BPDG tool error prints
>
> Popen communication returns bytestrings. It is necessary to perform
> decode on these strings before passing them to the EdkLogger that
> works with ordinary strings.
>
> Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
> ---
> BaseTools/Source/Python/Common/VpdInfoFile.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Common/VpdInfoFile.py
> b/BaseTools/Source/Python/Common/VpdInfoFile.py
> index 4249b9f899..1e0c3dfe76 100644
> --- a/BaseTools/Source/Python/Common/VpdInfoFile.py
> +++ b/BaseTools/Source/Python/Common/VpdInfoFile.py
> @@ -248,8 +248,8 @@ def CallExtenalBPDGTool(ToolPath, VpdFileName):
> PopenObject.wait()
>
>
>
> if PopenObject.returncode != 0:
>
> - EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool",
> str(error))
>
> + EdkLogger.debug(EdkLogger.DEBUG_1, "Fail to call BPDG tool",
> str(error.decode()))
>
> EdkLogger.error("BPDG", BuildToolError.COMMAND_FAILURE, "Fail
> to execute BPDG tool with exit code: %d, the error message is: \n %s" % \
>
> - (PopenObject.returncode, str(error)))
>
> + (PopenObject.returncode,
> str(error.decode())))
>
>
>
> return PopenObject.returncode
>
> --
> 2.25.1
next prev parent reply other threads:[~2022-09-21 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 9:19 [PATCH] BaseTools: Correct BPDG tool error prints Konstantin Aladyshev
2022-09-21 0:58 ` gaoliming [this message]
2022-10-01 2:31 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007301d8cd55$539f4250$faddc6f0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox